mordochi / ggr_cms Goto Github PK

When entering https://docs.google.com/spreadsheets/d/1whnGiztn9wC7Bt9G6FMiSPxiGndXsMwDoOvfxOh2MWI/edit#gid=587941977 as a sheet, the website crashed.

你們組別的題目蠻有趣的，
但若可以的話請提供範例 Google Spreadsheet，
以提供內容操作。

前端開發建議

1. 階層越多會導致瀏覽器渲染速度會更慢，若之後越寫越有經驗，請將 CSS 階層寫在四層以內，例如 .sheet-block > .table > thead > tr > th 改成 .sheet-block 也可以
2. 除了樣式 reset 外請不要在 HTML 標籤上直接寫 css 樣式，例如 img 的部分，原因是一個網站上會有多頁內容，有可能在每頁的內容都不一樣，若是你寫死每個 HTML 標籤樣式，之後在覆蓋樣式會相當麻煩

Rending all records always dangerous, please do pagination control or limit in SQL query.

      @spreadsheets = Spreadsheet.all
      @tags = Tag.all
      render :spreadsheet_show

What's the point of using ActionCable?

非技術人員可以隨時透過 Google Spreadsheet 來更新網站上的內容
Then you said

Copy the Javascript file.
Paste it in the html file of your website.
Add the xml tag with the id selecting the specific value in the column you choose to the html file.
Then, once you change your spreadsheet, your website also updates immediately.

But they are not tech guys, even not recognized the HTML & javascript, how can it prevent error happens? Also, upload means another deployment.

Why don't we create a javascript SDK file for them to include and can non-tech guy can edit here with auto-update via API from website?

flash[:notice] = "Tag was successfully updated" hardcoded with English only, please use i18n to provide multiple locale support.

If cannot find Tab, it throws ActiveRecord::RecordNotFound, you need a better error handling solution.

  def dimension 
    @tab = Tab.find(params[:id])
    @tab.toggle!(:dimension)

請針對需要的欄位補上 DB indexes 喔，例如 foreign key 都應該加上。

Don't have template and tutorial, regular users are not superusers, they will be hard to understand the logic.

Should have at least one tutorial with screenshot to show how it can be used, and provide google sheet sample.