moov-io / fed Goto Github PK

We need to release Windows binaries on each release.

Search the routing number dictionary for results on the first two digits of a routing number or more. Lookup the RTN and get an array of possible results back. I am not sure if you will need to pass a state in the query or not.

Sending and RTN starting with "07391" should have 91 FedACH results (see below).

An example can be seen here:
https://www.frbservices.org/EPaymentsDirectory/achResults.html?bank=&aba=07391&state=IA&city=+&submitButton=Search&referredBy=searchAchPage

This will ultimately be exposed as a rest endpoint with pagination.

We need to support TLS in our HTTP server. This protects requests from inspection along the various network paths and routing. It's also required as part of several guidelines and audit requirements.

Fed Version: 0.6.0

What were you trying to do?
Conduct an exact match name search for either FedACH or Fedwire.

What did you expect to see?
One result for each participant that matches.

What did you see?
Duplicated results for each participant that matches.

How can we reproduce the problem?

Use the following FedACH data file:

{
    "fedACHParticipants" : {
      "response" : {
        "code" : 100
      },
      "fedACHParticipants" : [
        {
          "routingNumber": "073905527",
          "officeCode": "O",
          "servicingFRBNumber": "071000301",
          "recordTypeCode": "1",
          "changeDate": "012908",
          "newRoutingNumber": "000000000",
          "customerName": "LINCOLN SAVINGS BANK",
          "customerAddress": "P O BOX E",
          "customerCity": "REINBECK",
          "customerState": "IA",
          "customerZip": "50669",
          "customerZipExt": "0159",
          "customerAreaCode" : "319",
          "customerPhonePrefix" : "788",
          "customerPhoneSuffix" : "6441",
          "institutionStatusCode": "1",
          "dataViewCode": "1"
        }
      ]
    }
  }

Run curl "localhost:8086/fed/ach/search?name=LINCOLN+SAVINGS+BANK", output below:

{"achParticipants":[{"routingNumber":"073905527","officeCode":"O","servicingFRBNumber":"071000301","recordTypeCode":"1","revised":"012908","newRoutingNumber":"000000000","customerName":"LINCOLN SAVINGS BANK","achLocation":{"address":"P O BOX E","city":"REINBECK","state":"IA","postalCode":"50669","postalCodeExtension":"0159"},"phoneNumber":"3197886441","statusCode":"1","viewCode":"1"},{"routingNumber":"073905527","officeCode":"O","servicingFRBNumber":"071000301","recordTypeCode":"1","revised":"012908","newRoutingNumber":"000000000","customerName":"LINCOLN SAVINGS BANK","achLocation":{"address":"P O BOX E","city":"REINBECK","state":"IA","postalCode":"50669","postalCodeExtension":"0159"},"phoneNumber":"3197886441","statusCode":"1","viewCode":"1"}],"wireParticipants":null}

Notice that a partial match does not return duplicate results:
Run curl "localhost:8086/fed/ach/search?name=LINCOLN", output below:

{"achParticipants":[{"routingNumber":"073905527","officeCode":"O","servicingFRBNumber":"071000301","recordTypeCode":"1","revised":"012908","newRoutingNumber":"000000000","customerName":"LINCOLN SAVINGS BANK","achLocation":{"address":"P O BOX E","city":"REINBECK","state":"IA","postalCode":"50669","postalCodeExtension":"0159"},"phoneNumber":"3197886441","statusCode":"1","viewCode":"1"}],"wireParticipants":null}

We have a use case where we would like to set x-user-id in the DefaultHeader for every call we make based on a user identifier. However, we're setting up the APIClient when the app starts up so we're not able to set the header at that time, since we want to track every user who makes these API calls. We would also like to avoid setting up a new client every time we want to issue an API call. Would it be possible to have a method attached to APIClient that adds key/value pairs to the DefaultHeader after the client has been created? Something similar to this: https://github.com/moov-io/fed/blob/master/client/client.go#L163. This functionality is also needed in the other APIs as well, ie. paygate, ofac, etc.

Docker container fails to start when FRB_ROUTING_NUMBER and FRB_DOWNLOAD_CODE is set

Steps to reproduce

• start the docker container with env variables
  • FRB_ROUTING_NUMBER=121212
  • FRB_DOWNLOAD_CODE=121212

container fails to start with error - panic: problem downloading fedach: temp file: open /tmp/fedach-3993745650: no such file or directory

Full stack trace

ts=2022-08-02T19:29:10Z msg="Starting fed server version v0.8.1" level=info
ts=2022-08-02T19:29:10Z msg="download: attempting fedach" level=info
ts=2022-08-02T19:29:10Z msg="listening on [::]:9096" level=info
ts=2022-08-02T19:29:11Z msg="admin: problem starting admin http: http: Server closed" level=info
panic: problem downloading fedach: temp file: open /tmp/fedach-3993745650: no such file or directory

goroutine 1 [running]:
main.fedACHDataFile({0xa11860?, 0xc00000c1c8?})
        /go/src/github.com/moov-io/fed/cmd/server/reader.go:20 +0x174
main.main()
        /go/src/github.com/moov-io/fed/cmd/server/main.go:114 +0x506
ts=2022-08-02T19:29:16Z msg="Starting fed server version v0.8.1" level=info
ts=2022-08-02T19:29:16Z msg="download: attempting fedach" level=info
ts=2022-08-02T19:29:16Z msg="listening on [::]:9096" level=info
ts=2022-08-02T19:29:17Z msg="admin: problem starting admin http: http: Server closed" level=info
panic: problem downloading fedach: temp file: open /tmp/fedach-183196970: no such file or directory

goroutine 1 [running]:
main.fedACHDataFile({0xa11860?, 0xc0000a01c8?})
        /go/src/github.com/moov-io/fed/cmd/server/reader.go:20 +0x174
main.main()
        /go/src/github.com/moov-io/fed/cmd/server/main.go:114 +0x506

Looks the error is coming download.go:90 -> ioutil.TempFile(downloadDirectory, fmt.Sprintf("%s-*", listName))
Digging more, error happens when os/tempfile.go -> OpenFile(name, O_RDWR|O_CREATE|O_EXCL, 0600)

Similar to the OFAC setup this service should have the following basic things. The OFAC main.go is also available as a reference.

• clean shutdown on OS signals
• admin HTTP service (using github.com/moov-io/base/admin)
• go-kit logging for INFO and ERROR events
• Separate http.Server with timeouts and shutdown hook
• Port registration in github.com/moov-io/base/http/bind
• GET /ping route for deployment and quick status

Note on auth (replace OFAC with fed here):

Authentication works the following way in paygate:

An HTTP call like GET /v1/depositories/:id with a cookie or OAuth token will hit our LB (traefik) and a "forward auth" call gets made from traefik to our auth service. The cookie or OAuth token is checked, and if valid '200 OK' is returned to traefik. Only on that '200 OK' is the actual request proxied to paygate (or in this case ofac).

fed api searcher, read FedACHdir.txt file into memory, similar to ofac searcher

Review moov-io\ofac\cmd\server\download.go for basic model

For FEDACH research/consider converting url parameters to ToUpper, should eliminate need for preCompute for FEDACH

Add WireDirectory Test Examples

Hey there,

We're going to start using this project for transfers in our app and some of our designs call for some nice touches like having the logo of the bank and the banks website so you can confirm its correct.

I'd love to see us contribute something like this back if you all or the community at large finds it useful.

Frankly this is something I'd usually just build an index for since it does not change all that often but since Moov is here and I like @wadearnold I figure adding it to this project could benefit the ecosystem at large.

thoughts on this?

I realize if we added logos it would likely eat up some S3 bandwidth costs so will throw that in as a consideration too to be discussed.

Alternatively just adding urls you could use something like the clearbit logo API to make it work without potentially causing any sort of bandwidth problem

I expect a function to take a routing number as input and return a valid record if it exists and nil if it does not.

We need to write up mock endpoints for the HTTP service(s) in this project. There looks to be the following:

• Search on ABA routing numbers and FI name -> ABA #'s
• ABA and name lookup for Wire information

Links

• OpenAPI specification
• OFAC Example spec

I expect to be able to Lookup a financial institution based on its name. This should leverage an exact match of the string initially and return nil if not found.

Add ACHDirectory Test examples

The openapi.yaml specs define these properties:

    ACHDictionary:
      description: Search results containing ACHDictionary of Participants
      properties:
        ACHParticipants:

    WIREDictionary:
      description: Search results containing WIREDictionary of Participants
      properties:
        WIREParticipants:

These properties are starting with upper case letters.

However, the service actually returns fields named achParticipants and wireParticipants (starting lower case). This is breaking clients that are automatically generated from the openapi.yaml file.

Please update the openapi.yaml file. Thank you!

This issue lists Renovate updates and detected dependencies. Read the Dependency Dashboard docs to learn more.

Awaiting Schedule

These updates are awaiting their schedule. Click on a checkbox to get an update now.

• chore(deps): update all (major) (actions/checkout, actions/setup-go, bulma-clean-theme, github.com/docker/docker, github.com/hashicorp/golang-lru, github/codeql-action)
• chore(deps): update github artifact actions to v4 (major) (actions/download-artifact, actions/upload-artifact)

Open

These updates have all been created already. Click a checkbox below to force a retry/rebase of any.

• fix(deps): update all (github.com/moov-io/base, go)

Detected dependencies

• Check this box to trigger a request for Renovate to run again on this repository

If a 1-2-1 match is not found in the Name search and optional fuzzy search could be used to handle misspelling or other issues if the name was not found.

A package such as Fuzzy Search could be added to the Bank Name field for better results.

Additional packages to be tested closesmatch

Add travis ci build badge and codecov to readme

Allow search to filter on Zip Code and State Abbreviations.

Farmers State Bank

Is a good example of a search that requires additional filter information to narrow down the result.

The project contains and ACH endpoints and Fedwire endpoints. Currently only the ACH directory is parsed and exposed. We should add FedWire at some point.

Add Error Response

For clarification , the docker image is useful to run solely http server, the actual data file link still needs to exist in order to make calls.

I initially thought the lib helped run standalone validation for ACH and wire.

Docker container fails to start when FRB_ROUTING_NUMBER and FRB_DOWNLOAD_CODE is set

Steps to reproduce

• start the docker container with env variables
  • FRB_ROUTING_NUMBER=121212
  • FRB_DOWNLOAD_CODE=121212
• the container fails to start with error - panic: problem downloading fedach: temp file: open /tmp/fedach-3993745650: no such file or directory

Full stack trace

ts=2022-08-02T19:29:10Z msg="Starting fed server version v0.8.1" level=info
ts=2022-08-02T19:29:10Z msg="download: attempting fedach" level=info
ts=2022-08-02T19:29:10Z msg="listening on [::]:9096" level=info
ts=2022-08-02T19:29:11Z msg="admin: problem starting admin http: http: Server closed" level=info
panic: problem downloading fedach: temp file: open /tmp/fedach-3993745650: no such file or directory

goroutine 1 [running]:
main.fedACHDataFile({0xa11860?, 0xc00000c1c8?})
        /go/src/github.com/moov-io/fed/cmd/server/reader.go:20 +0x174
main.main()
        /go/src/github.com/moov-io/fed/cmd/server/main.go:114 +0x506
ts=2022-08-02T19:29:16Z msg="Starting fed server version v0.8.1" level=info
ts=2022-08-02T19:29:16Z msg="download: attempting fedach" level=info
ts=2022-08-02T19:29:16Z msg="listening on [::]:9096" level=info
ts=2022-08-02T19:29:17Z msg="admin: problem starting admin http: http: Server closed" level=info
panic: problem downloading fedach: temp file: open /tmp/fedach-183196970: no such file or directory

goroutine 1 [running]:
main.fedACHDataFile({0xa11860?, 0xc0000a01c8?})
        /go/src/github.com/moov-io/fed/cmd/server/reader.go:20 +0x174
main.main()
        /go/src/github.com/moov-io/fed/cmd/server/main.go:114 +0x506

Looks the error is coming from download.go:90 -> ioutil.TempFile(downloadDirectory, fmt.Sprintf("%s-*", listName))
Digging more, error happens when in os/tempfile.go -> OpenFile(name, O_RDWR|O_CREATE|O_EXCL, 0600)

Update search values in openapi.yml

fed/ach/search

Update City, State, and Postal Code

fed/wire/search

Update City and State

Update schema examples to match search examples

Remove minimum and maximum from search

quote example string values

updates for ping

Add code for fed/wire/search

Offering a logo for each FI and their homepage in search results would make it easier for consumers of Fed to display both in their applications. There's no central / authoritative source for this information, but we may be able to scrape it.

This is an issue to discuss the feature and how we'd implement it as it's been mentioned on slack.

Add a copywriter of moov developers and add an Apache 2 license to the project

What were you trying to do?
To deploy on OpenShift we need to use their base image. This allows a common setup for deployment, scanning, etc.

Also, publish the images to https://quay.io/, Red Hat’s image repository.

It would be fantastic to have a web interface included with Fed for manual searching of the data. This allows for verifying data with specific queries and perform one-off searches that are often needed for support cases.

Example projects with web interfaces in moov-io

• https://github.com/moov-io/ach-web-viewer
• https://github.com/moov-io/watchman

The docs state environmental variables, but those aren't read out. Environmental variables split words with underscores.

• ACH_JARO_WINKLER_SIMILARITY
• ACH_LEVENSHTEIN_SIMILARITY

Problem

Both FedACH and FedWire search returns SearchResponse struct but openapi spec says that it returns ACHDictionary and WIREDictionary respectively.

Resolution

openapi spec should be updated to return SearchResponse struct for both FedACH and FedWire.

Hi there,

Currently this routing number 322286188 is listed as

Racho Santa Fe Thrift & Loan but the bank has been renamed to Hatch Bank - would be great to update that in this file if possible

Add codecov, staticcheck, etc, use ofac .travis.yml as a model

Add .codecov.yml

WireDirectory Fuzzy search on Bank Name

WireDirectory Routing Number Search (minimum 2 digit search)