mooshetv / hyperfive Goto Github PK

Hello!

First of all thanks for this amazing framework! Nice and lightweight!

The bug I found is happend when the SteamID is required, and you try to join withouth it.
The script will try to drop the player with: player.Drop(reson) but in the playerConnecting event, you can't use Drop.
It will prevent the player from joining, just don't show the reason to him. He will see a failed attempt to joining the server.

The solution is the following:
In Server/Player/SessionManager.cs replace the playerConnecting RegisterEventHandler with this:

server.RegisterEventHandler( "playerConnecting", new Action<CitizenFX.Core.Player, string, dynamic, dynamic>( OnSessionPreLoad ) );

And OnSessionPreLoad method with this:

private void OnSessionPreLoad( [FromSource] CitizenFX.Core.Player player, string name, dynamic kickReason, dynamic deferrals) {
	try {
		deferrals.defer();

		var session = new Session( player );
		if( Server.IsSteamRequired && session.SteamId64 == 0 ) {

			deferrals.done( "Steam is required to play on this server." );
			API.CancelEvent();
			return;
		} else 

		deferrals.done();

		_sessions.Add( session );
		Log.Info( $"{session.Name} (net:{session.NetId}) has connected." );
	}
	catch( Exception ex ) {
		Log.Error( ex );
	}
}

Keep up the good wirk Sir!