The carbon_challenge from moliqingwa

Some problems

1.The file of https://github.com/moliqingwa/carbon_challenge/blob/master/zerosum_env/envs/__init__.py can be deleted, or it will be regarded as a env named __init__.py , and there are some warnings like Loading environment __init__.py failed: No module named 'zerosum_env.envs.__init__.py'; 'zerosum_env.envs.__init__' is not a package when runing the import zerosum_env

2.The file of https://github.com/moliqingwa/carbon_challenge/blob/master/zerosum_env/envs/carbon/test_carbon.py can be deleted because it is modified from the test_halite.py, some unittest maybe wrong and also some code have not been modify like

carbon_challenge/zerosum_env/envs/carbon/test_carbon.py

Line 46 in 2e65f7e

recrtCenter.next_action = RecrtCenterAction.SPAWN

carbon_challenge/zerosum_env/envs/carbon/test_carbon.py

Line 119 in 2e65f7e

opponent_worker.next_action = WorkerAction.CONVERT

carbon_challenge/zerosum_env/envs/carbon/test_carbon.py

Line 179 in 2e65f7e

worker.next_action = WorkerAction.CONVERT

and others. The action SPAWN or CONVERT does not belong to the carbon env.

3.The render of the html seems to only support the 2 agents, when the agents is 1 or 4, the visualization of the html open by the Browser are show below:

So if we don't want to support the visualization of the 4 agents or 1 agents, maybe we can modify the readme file blow:

carbon_challenge/README.md

Line 99 in 2e65f7e

# 确定地图选手数(只能是1,2,4)

And provide the example the train_selfplay with 2 agents in the readme file.

carbon_challenge/README.md

Line 284 in 2e65f7e

trainer = env.train_selfplay([None, None, 'random', 'random'])

Also

carbon_challenge/zerosum_env/envs/carbon/carbon.py

Lines 262 to 275 in 2e65f7e

 if num_agents == 1: 

 starting_positions[0] = size * (size // 2) + size // 2 

 elif num_agents == 2: 

 # starting_positions[0] = size * (size // 2) + size // 4 

 # starting_positions[1] = size * (size // 2) + math.ceil(3 * size / 4) - 1 

 starting_positions[0] = size * (size // 4 + config.startPosOffset) + size // 4 + config.startPosOffset 

 starting_positions[1] = size * (3 * size // 4 - config.startPosOffset) + 3 * size // 4 - config.startPosOffset 

 obs.carbon[starting_positions[0]] = 0 

 obs.carbon[starting_positions[1]] = 0 

 elif num_agents == 4: 

 starting_positions[0] = size * (size // 4) + size // 4 

 starting_positions[1] = size * (size // 4) + 3 * size // 4 

 starting_positions[2] = size * (3 * size // 4) + size // 4 

 starting_positions[3] = size * (3 * size // 4) + 3 * size // 4

and https://github.com/moliqingwa/carbon_challenge/blob/2e65f7ec89c7f7c9af81056afe495665c18141cd/zerosum_env/envs/carbon/carbon.json#L6-L0
can be reduced to only support 2.

4.readme中捕碳员或种树员上限为10， collector 和 plantor 总和10 还是各自10？代码是总和10，确认下。

carbon_challenge/zerosum_env/envs/carbon/helpers.py

Lines 875 to 891 in 2e65f7e

 for recrtCenter in player.recrtCenters: 

 # 招募捕碳员指令 

 if recrtCenter.next_action == RecrtCenterAction.RECCOLLECTOR and player.cash >= rec_collector_cost and len( 

 player.workers) < configuration.worker_limit: # and len(player.collectors) < configuration.collector_limit # 暂时不控制捕碳员的数量 

 # Handle RECCOLLECTOR actions 

 player._cash = round(player._cash - rec_collector_cost, 2) 

 board._add_worker( 

 Collector(WorkerId(new_worker_id(player.id)), recrtCenter.position, 0, player.id, board)) 

 # 招募种树员指令 

 if recrtCenter.next_action == RecrtCenterAction.RECPLANTOR and player.cash >= rec_plantor_cost and len( 

 player.workers) < configuration.worker_limit: # and len(player.plantors) < configuration.plantor_limit # 暂时不控制种树员的数量 

 # Handle RECPLANTOR actions 

 player._cash = round(player._cash - rec_plantor_cost, 2) 

 board._add_worker( 

 Plantor(WorkerId(new_worker_id(player.id)), recrtCenter.position, 0, player.id, board)) 

 # Clear the recrtCenter's action so it doesn't repeat the same action automatically 

 recrtCenter.next_action = None

readme 中的个别注释还存在飞船字段还没有修改。

moliqingwa / carbon_challenge Goto Github PK

carbon_challenge's People

Contributors

Stargazers

Watchers

Forkers

carbon_challenge's Issues

Some problems

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent

	if num_agents == 1:
	starting_positions[0] = size * (size // 2) + size // 2
	elif num_agents == 2:
	# starting_positions[0] = size * (size // 2) + size // 4
	# starting_positions[1] = size * (size // 2) + math.ceil(3 * size / 4) - 1
	starting_positions[0] = size * (size // 4 + config.startPosOffset) + size // 4 + config.startPosOffset
	starting_positions[1] = size * (3 * size // 4 - config.startPosOffset) + 3 * size // 4 - config.startPosOffset
	obs.carbon[starting_positions[0]] = 0
	obs.carbon[starting_positions[1]] = 0
	elif num_agents == 4:
	starting_positions[0] = size * (size // 4) + size // 4
	starting_positions[1] = size * (size // 4) + 3 * size // 4
	starting_positions[2] = size * (3 * size // 4) + size // 4
	starting_positions[3] = size * (3 * size // 4) + 3 * size // 4

	for recrtCenter in player.recrtCenters:
	# 招募捕碳员指令
	if recrtCenter.next_action == RecrtCenterAction.RECCOLLECTOR and player.cash >= rec_collector_cost and len(
	player.workers) < configuration.worker_limit: # and len(player.collectors) < configuration.collector_limit # 暂时不控制捕碳员的数量
	# Handle RECCOLLECTOR actions
	player._cash = round(player._cash - rec_collector_cost, 2)
	board._add_worker(
	Collector(WorkerId(new_worker_id(player.id)), recrtCenter.position, 0, player.id, board))
	# 招募种树员指令
	if recrtCenter.next_action == RecrtCenterAction.RECPLANTOR and player.cash >= rec_plantor_cost and len(
	player.workers) < configuration.worker_limit: # and len(player.plantors) < configuration.plantor_limit # 暂时不控制种树员的数量
	# Handle RECPLANTOR actions
	player._cash = round(player._cash - rec_plantor_cost, 2)
	board._add_worker(
	Plantor(WorkerId(new_worker_id(player.id)), recrtCenter.position, 0, player.id, board))
	# Clear the recrtCenter's action so it doesn't repeat the same action automatically
	recrtCenter.next_action = None