Git Product home page Git Product logo

accountsclient's People

Contributors

grum avatar mollstam avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

accountsclient's Issues

Expand API to display Twitch account

There are some Twitch channels like GeekAndSundry that have Twitch sub only Minecraft servers. It would be nice to be able to query the Twitch profile name of users who join the server (if linked). This gives admins or some kind of automation the information needed to verify if the new player is one of their Twitch subscribers.

Missing license

I am currently working on a ban-lookup library for minecraft that I am publishing under the Apache 2 license.

As it stands right now, AccountsClient has no published artifacts, meaning I have to include it in my artifact or submit it as a 3rd-party artifact - both paths concern me in terms of legality.

I would really appreciate it if mojang could apply some manner of OSS license to the project.

Publish to Maven Repository

I'm looking at using this library for UUID conversions in one of my mavenized projects, and it'd be way easier if this library were available in an existing maven repository (preferably Central for convenience).

Umlauts in username?

Getting the UUID for player u returns user ü:

{
  "profiles": [
    {
      "id": "c6893ba47cfd4002abea33d4b1bd3f7a",
      "name": "ü",
      "legacy": true
    }
  ],
  "size": 1
}

Did you allow umlauts in usernames some time ago, or is that an error?

Expand API to check for paid account

Currently the API don't return a result for unpaid accounts. It would be nice to still get the result, but an additional field with the current paid status.

The problem is that are users registered to my server, that had once a paid account. Later Mojang marked the payment as invalid. If these users use another gift code, they'll have a paid account again and could join my server.

If in the future it will be possible to change usernames, there is no way to track if the users with an empty ID are the same users.

So it should be possible to get the IDs of the unpaid accounts, too. Those IDs are bound to the account and doesn't change with the current payment status.

No results for about 0.1% of the players

AccountsClient returns no result for several players. About 50 of 36000.

Some example user names:
Pups1924
derJonas1304
TheFlo2001
flash3838
Plarun
zxZDerShaenZxz
koffermodus
LPXerios
TheCheater1998
ReyTronix
CrafterRamon2000
FCAugsburgs

Bad design for bulk queries

Why does every user need an agent? This is way more data than required.
Instead of

[
  {"name":"jeb_", "agent": "minecraft"},
  {"name":"Dinnerbone", "agent":"minecraft"}
]

it would be much better (saving badwith and time) to use:

[
  {
    "agent": "minecraft",
    "names": ["jeb_", "Dinnerbone"]
  }
]

It would still be possible to get usernames for different agents (Scrolls?) in the same request although I can hardly imagine a case where that would happen.

I made a quick test with 50 users and the payload went from 2401 bytes to 938 (!)
The normal payload is more than 2.5 x the size.

Support for this doesn't break the current system, so there's only pros and no cons. :)

Convert UUID -> Username

So currently we can convert a Username -> UUID but as far as I'm aware you can't convert UUID -> Username. This feature is very much needed. Thanks Mojang for all your work so far!

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.