Git Product home page Git Product logo

drinkable's People

Contributors

2bllk avatar alaunay avatar alex-sandro92 avatar anton-gustafsson avatar bitwave avatar bootjewolf avatar carolyna avatar enigmind avatar imgbot[bot] avatar imgbotapp avatar jarmuszz avatar jensens avatar khjcode avatar kojid0 avatar lezohtml avatar marcel8168 avatar mr-bajs avatar pandermusubi avatar ramar-rar avatar renovate-bot avatar renovate[bot] avatar rhodney avatar seg1do avatar smart-sangge avatar xetarusx avatar yottamxt avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar

drinkable's Issues

Remember last profile.

It whuld be nice for the application to remember last profile used.

the app always fall back to the first made user profile.

Nott a bigg deal but a enhancement.

love the app. Ty

Record_2023-10-14-19-41-54.mp4

Inclusion of all IBA Cocktails

Drinkable should include all cocktails listed in the International Bartenders Association (IBA). The IBA sets industry standards for cocktail recipes.

https://thebarcabinet.com/recipes/international-bartenders-association-recognised-cocktails/

  • - Trinidad Sour
  • - Barracuda
  • - Bloody Mary
  • - Caipirinha
  • - Cosmopolitan
  • - Espresso Martini
  • - Gin Fizz
  • - Horse’s Neck
  • - Last word
  • - Margarita
  • - Mojito
  • - New York Sour
  • - Paradise
  • - Porto Flip
  • - Sea Breeze
  • - Spicy Fifty
  • - Tipperary
  • - Vieux Carrè
  • - Alexander
  • - Bee’s Knees
  • - Boulevardier
  • - Casino
  • - Cuba Libre
  • - Fernandito
  • - Golden Dream
  • - Illegal
  • - Lemon drop Martini
  • - Martinez
  • - Monkey Gland
  • - Old Cuban
  • - Penicillin
  • - Ramos Fizz
  • - Sex on the Beach
  • - Spritz
  • - Tommy’s Margarita
  • - Whiskey Sour
  • - Americano
  • - Bellini
  • - Bramble
  • - Champagne Cocktail
  • - Daiquiri
  • - French 75
  • - Grasshopper
  • - Irish Coffee
  • - Long Island Ice Tea
  • - Mary Pickford
  • - Moscow Mule
  • - Old Fashioned
  • - Pina Colada
  • - Russian Spring Punch
  • - Sidecar
  • - Stinger
  • - Tuxedo
  • - White Lady
  • - Angel Face
  • - Between the Sheets
  • - Brandy Crusta
  • - Clover Club
  • - Dark ‘n’ stormy
  • - French Connection
  • - Hanky Panky
  • - John Collins
  • - Mai-Tai
  • - Mimosa
  • - Naked and Famous
  • - Paloma
  • - Pisco Sour
  • - Rusty Nail
  • - Singapore Sling
  • - Suffering Bastard
  • - VE.N.TO
  • - Yellow Bird
  • - Aviation
  • - Black Russian
  • - Canchanchara
  • - Corpse Reviver
  • - Dry Martini
  • - French Martini
  • - Hemingway Special
  • - KIR
  • - Manhattan
  • - Mint Julep
  • - Negroni
  • - Paper Plane
  • - Planter’s Punch
  • - Sazerac
  • - Southside
  • - Tequila Sunrise
  • - Vesper
  • - Zombie

Obsolete dependencies

In the install app dependencies test shows this:

_Run npm ci
npm WARN deprecated [email protected]: Please see https://github.com/lydell/urix#deprecated
npm WARN deprecated [email protected]: See https://github.com/lydell/source-map-url#deprecated
npm WARN deprecated [email protected]: See https://github.com/lydell/source-map-resolve#deprecated
npm WARN deprecated [email protected]: https://github.com/lydell/resolve-url#deprecated
npm WARN deprecated [email protected]: Chokidar 2 does not receive security updates since 2019. Upgrade to chokidar 3 with 15x fewer dependencies
npm WARN deprecated @babel/[email protected]: This proposal has been merged to the ECMAScript standard and thus this plugin is no longer maintained. Please use @babel/plugin-transform-class-properties instead.

added 1813 packages, and audited 1814 packages in 28s

226 packages are looking for funding
run npm fund for details

7 high severity vulnerabilities

To address issues that do not require attention, run:
npm audit fix

To address all issues (including breaking changes), run:
npm audit fix --force

Run npm audit for details._

So is the app are using old obsolste depenencies, if so then it should be updated.

Export/Import function

Any way to add a Export/Import function in Settings to backup your recipes and ingredients to a file, should you need to reinstall the app?

Upload an apk

Please add the apk file for the download direct from git

Localizations (translation)

Please add translations so you can configure a language in the options.

You could auto-generate these, for example with some tool that uses DeepL (I don't know which tool would be best for generating the translated strings) or simply by copy pasting all of them at once into DeepL.

It wouldn't be important to translate the instructions, it would be sufficient if the ingredients were translated.

Enable the Use of Fractional Measurements for Quantity/Volume Field

Enabling the use of fractional measurements for the quantity/volume field. Currently, the app only accepts decimal measurements, which can be challenging to read when imbibing. I propose using the "slash" character to represent fractions, making it easier for users to measure and mix their cocktails accurately.

For instance, 2/3 fl oz would be more readable than 0.66 fl oz.

This feature would be a great addition to the app and could help users measure their cocktail ingredients more accurately.

Possibility to add new ingredients?

First off, congratulations for the app. It's really will made and the UI is very beautiful.

I noticed some ingredients are missing like baileys and limoncello. Could you add a feature for users to add ingredients ?
I assume these aren't in the database because there's probably no drink there with this ingredients already

Thank you for your time!

Dependency Dashboard

This issue lists Renovate updates and detected dependencies. Read the Dependency Dashboard docs to learn more.

Rate-Limited

These updates are currently rate-limited. Click on a checkbox below to force their creation now.

  • fix(deps): update all non-major dependencies (@supabase/supabase-js, @types/node, @typescript-eslint/eslint-plugin, @typescript-eslint/parser, aurelia-bootstrapper, cypress, daisyui, i18next-http-backend, postcss-preset-env, sass)
  • fix(deps): update dependency com.android.tools.build:gradle to v8.4.0
  • fix(deps): update dependency org.jetbrains.kotlin:kotlin-gradle-plugin to v1.9.24
  • chore(deps): update dependency cssnano to v7
  • chore(deps): update dependency eslint-plugin-cypress to v3
  • chore(deps): update dependency style-loader to v4
  • fix(deps): update capacitor monorepo to v6 (major) (@capacitor/android, @capacitor/cli, @capacitor/core, @capacitor/ios)
  • fix(deps): update dependency @capacitor/app to v6
  • fix(deps): update dependency @capacitor/clipboard to v6
  • fix(deps): update dependency @capacitor/filesystem to v6
  • fix(deps): update dependency @capacitor/preferences to v6
  • 🔐 Create all rate-limited PRs at once 🔐

Open

These updates have all been created already. Click a checkbox below to force a retry/rebase of any.

Ignored or Blocked

These are blocked by an existing closed PR and will not be recreated unless you click a checkbox below.

Detected dependencies

bundler
Gemfile
  • fastlane undefined
cocoapods
ios/App/Podfile
github-actions
.github/workflows/ci.yml
  • actions/checkout v4
  • actions/setup-node v4
  • cypress-io/github-action v6.6.1
.github/workflows/fastlane-internal.yml
  • actions/checkout v4
  • ashutoshgngwr/validate-fastlane-supply-metadata v2
  • actions/setup-java v4
  • actions/setup-node v4
  • SpicyPizza/create-envfile v2.0.3
gradle
android/gradle.properties
android/capacitor.settings.gradle
android/settings.gradle
android/variables.gradle
  • androidx.core:core-splashscreen 1.0.0
  • androidx.coordinatorlayout:coordinatorlayout 1.2.0
  • androidx.appcompat:appcompat 1.6.1
  • junit:junit 4.13.2
  • androidx.test.ext:junit 1.1.5
  • androidx.test.espresso:espresso-core 3.5.1
android/build.gradle
  • com.android.tools.build:gradle 8.0.0
  • com.google.gms:google-services 4.3.15
  • org.jetbrains.kotlin:kotlin-gradle-plugin 1.7.20
android/app/capacitor.build.gradle
android/app/build.gradle
gradle-wrapper
android/gradle/wrapper/gradle-wrapper.properties
  • gradle 8.0.2
npm
package.json
  • @capacitor/android ^5.0.0
  • @capacitor/app ^5.0.0
  • @capacitor/clipboard ^5.0.6
  • @capacitor/core ^5.0.0
  • @capacitor/filesystem ^5.2.1
  • @capacitor/ios ^5.7.4
  • @capacitor/preferences ^5.0.0
  • @moimob/common ^0.2.0
  • @supabase/supabase-js 2.42.4
  • aurelia-animator-css 1.0.4
  • aurelia-bootstrapper 2.4.0
  • aurelia-dialog 2.0.0
  • aurelia-event-aggregator 1.0.3
  • aurelia-hotjar 1.0.1
  • aurelia-i18n 4.0.4
  • aurelia-validation 2.0.0
  • base64-arraybuffer 1.0.2
  • compressorjs 1.2.1
  • cypress 13.7.3
  • daisyui ^4.4.19
  • dotenv-webpack 8.1.0
  • i18next-http-backend 2.5.0
  • magic-snowflakes 6.3.0
  • postcss-preset-env 9.5.5
  • sortablejs 1.15.2
  • swipejs 2.3.1
  • tiny-swiper 2.2.0
  • ts-node 10.9.2
  • uuid 9.0.1
  • @capacitor/cli ^5.0.0
  • @types/jest 29.5.12
  • @types/node ^20.1.7
  • @types/webpack 5.28.5
  • @typescript-eslint/eslint-plugin ^7.0.0
  • @typescript-eslint/parser ^7.0.0
  • aurelia-webpack-plugin 5.0.6
  • autoprefixer 10.4.19
  • clean-webpack-plugin 4.0.0
  • copy-webpack-plugin 12.0.2
  • css-loader 6.11.0
  • cssnano ^6.0.0
  • duplicate-package-checker-webpack-plugin 3.0.0
  • eslint 8.57.0
  • eslint-config-prettier ^9.0.0
  • eslint-plugin-cypress ^2.14.0
  • eslint-webpack-plugin ^4.0.1
  • html-loader 5.0.0
  • html-webpack-plugin 5.6.0
  • htmlhint ^1.1.4
  • jest 29.7.0
  • jest-environment-jsdom 29.7.0
  • mini-css-extract-plugin 2.9.0
  • postcss 8.4.38
  • postcss-loader 8.1.1
  • prettier ^3.0.3
  • prettier-plugin-organize-attributes ^1.0.0
  • reflect-metadata 0.2.2
  • sass 1.75.0
  • sass-loader 14.2.1
  • style-loader 3.3.4
  • tailwindcss 3.4.3
  • ts-jest 29.1.2
  • ts-loader 9.5.1
  • typescript ^5.1.6
  • webpack ^5.88.1
  • webpack-bundle-analyzer 4.10.2
  • webpack-cli 5.1.4
  • webpack-dev-server 4.15.2
  • node >=10.12.0

  • Check this box to trigger a request for Renovate to run again on this repository

Bugg inn favorites after chaging filters

When i navigate

  • home-favorites-filters

  • remove ((show only favorites))

  • and add some other filter

  • choose a drink and go back

The bugg has now added back ((show only favorites))

Record_2023-10-11-22-35-15.mp4

Add 4 new options to the "unit" drop-down for custom cocktails

Currently, the "unit" drop-down for custom cocktails only offers fluid ounces or milliliters for measuring ingredients. However, some ingredients like bitters, which are often measured in a dash, splash, slice, or wedge, cannot be accurately measured in fluid ounces or milliliters.

To support more accurate measurements, the addition of at least four more options to the "unit" drop-down:

Dash
Splash
Slice
Wedge

By adding these options, users will be able to accurately input the correct measurement for bitters and other ingredients that do not fit into fluid ounces or milliliters.

TheCocktailDB integration

https://www.thecocktaildb.com/

Another open source solution for cocktails that happens to have a lot more drinks listed.

Two ways this can go about:

-Add it all manually
-Integrate the Database into the App itself

Of course, I'm making this suggestion with the intent that you're at least partially aware of it. It would be interesting to see their clunky site in a more consumable fashion. There's thousands of attempts on GitHub too with apps and web clients, but none of them seem as easy or efficient to use as your app.

But that's just my suggestion. Depending on the answer, I can try making a list/sheet of all the missing Cocktails currently present on the database.

Contact developer: Send button not working

When I hit the button to send you a message, nothing happens. It either doesn't work or you should implement a hint stating that the message has been successfully sent (and clear the form afterwards).

Ability to add custom mesurements and enhancing "instructions" when creating cocktails

Hello there
First and foremost I would like to praise the app which has a very intuitive design and a good amount of drinks pre-made from the get-go.

I have the following suggestions that might improve the app:

  1. I'm unable to set my own measurements when creating a drink (lack the option to set grams, sprigs, halves and so on).

  2. the "instructions" tab when creating a drink doesn't respect line breaks, which would make reading the different steps easier.

  3. Doesn't allow setting multiple categories and creating ones own categories (E.g. Setting "cocktail" and creating and setting the category "IBA").

Infos about translations and cocktail

It will be translationable the ingredients and instructions(in different files) in the future(maybe on crowdin or weblate)?

Who is the current main source of the cocktails?

Touch issue

Tapping just above the bottom bar still triggers button bar buttons, which seem to be placed higher than it was meant to.
Here's a video of it.

[Typo] Alabama Slammer

One of the ingredients for the Alabama slammer is listed as "Lime Juice (Or Lime)". This is clearly meant to be "Lemon Juice (Or Lime)" based on the context of the instructions.

multiple Ingridiense lists

I have some ingridionse home

So when i go to frends house ther are diffrent dlinks i can mixs sints i don't bring all my ingrediesne.

ther whud be awsome to have difflent lists if you are home, at a frend or enjoying moktail at work. And store them separat.

love the app tonk you

Add AppStore enum to contactForm submissions

Add Appstore enum. Something like this

export enum AppStore {
Unknown = 0,
PlayStore = 1,
Fdroid = 2,
}

Pass the value to cocktailSubmission api so i know what store people are using when answering emails

Add an option to translate using lingva

1.Because lingva pulls from Google it's usually very accurate

  1. Not everyone has the time or the knowledge to translate the app's ingredients and such so it would be easier to have an option to translate ingredients using some tool

Fix: Mai Tai recipe

For a single serving it's meant to have 2/3 oz light rum in the shaken mix instead of 1 oz, and 1/3 oz dark rum splashed in the glass after straining.

Action Required: Fix Renovate Configuration

There is an error with this repository's Renovate configuration that needs to be fixed. As a precaution, Renovate will stop PRs until it is resolved.

Error type: Cannot find preset's package (github>whitesource/merge-confidence:beta)

Add German translation

I'd like to contribute to the app and am willing to translate it to German. If that's possible, please tell me how to start

milliliters support

Add mL (milliliters) option for cocktails. It's not at all common to use cL (centilitres) in recipes that use metric units. Besides, virtually all measuring cups use mL

The bottom bar

Are you happy with the new bottom bar? It feels like a debug version of the app, with only a tiny yellow outline around the buttons. Plus, it goes away when you tap somewhere else, so you can't see what page you're on. I'm not sure how difficult it'd be for you, but it might be a good idea to fill the icon of the active button with a color, and completely ditch the outline.

Material You integration

Nice app, but would be great if it where integrated with the Material You theming for Android for a cleaner look.

Ingredients should include ABV

This is the first part of new features from this issue #296

We should add ABV for all ingredients so we then can calculate ABV for all the cocktails.
Ingredients data file should include a property (abv) and be of type number.

Example row:
{ id: '6', translation: 'gin', spiritType: SpiritType.Gin, abv: 37.5 },

Add "close ingredients" functionality

Hello!

I have an idea for a new functionality: adding an option to account for missing ingredients by checking if there are similar alternatives available.

For instance, if a cocktail recipe requires lime juice, but the user only has lemon juice, this feature would still suggest the cocktail as the two ingredients are quite similar.

Of course, this is just a proposal for a "nice to have" feature, from my point of view 😄.

Request: Sorting of "1 Missing Ingredient" list

The list of cocktails under Cocktails -> From Ingredients -> 1 Missing Ingredient could be much more useful if:

  1. cocktails missing the same ingredient were grouped together
  2. these groups were sorted by their size (e.g. a group of 5 cocktails missing gin would be shown above a group of 3 cocktails missing vodka)

This would make it much easier for users to decide which ingredient to buy next and to efficiently explore the recipe space provided by the app.

In that sense it might even be beneficial to show cocktails missing more than one ingredient if there aren't many/enough with just a single missing ingredient. But that's probably stuff for a new issue.

F-Droid inclusion

Hi,

Since this app is MIT licensed, are you considering the fact to add it to F-Droid? There is a strong community behind.

You can find some documentation here.

Otherwise, if you don't want to work on the inclusion of this app in F-Droid by yourself, would you still agree with the inclusion of your app in F-Droid by the maintainer team?

Could you please in the meantime tag your releases (have a look here and here for some help), and attach a signed release apk to it, it would allow people without access to Google Play to download, install and then later update your app 👍

Add translation service

Add a (free) translation service such as Weblate in order to support more languages and more easily maintain current translations. Weblate is free for FOSS by the way.

Favorites

it would be nice to have the favorites displayed either on home as separate row or as separate page in the cocktais tab..
just a suggestion to your really nice and helpful and interesting app 😊

Add possibility to rate drinks

Add possibility to personally/locally rate drinks, e.g. by adding 1-5 stars or placing a box for comments, also for suggested changes about the amount of ingredients used.

Tags

Add tags for cocktails. Examples: Fruity, Non alcoholic, Simple, Strong, IBA

  • Premade Cocktails should include tags.

  • Filter options for tags

  • User should be able to select tags when creating a cocktail

  • User should be able to create their own tag

Feature request: search cocktails by ingredient

Hi! First off, thanks for the great app. It's the perfect way of approaching cocktail mixing for me, especially the "1 Missing Ingredient" list.

I am currently looking at a bottle of Maraschino liqueur and wondering what I could use it in. This feels like a use case Drinkable could cover, but currently it doesn't. Search under All Cocktails doesn't appear to cover ingredients, only recipe titles, and there doesn't appear to be a way to click on an ingredient and see all the cocktails it is used in. Either approach would work for my use case, should it amuse you to implement it. (Sorry, no pull request from me at this time.)

Either way, thank you again for the useful app, and best of luck.

Add notes for cocktails

Add a section for notes. This will allow users to write down small changes they made/ or something else that would be great to have saved along the cocktail.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.