mobify / chai-custom-assertions Goto Github PK

jQuery elements that have been derived from other jQuery elements no longer have their own selector property, which causes the element test to fail.

var $original = $('div');
var $derived = $original.clone();

expect($original).to.be.an.element(); // passes
expect($derived).to.be.an.element(); // fails

Other functions such as .children(), .first(), .filter() have the same issue.

The following assertions do not work correctly:

expect($paymentOptions).to.be.an.element;
expect($paymentOptions).to.be.present;

Using the above syntax instead of the .element(value) syntax does not actually invoke the test. Because Chai assumes that tests pass until they fail, this may lead to tests that pass when they should not.

How to Test

• Use an existing adaptive project with fixtures already set up
• Create a new test that should fail

test('custom assertions', view, fixture, {
    'present fails for a nonexistent element': function($, context) {
        var $fakeElement = $('#fake-element');
        expect($fakeElement).to.be.present;
    },
    'element fails for an object that is not a jQuery or Zepto element': function($, context) {
        var notElement = {};
        expect(notElement).to.be.an.element;
   }
});

• This test will pass, despite the fact that it should fail
• Using the other syntax invokes the tests correctly

test('custom assertions', view, fixture, {
    'present fails for a nonexistent element': function($, context) {
        var $fakeElement = $('#fake-element');
        expect($fakeElement).to.be.present(1);
    },
    'element fails for an object that is not a jQuery or Zepto element': function($, context) {
        var notElement = {};
        expect(notElement).to.be.an.element();
   }
});

We are currently using Chai 1.9.0.

2.x should be compatible with our existing tests and custom assertions. New features include:

• Aliases for include(s) and contain(s) chaijs/chai#328
• New chainable keyword .which chaijs/chai#349
• Exposed chai.util, which is helpful for extending Chai! chaijs/chai#335

Tasks

• Update Chai version in adaptive
• Ensure new version works with custom commands and existing tests