What's wrong

Fieldsets.
Fieldset template not rendering content. Most obvious in the Webforms.

How to fix

Revert to using Barrio's fieldset template and this is fixed.

Why?

We can reduce the amount of CSS with better structured markup. We can make the structure more modular and leverage bootstrap more. We can pull from the parent theme more strategically and use Twig extends and includes so that there is only 1 copy of each portion of markup in our subtheme. For example not pasting the same header into multiple page templates. This reduces differences between pages and opportunities for errors.

Also, we need to keep working on this theme to match mockups.

The plan.

First/most complex thing I tried to address was the navbar (current on live, is broken and collapse doesn't work). This was a learning curve for me because all the different menus from Drupal sitebuilding that can go into the theme.

Also since a main concern was the Curator and Contributor forms, I added theme hooks to allow individual layouts for each.

What is(will be done) new

Will allow Block placing the Drupal way by adding extra regions, 3 Rows, between Breadcrumb and the Content. That way we can shape the Front page in the right way, independent of the content

What extra is required.

Blocks that will be setup here will need to have the extra column classes to follow the desired layout. That is a simple edit task (use FULL HTML)

What is missing?

After this change CSS will need to be readjusted since now there is more nesting, given by the natural block render process (see the featured panorama as an example that now does not extend to the full width of the 8 column width column.

@marlo-longley