Git Product home page Git Product logo

Comments (52)

robles1999 avatar robles1999 commented on May 26, 2024 1

For sure. Is the least I can do.

I am getting to test the .23 release now.

from marzworkbench.

robles1999 avatar robles1999 commented on May 26, 2024 1

I agree. No need to port it back.

Thank you for the fix of the volute. This last version alone is of immense help to us non 3D Designer luthiers. It surely has been a struggle to dive into the new technology but I know it'll be worth it. Again thank you for your work. I look forward to the new version. If you need any help testing the new version please feel free to reach out to me.

from marzworkbench.

robles1999 avatar robles1999 commented on May 26, 2024 1

That looks fantastic!!. Patiently waiting for the complete version.

from marzworkbench.

robles1999 avatar robles1999 commented on May 26, 2024 1

You are killing me. 8-) That is crazy good!!!! 1.5 seconds is amazing. That's some serious code for all the calculations it has to compute. Great job!!

from marzworkbench.

mnesarco avatar mnesarco commented on May 26, 2024 1

Hi @PuzzlingMatt I am having some progress, but there are not deadlines. I do this for fun and love in my spare time. The current dev version is a very different beast compared to the python workbench. This is the parametric double asymmetric neck profile editor:

image

By the moment the trussrod channel is aligned with the spine of the profile because I initially thougt that it was the most logic placement. But some more experienced Luthiers think that the trussrod must be aligned with centerline unconditionally, others prefer to decide case by case. So I am adding different alignment options here.

I am also working on more parallelization optimizations, better surfaces, and a very convenient appication file format. I started this as a very simple freecad addon, but it is becoming something more serious now.

from marzworkbench.

robles1999 avatar robles1999 commented on May 26, 2024 1

Loving it.

from marzworkbench.

PuzzlingMatt avatar PuzzlingMatt commented on May 26, 2024 1

Agreed, looks very nice. I guess it'll be something that we might see for sale at some point? Would save me a bucket load of time if I didnt have to model body contours and things by hand since thats always a bit of a faff! Happy to help out with testing or maintaining a windows build if needed in the future.

from marzworkbench.

mnesarco avatar mnesarco commented on May 26, 2024 1

Thank you @dantahoua , The version I am working on now does not depend on Freecad, I plan to release it as a standalone AppImage. I am using Mint 19.3 right now.

from marzworkbench.

mnesarco avatar mnesarco commented on May 26, 2024 1

Hi @evfool thank you for the offer. I am closer to release a new version, here are some pictures:

screenshot_9

screenshot_5

image

from marzworkbench.

mnesarco avatar mnesarco commented on May 26, 2024 1

Hi @brotherdust I am close but not ready yet to release something:

2021-09-13.13-14-27.mp4

from marzworkbench.

mnesarco avatar mnesarco commented on May 26, 2024 1

Hello @brotherdust ,
The project was seeping for a long time this year, but I have news, I have Gordons Surfaces now thanks to Tigl project.

image

It means that finally I can provide transitions for heel-barrel and barrel-headstock with proper continuity. That was the missing piece for an initial release.

from marzworkbench.

mnesarco avatar mnesarco commented on May 26, 2024

Hi @robles1999
Yes there was a bug (a tolerance problem). Fixed now.
BTW, I am rewriting everything from scratch to support better geometry, specially transitions.

The new version will have much better geometry:
image
image

from marzworkbench.

robles1999 avatar robles1999 commented on May 26, 2024

Great. Thank you.

I think the ability to do the design on Inkscape and imported into FreeCAD to build the 3d was a genius idea!!

Is the correction implemented on the new re-write or is there an update to the current one?

Also, when do you think the new version will be available?

I would like to propose some other functionalities.

  1. Back and top contours
  2. Archtop

Thank you.

from marzworkbench.

robles1999 avatar robles1999 commented on May 26, 2024

By the way the new geometry/transition looks great.

from marzworkbench.

mnesarco avatar mnesarco commented on May 26, 2024

@robles1999

  • The fix is in the current one.
  • I already started the archtop work in the new version.
  • Back and Top contours are very easy to implement. Great idea.
  • The new version will be public in about one month I hope. It is a complete rewrite, and contains double asymmetric neck profiles, BuiltIn neck profile editor, Custom volute geometry (imported from svg), Custom Heel geometry (svg), way better transition geometry, nut part witth equal center and equal gap support, ... And 1000x performance boost.

image

image

image

from marzworkbench.

robles1999 avatar robles1999 commented on May 26, 2024

Wow!!! that's going to be amazing.

I downloaded the 0.21 version just now to give it a try, and I am still getting the same result on the volute when I add the headstock.

Headstock Volute Artifact2

from marzworkbench.

mnesarco avatar mnesarco commented on May 26, 2024

Hi, mm it is fixed in github but not in 0.21. Give some minutes to upload 0.22

from marzworkbench.

mnesarco avatar mnesarco commented on May 26, 2024

It is fixed in release 0.0.23 now.

from marzworkbench.

robles1999 avatar robles1999 commented on May 26, 2024

Ok. Thank you.

By the way I know you are developing and testing in Linux, I have Windows and Mac machines, so I'd be more than happy to help you test the workbench on the 2 systems.

from marzworkbench.

mnesarco avatar mnesarco commented on May 26, 2024

Ok. Thank you.

By the way I know you are developing and testing in Linux, I have Windows and Mac machines, so I'd be more than happy to help you test the workbench on the 2 systems.

Thank you, it sounds great. Testing in windows is a pain for me because I use a very slow Windows virtual machine. And testing in Mac is just impossible to me because I don't have one :D

from marzworkbench.

robles1999 avatar robles1999 commented on May 26, 2024

The issue is gone. There's a small issued with the Profile "D". I don't know if it is that I have to change the parameter when changing the Profiles or is a small code fix. I don't 100% understand all the parameters yet and I am still playing with them to see the effects of each. However, here are some pictures of the different profiles and their settings.

Headstock Volute D v23_1
Headstock Volute D2 v23
Headstock Volute V v23
Headstock Volute Classic v23

from marzworkbench.

robles1999 avatar robles1999 commented on May 26, 2024

The addition of the Constructions lines is great. Another helpful functions would be to be able to Chamfer and Fillet. I was able to do it by copying the body over to the Parts Design workbench to Fillet and do some boolean functions, but it would be nice to have it in your workbench or have it be a Body rather than a Part.

from marzworkbench.

mnesarco avatar mnesarco commented on May 26, 2024

All the code for transitions (heel and headstock) was rewritten in the new version, I will not port that to this version. :(
Also the neck profile algorithm is completely different in new version and will be not ported back.
Filled and Chamfer are standard FreeCAD features, the idea is to use them with the generated solids.

from marzworkbench.

mnesarco avatar mnesarco commented on May 26, 2024

Some progress:
Fully parametric: double asymmetry supported, custom heel shape supported.

image

from marzworkbench.

mnesarco avatar mnesarco commented on May 26, 2024

Advanced custom headstock shape with custom volute, plus double asymmetric neck profile, plus break angle:

image

Everything from a simple SVG contour.

Comming soon...

from marzworkbench.

robles1999 avatar robles1999 commented on May 26, 2024

Mi hrno. eso esta de maravilla. Is this going to be a stand alone app or a FreeCad workbench?

from marzworkbench.

robles1999 avatar robles1999 commented on May 26, 2024

Just food for thought. If it is a stand alone app, an integrated simple g-code generator like Mash Cam would be the icing on the cake.

from marzworkbench.

mnesarco avatar mnesarco commented on May 26, 2024

It is a standalone app now, but with FreeCAD integration. Everything was rewritten in C++. FreeCAD is an excellent CAD software but as all 3D Cad tools it is very complex for the average Luthier. The main goal of this project is to provide something simple to use with domain specific terminology but powerful enough to model parametric guitar designs without beign a CAD expert.

from marzworkbench.

robles1999 avatar robles1999 commented on May 26, 2024

Thats great. You are truly a blessing. I've been having a hard time working with FreeCad. I was using Fusion 360 and got decent at it but don't like the fact that they can stop providing it for free at anytime. In the last 2 months I've been using designspark mechanical and by far is the most user friendly Cad software I've used. It is very powerful and I've been able to create pretty much anything I can think of really fast without any problems. However having your parametric workbench for building guitars is going to make everything so simple and really expand the possibilities.

from marzworkbench.

robles1999 avatar robles1999 commented on May 26, 2024

Here are some samples of what I've been able to build on DesignSpark. These are just shapes I built while learning to use the software, no real guitar dimensions.

Sample 1
Sample 2
Sample 3
Sample 4
Sample 5
Sample 6

from marzworkbench.

mnesarco avatar mnesarco commented on May 26, 2024

I have achieved near perfect surfaces:

image

Neck and Fretboard generated in 1.5 seconds.

  • Asymmetric neck profiles (double asymmetric)
  • Custom asymmetric heel
  • Custom headstock
  • Custom asymmetric volute
  • Custom truss-rod alignment
  • Custom headstock angle, neck angle,, zero-fret, scales, radiuses, etc...

from marzworkbench.

mnesarco avatar mnesarco commented on May 26, 2024

You are killing me. 8-) That is crazy good!!!! 1.5 seconds is amazing. That's some serious code for all the calculations it has to compute. Great job!!

Calculations are the fast part. OCCT boolean operations are the slowest, so I have managed to avoid them as much as possible and I use a highly parallelized code.

from marzworkbench.

PuzzlingMatt avatar PuzzlingMatt commented on May 26, 2024

Wow, just wanted to that from reading this thread it looks like this are looking really really good. Look to be able to have a go with the new version soon though I'm having a decent amount of success with the current version. Suspect you might have some more users headed your since it looks like people have started to drop F360 with the recent licence changes.

from marzworkbench.

mnesarco avatar mnesarco commented on May 26, 2024

@PuzzlingMatt yes I knew about the F360 exodus, FreeCAD community is like a refugee land these days. I am working hard to release something as soon as possible. But this is not an easy task. Specially now that I rewrote everything from scratch in C++. But the results are worth the pain.

from marzworkbench.

PuzzlingMatt avatar PuzzlingMatt commented on May 26, 2024

@mnesarco anything I can do to help? I can c++ but dont have a lot of experience with freecad - some of its quirks are taking a bit of getting used to! I've actually had some good results with the current version of the workbench (it works fine on windows btw) - just experimenting with the freecad cam stuff now.

from marzworkbench.

dantahoua avatar dantahoua commented on May 26, 2024

A bit out of line, but as soon as I manage to compile Freecad 0.19 on my Calculate Linux, count me in the testing guys for your Guitar Design Workbench! It's awesome!!! What Linux distrib. do you use?

from marzworkbench.

dantahoua avatar dantahoua commented on May 26, 2024

That sound interesting!!! :)

from marzworkbench.

robles1999 avatar robles1999 commented on May 26, 2024

Hello Frank and happy new year!

I was wondering how the project is going. I finally got a CNC and was hoping to design and acoustic guitar. I wanted to check with you before I started designing everything myself which it will take a lot longer than with your software.

from marzworkbench.

mnesarco avatar mnesarco commented on May 26, 2024

Hi @robles1999 ,
The project was paused for some months but I am actively working on it again. I hope I will release an update soon, but I cannot guarantee any specific release date.

from marzworkbench.

robles1999 avatar robles1999 commented on May 26, 2024

Hi Frank. Thanks for the update, I was just wondering because I hadn't heard anything from you in a while.

from marzworkbench.

brotherdust avatar brotherdust commented on May 26, 2024

It is a standalone app now, but with FreeCAD integration. Everything was rewritten in C++. FreeCAD is an excellent CAD software but as all 3D Cad tools it is very complex for the average Luthier. The main goal of this project is to provide something simple to use with domain specific terminology but powerful enough to model parametric guitar designs without beign a CAD expert.

@mnesarco , you mentioned that it's now written in C++, but didn't mention a link! Please advise where one can get the rewrite! Thank you!

from marzworkbench.

mnesarco avatar mnesarco commented on May 26, 2024

@brotherdust , It is not public yet.

from marzworkbench.

evfool avatar evfool commented on May 26, 2024

@mnesarco if you need help developing and would like to make the current state public, I would be interested in also coding, and also using it. Amazing what you have achieved with this project so far.

from marzworkbench.

brotherdust avatar brotherdust commented on May 26, 2024

Hi @evfool thank you for the offer. I am closer to release a new version, here are some pictures:

screenshot_9

screenshot_5

image

Very very cool! I'm so excited for a release. Do you need help with docs? I'm good at that.

from marzworkbench.

brotherdust avatar brotherdust commented on May 26, 2024

@mnesarco , just wanted to check back in with you on your C++ re-write. Was using Guitar Workbench today and ran into some limitations and it seems like your rewrite would fix them. Do you need a tester? I'd like to help somehow, if possible.
Thanks!

from marzworkbench.

brotherdust avatar brotherdust commented on May 26, 2024

@mnesarco Will it support headless, multiscale builds? 😁

I've been trying to build a composable guitar in CADQuery. It's hard.

from marzworkbench.

mnesarco avatar mnesarco commented on May 26, 2024

Yes it already support headless and multiscale.

from marzworkbench.

brotherdust avatar brotherdust commented on May 26, 2024

Yes it already support headless and multiscale.

Oh man! That's incredibly exciting! I'm just a hobbyist but I would seriously pay at least $100 for this software. You got a place I can donate? 😉

from marzworkbench.

mnesarco avatar mnesarco commented on May 26, 2024

I am not receiving donations yet because there is no public product yet. Thank you for your offer. Stay tuned, I want to release the first version this year.

from marzworkbench.

brotherdust avatar brotherdust commented on May 26, 2024

I am not receiving donations yet because there is no public product yet. Thank you for your offer. Stay tuned, I want to release the first version this year.

Just checking in! It's that time of year. 😁

from marzworkbench.

brotherdust avatar brotherdust commented on May 26, 2024

Hello @brotherdust ,

The project was seeping for a long time this year, but I have news, I have Gordons Surfaces now thanks to Tigl project.

image

It means that finally I can provide transitions for heel-barrel and barrel-headstock with proper continuity. That was the missing piece for an initial release.

So excited! When?!

from marzworkbench.

mnesarco avatar mnesarco commented on May 26, 2024

I can't compromise a date. Sorry.

from marzworkbench.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.