Git Product home page Git Product logo

made-mistakes-jekyll's People

Contributors

dependabot[bot] avatar gbbns avatar mmistakes avatar nhoizey avatar parvjain avatar snyk-bot avatar staticman-net[bot] avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

made-mistakes-jekyll's Issues

Jekyll 3 regeneration slowdown

Investigate increasing regeneration times with each successive change on Windows. Possible fix is to add gem wdm to Gemfile.

bundle install fail on Mac OSX El Capitan

Very beautiful jekyll-based blog, however, I have no luck to run it on my Mac.

When $ bundle install

pkg-config could not be used to find libiconv
Please install either pkg-config or the pkg-config gem per

gem install pkg-config -v "~> 1.1.7"

checking for iconv using pkg-config libiconv... no

libiconv is missing. Please locate mkmf.log to investigate how it is failing.

*** extconf.rb failed ***
Could not create Makefile due to some reason, probably lack of necessary
libraries and/or headers. Check the mkmf.log file for more details. You may
need configuration options.

Some SVG icons cut off

Inline SVG icons (possible those who's canvas isn't perfectly square) cut off. Related to width: 1em and height: 1em?

image

Content cleanup

  • Find/replace all image paths used in YAML Front Matter and prepend with full path (eg. /assets/images/filename.jpg
  • Update style-guide
  • Add waypoint links (breadcrumbs lite) to FAQs and any other collection documents that function similar to the "yellow" underlined category page links
  • Update/add feature images were necessary

bigfoot.js popup overflowing

Hi @mmistakes
I just notices a bug with bigfoot while implimenting on my website, and is present on your website too.

Bug - On mobile device (my mobile screen res - 720x1280), the popup overflow from the screen if shown on extreme left on the screen.

I thought of putting this issue on bigfoot.js repo, nut the project is stale with many issues pending. However I found this opened issue which might be the same -lemonmade/bigfoot#46

I tried using positionContent: "true" as mentioned on http://bigfootjs.com but no success.

Hoping that you can catch something...

Explanation -

On your website (about page)- -
I slowly resized screen in chrome (desktop) to emulate the bug.

image

On my website -
this page - happens on mobile device only

screenshot_20181001-073003

Improve fullcss cookie

Current experience

  1. User visits the site for the first time. Inlined critical CSS is loaded, followed by an asyn request for the full stylesheet.
  2. fullcss cookie is set with a value of true.
  3. On repeat visits cached full stylesheet(s) are loaded. Inconsistencies appears if CSS has been altered.

Need a way to cache bust the cookie value. Perhaps leverage the values set in the asset manifest to evaluate against instead of true.

Optimize build process

TL/DR plan of attack: relegate Jekyll to Markdown parsing and building HTML and leave assets (CSS, JS, images, and fonts) to Gulp (or equivalent task runner).

  • Replace jekyll-picture-tag with Gulp task.
  • Replace jekyll-assets with Gulp tasks.
  • Automate critical path CSS generation.
  • Replace layout: compress with Gulp minify task.
  • Replace Rake deploy tasks with Gulp.

The time to jekyll build and deploy the site has gotten out of hand the last couple of years. Test disabling various build tasks and plugins to determine offenders and investigate removing the dependency or developing a lighter weight alternative.

Made Mistakes Jekyll stats as of 8/23/2016:

Windows Test System:

  • Lenovo ThinkStation E30
  • Processor 3.30 GHz Intel Xeon E31245
  • Memory 16 GB
  • Intel SSDSA2BW160G3L 137GB
  • Windows 7 Professional Service Pack 1
  • ruby 2.2.4p230 [x64-mingw32]

Mac Test System:

  • iMac 21.5-inch, Late 2013
  • Processor 2.7 GHz Intel Core i5
  • Memory 16 GB 1600 MHz DDR3
  • 1.12 TB Fusion Drive
  • OS X El Capitan 10.11.6
    -- ruby 2.1.0p0 (2013-12-25 revision 44422) [x86_64-darwin12.0]

Initial build: bundle exec jekyll clean. Verify _site, .asset-cache, and any other .tmp folders and files have been removed.

To test build tasks, disable or remove from source and compute average time of 3 builds using bundle exec jekyll --profile.

task task time (Windows) task time (Mac)
Generate responsively sized page.image.feature photos 1288.289s 1429.255s
Minify HTML with layout: compress 39.348s 11.18s
Read /images/ and copy to _site/ 32.385s 23.629s
Build tag pages with jekyll-archives 17.398s 9.994s
Build tag index page with sort_tag filter 2.62s 0.586s
List related posts with jekyll-tagging-related_posts, jekyll/tagging, and LSI: true 38.356s 17.867s
List related posts with vanilla related_posts 1.649s 4.899s
Preprocess, concatenate, minify, and cache bust SCSS and JS with jekyll-assets 78.751s 25.031s
Display masthead and overlay menu from _data 9.656s 7.815s
List post comments from _data 7.103s 2.216s
Display colophon from _data 0.2s 0.486s
List post taxonomy metadata 3.479s 1.182s
List post breadcrumb links 2.834s 1.029s
List featured posts 0.195s 0.439s
Build style guide collection 1.161s 0.314s
List post social sharing links 5.092s 0.973s

Worst case offenders appear to be resizing large amounts of images, copying images from source to destination, and building the site.

Decoupling asset generation tasks from main Jekyll build so they don't trigger a rebuild each time they are updated should help with development build times. Browsersync can also come to the rescue injecting updated CSS/JS to circumvent the entire Jekyll build process.

Jekyll build times comparison:

build type Jekyll + plugins Jekyll Gulpified
clean build (Mac OS) 26.01 min 14 min
clean build (Windows) 26.31 min 17 min
build with images already resized (Mac OS) 2.21 min 1.58 min
build with images already resized (Win) 5.23 min 4.17 min

Build `gallery` helper (or plugin)

Build a helper that leverages {% include %} variables to build a gallery container that pulls from image data from YAML Front Matter. This will help remove the need to write HTML in .md which is hard to maintain and "junks" up the readability of Markdown only content.

Something similar to the helper built for Minimal Mistakes:

{% include base_path %}

{% if include.id %}
  {% assign gallery = page.[include.id] %}
{% else %}
  {% assign gallery = page.gallery %}
{% endif %}

{% if gallery.size == 2 %}
  {% assign gallery_layout = 'half' %}
{% elsif gallery.size >= 3 %}
  {% assign gallery_layout = 'third' %}
{% else %}
  {% assign gallery_layout = '' %}
{% endif %}

<figure class="{{ gallery_layout }} {{ include.class }}">
  {% for img in gallery %}
    {% if img.url %}
      <a href=
        {% if img.url contains "://" %}
          "{{ img.url }}"
        {% else %}
          "{{ img.url | prepend: "/images/" | prepend: base_path }}"
        {% endif %}
        {% if img.title %}title="{{ img.title }}"{% endif %}
      >
        <img src=
          {% if img.image_path contains "://" %}
            "{{ img.image_path }}"
          {% else %}
            "{{ img.image_path | prepend: "/images/" | prepend: base_path }}"
          {% endif %}
          alt="{% if img.alt %}{{ img.alt }}{% endif %}">
      </a>
    {% else %}
      <img src=
        {% if img.image_path contains "://" %}
          "{{ img.image_path }}"
        {% else %}
          "{{ img.image_path | prepend: "/images/" | prepend: base_path }}"
        {% endif %}
        alt="{% if img.alt %}{{ img.alt }}{% endif %}">
    {% endif %}
  {% endfor %}
  {% if include.caption %}
    <figcaption>{{ include.caption | markdownify | remove: "<p>" | remove: "</p>" }}</figcaption>
  {% endif %}
</figure>

Text Callouts for Basically Basic Theme?

Looking through this repo trying to figure out if I can glean how you did the text callouts danger, warning etc so I can add them to Basically Basic. Is there already a way to do this in that theme that I am missing and if not could you advise how to accomplish this or add it to that theme?

Improve Site build times with cached includes

๐Ÿ‘‹ Michael

Did you know that you can cache rendered outputs from stateless includes and improve your build times with a plugin..?
The plugin is called jekyll-include-cache and is whitelisted for use at GHP
(just not bundled by default, since its dangerous for novices)

The plugin can be used to cache any "include" that does not change its output from page-to-page.
Such includes can simply be plain HTML without any Liquid or an include that only references the global constant {{ site }} e.g., src/_includes/footer.html

I did not submit a PR because I thought I'd gather your feedback first and allow you to implement it first-hand so that you know where it can be used and where it should not be used..

Results from --profile on my system show that you may be able to shave of ~15 seconds but I may be wrong..

Fix code block styling in "Style Guide"

Spacing seems off. Possibly related to Jekyll 3 and switch to Rouge for syntax highlighting?

Jekyll 3 + Rouge

<div class="component__code">
  <figure class="highlight">
    <pre>
      <code class="language-html" data-lang="html"> 
         ...  

Jekyll 2.5 + Pygments

<div class="component__code"> 
  <div class="highlight">
    <pre>
      <code class="language-html" data-lang="html">
        ...

screen shot 2015-12-14 at 11 15 12 pm

Build `figure` helper (or plugin)

Build a helper that leverages {% include %} variables to build <figure> elements containing images and a caption. This will help remove the need to write HTML in .md which is hard to maintain and "junks" up the readability of Markdown only content.

Improve print stylesheet

  • Remove masthead
  • Remove footer
  • Improve layout of gallery images so they don't stretch
  • Add QR code of current page URL to view on mobile devices

Whitespace issue

There is some white space getting added somewhere between send square cash and send bitcoins buttons on the support page.

mixin not found

Hi,
I am not able to find this function breakpoint in any of the mixin file.
The jekyll is throwing error -
Undefined mixin 'breakpoint
Am I doing something wrong?

Why you are using wufoo.js?

Hi @mmistakes ,

Kindly help with a question related to your website

Just like your contact form , I have managed to make wufoo working, without using <script>{% include_cached wufoo.js %}</script>

Doubt 1 - I was wondering what is the use of including above script? Nowhere on the original site of wufoo they have mentioned about this JS code

Doubt 2 - Are you using hidden text box to prevent spambots from spamming the form?
i.e. this one - <textarea name="comment" id="comment" rows="1" cols="1"></textarea>

Center "reply" lines

reply-lines

.comment.child:before {
    position: absolute;
    top: 4em;
+   left: 1.5em;
    bottom: 0;
    content: '';
    width: .5em;
    background-color: #e3e3e3;
+   bottom: -2em;
}

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.