Panic if AnyUserData.get_user_value fails about rlua HOT 4 CLOSED

Oh, ugh, that's a very easy fix, it's supposed to be using "stack_err_guard" not "stack_guard". That's what I get for incomplete tests.

Edit: Ugh, so embarassing, thank you for this bug report though.

from rlua.

Okay, that should be fixed in 7231e95. Like I said the fix is easy, but the implication is troubling, because I have now at least messed up stack_guard vs stack_err_guard in two places and not caught it.

I checked every other place in the code that uses stack_guard for unexpectedly returning Err and didn't see anything, so hopefully that's it.

Maybe I should just get rid of stack_guard? Maybe I should just write tests where a convertible type fails and call every single method with that type?

from rlua.

What happened was I had originally written get_user_value / set_user_value to just accept / return Value, but then realized that's stupid and changed them to accept ToLua / FromLua instead, but forgot to change the stack_guard to a stack_err_guard.

from rlua.

Thanks for the fix and really no need to explain yourself :-)

from rlua.