Git Product home page Git Product logo

Comments (6)

kyren avatar kyren commented on July 19, 2024 2

Ugh, thanks for this, I'm sure I've implemented the xpcall wrapper incorrectly. I'll try and fix this ASAP.

from rlua.

Timidger avatar Timidger commented on July 19, 2024

Ok after digging around the source and seeing that you're doing a protected call always in order to avoid UB from longjmp's...

I can reproduce a similar result in the reference Lua interpreter by doing what rlua is actually doing:

pcall(function(foo) return xpcall(function(foo) return foo end, print, foo) end, "foo")

It returns two booleans instead of two functions, but the result is the same: the return value is one value over than it should be.

from rlua.

kyren avatar kyren commented on July 19, 2024

Sorry bout that, this should be fixed in 0.9.5. I think that's at least the second time I've screwed up the pcall / xpcall wrappers, hopefully it works now.

from rlua.

Timidger avatar Timidger commented on July 19, 2024

Awesome, thanks for fixing it so fast

from rlua.

kyren avatar kyren commented on July 19, 2024

Np, thanks for the report! 👍

from rlua.

Timidger avatar Timidger commented on July 19, 2024

Excellent, just tested and 0.9.5 fixed my issue :)

from rlua.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.