mlga / schematics-proto3 Goto Github PK

There should be test cases that check if "renamed" field is reflected properly in validation errors.

Example

class Something(Model):
    custom_name = types.StringType(metadata=dict(protobuf_field='value'))

    class Options:
        _protobuf_class = pb.Something

Upon validation error, custom_name should be used to denote an error:

{'custom_name': ['Please speak up!']}

This must be true for nested messages as well.

Please add the timestamp's wrapper as you wanted 😄

Currently, mostly "happy" paths are tested in unit tests. There should be test cases for misconfiguration, wrong usage and others.
This will require addressing many TODOs in code concerning raising proper exception and handling wrong states gracefully.

To Do

• Check (and test) misconfiguration
  • Model field does not present in assigned protobuf message
  • Model field declared with type different from protobuf message's field type
  • required option used in oneof inner field
  • required option used in repeated inner field
  • required option used in primitive field
• Check (and test) misuse
  • Model.load_protobuf used for wrong protobuf message (of wrong type / not set in Options)

Currently, .from_protobuf method is a spaghetti of nested if/elif/else statements and repeated code. It's complicated and hard to reason about. It it good enough for fast prototyping but unacceptable for production-ready code.

Solution

Implement .from_protobuf in every type so protobuf handling details may be implemented there.

Problem: Wrapped field types need an information about parent message to be able to correctly return Unset.