If emoji is present in News Article Title, then python script crashes due to a ZeroDivisionError about mlb-led-scoreboard HOT 12 CLOSED

The code that crashed is only in the emulator, not the actual board (I wrote it, I’m pretty sure) so I think it would need to be a different error

from mlb-led-scoreboard.

Do you know which team’s news feed lead to the headline appearing?

from mlb-led-scoreboard.

I'm finding a play button ▶️ emoji starting to appear for "game story" articles. Just checked the astros feed

from mlb-led-scoreboard.

I'm also seeing the play buttons on the cubs feed though. I'm testing the feed on my board now and haven't experienced a crash yet

from mlb-led-scoreboard.

Not seeing a crash on board. Just saw the Game Story article and it ended with a play icon and then a ? symbol (like it didn't understand the character)

from mlb-led-scoreboard.

from mlb-led-scoreboard.

@ty-porter how do I find the emulator version?

from mlb-led-scoreboard.

I am pretty new to programming, so I am not sure if this is the best way to fix the issue, but I did resolve it by removing emojis from headlines.

I did so by adding the following to the scrollingtext.py in the renderers folder:

from cleantext import clean

And then at line 28:
clean_text = clean(text,normalize_whitespace=False, no_emoji=True, lower=False)

from mlb-led-scoreboard.

@WardBrian it was the Braves headlines that were causing the issue. It was the same thing that @swemoney described with the Astro's: it had the play emoji ("▶️ ") present in several article headlines

from mlb-led-scoreboard.

@ty-porter how do I find the emulator version?

python3 -m pip show RGBMatrixEmulator

from mlb-led-scoreboard.

I can reproduce this in emulator v0.8.3

Steps to trigger the bug:

1. Character not in font
2. Missing character is the first character in the string
3. Text origin is < 0 (off matrix to the left)

For this specific trigger that would mean the string needs an emoji as the first character of a string that's large enough to scroll. The error will happen when the scrolling goes offscreen

I will fix this upstream in RGBME, however the fix there will be to gracefully handle 0 width characters. Missing characters will still show a (?) icon. If that's something we want to fix as well, we would need work in this project.

from mlb-led-scoreboard.

Resolved in #465.

from mlb-led-scoreboard.