mlazana / seip Goto Github PK

There is a "rogue" bin directory in your repository. Please remove it.

1. Naming inconsistencies between your Class diagram and your code
2. The JavaCodeAnalyzer does not own a Utilities instance and thus, the diamond is not correct. A simple dependency is required instead
3. If you want to use the "Factory" word in your factory class then use it as a suffix and not a prefix. Like AnalyzerFactory.
4. The Factory should also "know" the implementations of the Analyzer interface.

https://github.com/mlazana/dmst-Java-course-assignments/blob/b165f6da09b473353909b2cb714e39f63430356e/gradeshistogram/src/main/java/gradeshistogram/HistogramGenerator.java#L12

Please add:

1. an one-line description for the class and
2. your name as an @author

1. Please replace the names in both POMs with more appropriate.
   Parent POM should represent the SEiP level concept while the module should be assignment oriented.

https://github.com/mlazana/dmst-Java-course-assignments/blob/1b8742d2daa1f96ca94f1bae53a7c501d3519b10/Java_code_analyzer/src/main/java/fileUtilities/Utilities.java#L23

For comments to be effective JavaDoc they should start with /** and not a single /*.
(In eclipse they should have blue color and not green)

https://github.com/mlazana/dmst-Java-course-assignments/blob/1b8742d2daa1f96ca94f1bae53a7c501d3519b10/Java_code_analyzer/src/main/java/javaCodeAnalyzer/RegexAnalyzer.java#L54

1. The order of the header metrics does not correspond to the actual measurements
2. Please remove the necessary terminal prints while executing the regex analysis.

https://github.com/mlazana/dmst-Java-course-assignments/blob/3e3e5907e4c222344a44d841dbc6ca7989679dbd/unittesting/src/test/java/operations/ArrayOperationsTest.java#L51

You can avoid duplicating the following lines in all tests

// Mock the FileIO dependency
FileIO fileio = mock(FileIO.class);
// Mock the IntegerOperations dependency
IntegerOperations io = mock(IntegerOperations.class);

ArrayOperations ao = new ArrayOperations(fileio, io);

You can declare and initialize them in the class and use them in all your methods.

https://github.com/mlazana/dmst-Java-course-assignments/blob/3e3e5907e4c222344a44d841dbc6ca7989679dbd/unittesting/src/test/java/operations/IntegerOperationsTest_PowerOfTwo_Parameterized.java#L32

If you check the code coverage report you'll notice that the cases of 0 and 1 are not tested.

1. Please add a more detailed description about building the project like mvn package etc.
2. How to run the application
3. Also add the tools that you used to create this project like:
   Maven - version and Java - version etc

https://github.com/mlazana/dmst-Java-course-assignments/blob/1b8742d2daa1f96ca94f1bae53a7c501d3519b10/Java_code_analyzer/pom.xml#L1

These are some issues related to your module's POM:

1. Naming inconsistency with other modules. You use "_" while other modules have spaces or CamelCase pattern
2. Inclusion of unnecessary and unused dependency net.imagej
3. Creation of a fat-jar while no dependency has to be packed in the jar