Add !default flag to variables about docssa HOT 5 CLOSED

Thanks for raising the point, but why would you want to do so ?
Considering _variables.scss holds all the project global variables, I don't see where a previous value would come from, or why we would want to give it priority.
It seems to me it would fit better in a component than on the default declaration.
Can you explain the reasoning behind your assertion ?

from docssa.

Because someone could decide to override those variables.

from docssa.

...and nothing would stop them, as long as they do so in a file loaded after _variables.scss, which is supposed to always be the case in DoCSSa.

Afaik, !default is only useful if there is a previous definition you don't wan't to override, not to allow further overrides of a definition (which is the case by default, except if you use !default on them).
So I am missing the point you're trying to make here. Would you care to explain ?

from docssa.

Adding !default flag to all variables allows one to do something like this:

@import "conf";
@import "vendors/docssa";

Where _conf.scss would contain variables for the entire project, including configuration variables from DoCSSa that would need to be overwritten.

Configuration should always come first in a project in my opinion; even before vendors.

Also, I don't see any reason not to add this flag.

from docssa.

DoCSSa is a CSS architecture, not a components library à la Bootstrap.
You can bend it as you like, so it's up to you if you want to add !default to its configuration variables when you use it, but something like "vendors/docssa" does not really make sense.
I'm closing this issue, maybe we'll reopen it if we reorganize how the theming are handled.

from docssa.