mkoohafkan / cder Goto Github PK

https://info.water.ca.gov/misc/sql_dates.html

It is not entirely clear how CDEC handles timezones. This needs to be investigated and corrected if needed.

And investigate asynchronous requests

The vignette should point out that not specifying a sensor number and/or duration code can yield unexpected results. The default sensor selected by the web service can vary from station to station, and sometimes empty results are returned if no sensor number or duration code is specified.

The duration codes appear to be limited to "Event", "Hourly", "Daily", and "Monthly" (based on the radio buttons available in the station search page. This should be noted in the documentation of cdec_query() and cdec_query_group() as well as in the vignette.

the package is not showing up for searches of "CDEC R". Maybe adding the term "CDEC" to the title will improve search results.

The web services page now states

Dates, times, and output will always be Pacific Standard Time.

Which is different from the documentation that led to the decision for #3. Need to verify whether the timezone should be "GMT+8" or "US/Pacific".

add a helper function to open the sensor list page at http://cdec.water.ca.gov/reportapp/javareports?name=SensList

Very useful package. First issue encountered today: cdec_query() gave me a warning about a parsing issue:

> sgn <- cdec_query('SGN', 20, start.date="1990-10-01", end.date = "2022-09-30")
Warning message:
One or more parsing issues, see `problems()` for details 

I had some trouble following up on the warning, too:

> problems()
Error in problems() : could not find function "problems"

Loading readr prior to calling cdec_query, allowed me to see the "problem":

> problems()
# A tibble: 2 × 5
    row   col expected actual file                                                         
  <int> <int> <chr>    <chr>  <chr>                                                        
1  6237     7 a double BRT    C:/Users/lelan/AppData/Local/Temp/RtmpgFxiLf/file50d44d0b4d40
2 31687     7 a double BRT    C:/Users/lelan/AppData/Local/Temp/RtmpgFxiLf/file50d44d0b4d40

However, that doesn't help me know what data I'm missing

1. Perhaps the SGN gauge example can help you improve the parser
2. Might need some sort of handler for when readr issues a warning

Thanks!

add function that opens data flag list page at http://cdec.water.ca.gov/reportapp/javareports?name=FlagList

cder timezone is incorrectly specified as Etc/GMT-8. It should be Etc/GMT+8.