mklauber / puppet-splunk Goto Github PK

According to the splunk inputs.conf.spec all input types except file system change monitor share the attributes:

• host
• index
• source
• sourcetype
• queue

We should refactor the inputs Defined resources to utilize shared code for these attributes.

If splunk::forwarder is going to manage the installation of the splunkforwarder package, it should take a version field.

the [tcpout] stanza of outputs.conf has an attribute defaultGroup, which takes a comma separated list of group names. Add support for specifying this field as an array as well as a string.

According to splunk's output.conf.spec, specifying sslVerifyServerCert requires that sslCommonNameToCheck and sslAltNameToCheck be set. We should as part of the resource, validate this, and fail if not properly configured.

When attempting to use in an upgraded environment:
Error: Could not retrieve catalog from remote server: Error 400 on SERVER: Evaluation Error: Error while evaluating a Resource Statement, Evaluation Error: Error while evaluating a Type-Name, undefined method `include?' for nil:NilClass at /etc/puppetlabs/code/environments/production/modules/splunk/manifests/init.pp:10:16

mod 'mklauber/splunk', :latest is how i'm including in Puppetfile

Right now, for safe handling of splunk config files, the recommended practice is to specify the string "false" instead of the boolean false. This should be corrected.

The splunk::input::tcp resource type has a field acceptFrom that takes a list of network_acls, separated by comma's or spaces. In addition to taking a string value, acceptFrom should take an array of strings, concatenating them together in order.

There are some escaped characters etc in the version definition. This module works fine when installed using the tarball/zip but when using something like r10k to download it, you get an error about the version number.

I believe all that is required is to just define the version (line 10) without the extra characters.

the server attribute in splunk::output::tcpGroup takes a comma separated list of servers based on the outputs.conf.spec. Specifying these in puppet should accept a data structure. The structure is TBD.

the splunktcp Defined Resource Type accepts parameters, so of which only apply to the Global Stanza or only to the Per Server stanza. Should do some separation, to validate provide validation of these independently.