Cannot Run Code in Loop about poissonrecon HOT 5 OPEN

This problem was addressed (with a few possible solutions) at issue #22.

from poissonrecon.

Apologies, did not see that when searching the issues.

For the sake of completeness:
Replacing the set() method in Allocator.h with the following allows for the code to be run more than once:

void set( int blockSize )
{
    if (this->blockSize != blockSize)
    {
        reset();
        this->blockSize = blockSize;
        index = -1;
        remains = 0;
    }
}

Is there any reason this has not been added to the code outright?

from poissonrecon.

While this could work, I am hesitant to incorporate the fix within the code because it doesn't reallocate the memory. (Nor would it give correct behavior if the second pass used a different memory block size.)

from poissonrecon.

So is moving OctNode< TreeNodeData >::SetAllocator(MEMORY_ALLOCATOR_BLOCK_SIZE); above Octree< Real > tree; a more viable solution since it does reallocate the memory?

from poissonrecon.

Just tested it (moving SetAllocator()). This solution works for me as well, and is indeed better than my previous suggestion.

But I think a more explicit protection should be incorporated in the code (in addition to the above).

Maybe at Octree.inl add a check to see if memory was already allocated:

template< class NodeData >
void OctNode< NodeData >::SetAllocator(int blockSize)
{
	if( (blockSize>0) && (false==MemoryAlreadyAllocated))
	{
		UseAlloc=1;
		MemoryAlreadyAllocated = true;
		NodeAllocator.set(blockSize);
	}
	else{UseAlloc=0;}
}

I guess UseAlloc could've been used for this, but I think adding a new variable for this is cleaner. This is what I currently plan to do in my code.

from poissonrecon.