mjmammoth / musicalchair Goto Github PK

Tokens should be auto-rotated, not even stored as gcs secrets as they are currently.

May be dependent on OAuth stuff.

https://api.slack.com/authentication/rotation

Create a daily question playlist

• The first response with music from the user for that day will be added
• Limited to same day answers only

Figure out where the current limitations are in speed.
Especially when opt-in/out buttons are clicked.

Pull media artist, name, genres.

Will have to cater for (plan a way forward for)

• Individual song links

• Full album links

• Playlist links

• Artist/channel links
  As both Spotify and Youtube support this functionality, even if we only want individual songs, the rest need to be filtered out.

• Get the 'other' platform's URL for the same song.

Store data in the Firestore song collection, each posted link being a media item.

Might warrant the collection being called a 'media' collection as we could add a link_type to it too. (track/album/playlist/artist)

Possible structure, expansion of what's already in src/features/playlist_handler.py:

media_data = {
        "link_type": "track",
        "original_source": "youtube" if "youtube" in url else "spotify",
        "youtube_url": url if "youtube" in url else "",
        "spotify_url": url if "spotify" in url else "",
        "metadata": {
            "genre": [],
            "artist": "",
            "song_name": "",
            "album": ""
        },
        "posts": [
            {
                "date": event.get('ts', ''),
                "user_id": event.get('user', '')
            }
        ]
    }

A meaningful home page when the user visits the app.

Messages like:

• You are currently in the rotation pool and are 7% likely to be chosen next
• You are not currently in the rotation pool, you can always opt-back in.

Functionality required:

• opt-in/opt-out
  Just add to permanent exclusions if opted out, if user is not in exclusions, they are in the pool.

Create different playlists using the metadata saved with the media - dependent on #18

• Genre playlists
• Everything playlist
• All playlists linked by users

Could be future conceptual playlists:

• Friday playlists

• Seasonal playlists

• Geography playlists

• Convert platform playlists to other

• Playlists should be created in both Spotify and Youtube.

• Interaction with the bot should be possible to get the playlists, probably a slash command.

It is currently possible for users to click opt-in or opt-out multiple times before the ack response comes back, and for each time clicked - the user gets added/excluded an extra time.

To enable app admins to set their own scheduled time for the message, we need to be able to dynamically set the cron schedule.

Could continue to use cloud scheduler.. will need to figure how the post can be multi-tenanted

When a user joins a channel where MusicalChair daily question is active, the should be DM'd with the option to do whatever the opposite of the default setting is.

Opt-in or opt-out

This issue lists Renovate updates and detected dependencies. Read the Dependency Dashboard docs to learn more.

Rate-Limited

These updates are currently rate-limited. Click on a checkbox below to force their creation now.

• chore(deps): update dependency python-multipart to v0.0.9

Open

These updates have all been created already. Click a checkbox below to force a retry/rebase of any.

• chore(deps): update dependency jinja2 to v3.1.3
• chore(deps): update dependency aiohttp to v3.9.5
• chore(deps): update dependency fastapi to v0.110.2
• chore(deps): update dependency google-api-python-client to v2.126.0
• chore(deps): update dependency google-cloud-firestore to v2.16.0
• chore(deps): update dependency google-cloud-run to v0.10.5
• chore(deps): update dependency google-cloud-storage to v2.16.0
• chore(deps): update dependency slack-bolt to v1.18.1
• chore(deps): update dependency uvicorn to v0.29.0
• chore(deps): update python docker tag to v3.12
• Click on this checkbox to rebase all open PRs at once

Detected dependencies

• Check this box to trigger a request for Renovate to run again on this repository

Endpoints that aren't authenticated by Slack's signing secret methodology need to be authenticated by OAuth.

These endpoints (/ask-for-song, /backfill--playlists) are currently available publicly and could be abused with the lack of authentication currently on them.

Should figure out what the interaction with Slack's OAuth is like as well as that is required to distribute the app eventually.

• passive-aggressively scold the user
• DM to ask if they want to opt-out

In conjunction with #26, when a legitimate new user joins a channel, show them the status of if they are in the question pool or not and give them the option to opt-in/out

Currently, the random member from the channel chosen can be another slack bot which is undesirable.

When MusicalChair is added to a channel, it should scan for bot users using the users_info method of the slack_bolt sdk and add those bot users to the permanent exclusions state. This would also require for new members added to the channel to be acted upon, checking if it is a bot or not.

This should help achieve the desired outcome:

non_bot_members = [member for member in members if not client.users_info(user=member)["user"]["is_bot"]]

Need a way to configure which channels are included

• CHANNEL_ID should not be an environment variable

• firestore state document should hold which channels have what functionality

• Scheduled questions days and time of day should be configurable, will need to revisit the cron functionality to see how it can be made dynamic

• Handle timezone as well

• #25

• Daily question channel(s)

• Music scan channel(s), enabling auto reaction to music posts

• Daily question missed questions

  • enabled/disabled
  • answer timeframe
  • reminders