mjfsux / zwn-sc7-enerwave-7-button-scene-controller Goto Github PK

First, thanks for creating this. It has made my home automation a million times more convenient. I can't code but I have a background in software testing and found a bug that I've been able to repeat 3 out of 3 times. It is not necessarily on the critical path so it may be something that is easier to put in the read me than fix but either way, I figure I'll report it and you can do what you want with it. It isn't much, but it's the only way I've found to contribute to this project. I hope it helps :)

Steps to Reproduce:

1. Add device handler and add device in smartthings hub following instructions found here:
   https://community.smartthings.com/t/zwn-sc7-enerwave-7-button-scene-controller/2969/4
2. Add this project's scene controller app to smartthings via self publishing.
3. Create a routine and back out of it so that it leaves a null phrase.
   3a. In the smartthings app (tested on android) tap routines.
   3b. Tap +
   3c. Tap the back button.
   3d. Observe a new phrase named 'Phrase' was created.
4. Tap Marketplace.
5. Tap SmartApps.
6. Tap My Apps.
7. Tap ZWN-SC7 Button Controller.
8. Select the controller added in step 1 and click Next.

Observed Result:
A message reading "Sorry, but there was an unexpected error." will appear and the user can not continue. Looking in live logging will so the app calling to get routines and the routines returned will include a 'null', which is the fragment created in step 3. Removing this fragmented routine will eliminate this error.

Expected Result:
Ideally the app will handle a null routine gracefully, though this may be a limitation of the smartthings app framework. Additionally, the issue can be considered fringe and may not be worth fixing.