mjangda / plugin-notes Goto Github PK

Hello,

Just installed your plugin on my test Multisite install. Will let you know if any show stopper issues I find.

One UI issue that should only affect Mac users (I am using Chrome). When I use the color chooser dropdown, the dropdown doesn't show the colors, only the hex values - see screenshot:

Would love to see an OSX compatible update sometime, thanks!

patrick

Environment: WP 4.4.8 on PHP 7.0.19 with Plugin Notes 1.6 and Pods 2.6.8.

Both Plugin Notes and Pods use PHP Markdown 1.0.2, which leads to a conflict when Plugin Notes is activated and Markdown is enabled in Pods.

As it turns out, the fault lies with Plugin Notes’ markdown.php file.

Since Plugin Notes is doing its job exclusively on the Plugins page ( /wp-admin/plugins.php), this is where the bug shows: When loading the Plugins page, either Pods or Plugin Notes suffers a silent but fatal error. This results, most apparently, in the list of plugins not being displayed completely.

This is what the logs say:

• PHP Fatal error: Cannot redeclare Markdown() (previously declared in /wp-content/plugins/pods/components/Markdown.php:59) in /wp-content/plugins/plugin-notes/inc/markdown/markdown.php on line 56)
• PHP Fatal error: Cannot redeclare identify_modifier_markdown() (previously declared in /wp-content/plugins/pods/components/Markdown.php:151) in /wp-content/plugins/plugin-notes/inc/markdown/markdown.php on line 152)
• PHP Fatal error: Cannot redeclare smarty_modifier_markdown() (previously declared in /wp-content/plugins/pods/components/Markdown.php:165) in /wp-content/plugins/plugin-notes/inc/markdown/markdown.php on line 159)
• PHP Fatal error: Cannot declare class Markdown_Parser, because the name is already in use in /wp-content/plugins/plugin-notes/inc/markdown/markdown.php on line 191)

I got rid of the fatal errors, first, by adding if (!function_exists) {} and if (!class_exists) {}, respectively, to both Pods’ Markdown.php and Plugin Notes’ markdown.php files, as indicated in the error logs.

On further thought, though, no changes at all are necessary in Pods, since it already encloses its Markdown code in if ( !function_exists( 'Markdown' ) ) : ... endif;

while all that is necessary to add to Plugin Notes’ markdown.php is:

on line 14 add if ( !function_exists( 'Markdown' ) ) :
and on line 1750 replace ?> with endif;

I'd like to suggest we use the WP Coding Standards and set up Travis to test all commits & PRs against the WPCS sniffs.

While we're at it, I'd also be happy to set up Scrutinizer to do some basic code quality checking on PRs.

Opinions ?

Should be solved ;-)

However, the problem with this is of course, how to handle notes from different "sources".

Should all notes be network notes ?
Or should sites and network each have their own notes ?

If the latter
Should the network admin show notes from all sites ?
Should individual sites show (non-editable) the notes from the network level ?

Should notes be shown to all site-admins or only to network-admins ?

Etc.

Opinions welcome.

Notice: Undefined variable: note in plugin-notes.php on line 216

Hi guys,

Glad to see the official version on GitHub!

As @mjangda and me discussed over mail some time back I've done some work on the plugin a while back. I never had the time to actually properly finish the last revision, but the work I'd done up to that point might well be worth incorporating now.

You can find the repo with the code here: https://github.com/jrfnl/WP-plugin-notes - not a fork as I put this online way before you created this repo, so that makes it difficult to merge and send PRs.

While the last revision might not have been finished, I did finish two earlier revisions (tagged as 1.5 and 1.6).
This is the changelog for those:

= 2012-12-18 / 1.6 by jrf =
* [_New feature_] Added ability to change the background color of notes

= 2012-12-16 / 1.5 by jrf =
* General code review
* [_Security_] Improved output escaping
* [_Bug fix_] Fixed AJAX delete bug (kept 'waiting')
* [_Bug fix_] Fixed note edit capability bug for when 'edit_plugins' capability has been removed for security reasons
* [_New feature_] Added output filters for html output (`plugin_notes_row` and `plugin_notes_form`) and the note itself (`plugin_notes_note`)
* [_New feature_] Added ability to use a number of variables in notes which will automagically be replaced - see [FAQ](http://wordpress.org/extend/plugins/plugin-notes/faq/) for more info
* [_New feature_] Added ability to use markdown syntax in notes - see [FAQ](http://wordpress.org/extend/plugins/plugin-notes/faq/) for more info
* [_Usability improvement_] Added `<hr />` to allowed tags list
* [_Usability improvement_] Made the default text area for adding a note larger
* [_Usability improvement_] Added automagical target="_blank" to all links in plugin notes including external link indicator
* [_Usability improvement_] Added contextual help for WP 3.3+
* [_Usability improvement_] Added FAQ section and plugin license info to the readme file ;-)
* [_Usability improvement_] Added uninstall script for clean uninstall of the plugin
* [_I8n_] Created .POT file and added Dutch translation

And this is the changelog /road map for what I was working on - most important highlights:

• multiple notes per plugin
• import/export ability
• private notes

= 2013-02-28 / 2.0 by jrf =
PLEASE NOTE: Once you upgrade, you can no longer downgrade without losing your notes!

* General improvements in code, query efficiency and security + code documentation
* [_Bug fix_] 'busy' image not loading when on a multi-site setup
* [_Bug fix_] displayed save date is now properly localized (for dates upgraded to/saved in the timestamp format - upgrade routine included)
* [_Bug fix_] Fixed: AJAX localization
* [_Clean code_] Cleaned up the HTML output
* [_Clean code_] Un-obtrusified the javascript handlers
* [_New feature_] Enabled multiple notes per plugin
* [_New feature_] Added auto-save of version number of the plugin a note applies to
//* [_New feature_] Added option to keep certain notes private: for your eyes only
* [_New feature_] Added admin screen for import/export/purge functionality and override of some option defaults
* [_New feature_] Added import/export functionality
//* [_New feature_] Added option to selectively exclude certain notes from export
* [_New feature_] Added purge functionality
//* [_New feature_] Added export plugin list as text file functionality
//* Added screen options with js show/hide mechanism for notes
* [_Usability improvement_] Change note date saving from formatted date to timestamp to facilitate changes in the date formatting options and date compare on import of notes
* [_Usability improvement_] Added an easy way to change the allowed html tags list
* [_Usability improvement_] Updated the FAQ information in the readme file
* [_Compatibility_] Added plugin notes version number to options to enable upgrade routine
* [_Compatibility_] Added upgrade routine for the new array structure of the plugin options
* [_Compatibility_] Added upgrade routine for new way of saving note date
* [_Compatibility_] Made contextual help available for WP < 3.3
* [_l18n_] Updated the .POT file for new strings & updated the Dutch translation

Hope this helps!

Smile,
Juliette