mitcheljager / svelte-confetti Goto Github PK

Currently the library decides that the confetti should not be displayed at all when prefers-reduced-motion media selector goes through. I think this decision should be left to the users of the library instead. The main problem is that Windows has this one setting to disable animations that affects a very large set of features and this library not working is quite unexpected behavior in that case.

@media (prefers-reduced-motion) {
  .confetti,
  .confetti::before {
    animation: none;
  }
}

Error: Could not find a declaration file for module 'svelte-confetti'.
 '/node_modules/.pnpm/[email protected]/node_modules/svelte-confetti/src/index.js' implicitly has an 'any' type.
  Try `npm i --save-dev @types/svelte-confetti` if it exists or add a new declaration (.d.ts) file containing `declare module 'svelte-confetti';` (ts)
  import { Confetti } from 'svelte-confetti'

@types/svelte-confetti is not in the npm registry

There are currently two lockfiles in the repository, yarn.lock and package-lock.json. Two (possible) ways that this should be mitigated:

• Choose a preferred package manager (personally in favor of yarn or pnpm)
• Exclude a preferred package manager (as this is a library, there's no need to have a lockfile, especially considering that it encourages CI to test against unpinned files that won't be replicated).

Hi there,

Thank you for this nicely documented library!

It's nice if npm dependencies can follow the semver. By default, deps are installed with ^, and so minor versions are included.

Version 1.3.0 was published as a minor update despite bringing a breaking change - dependency on Svelte 4. Following the semver, it should've been 2.0.0.

There is not much one can do at this point since it would require quite a bit of work, but I'm just letting you know nicely, as I see this was done on multiple of your npm packages and it complicates things for people using the packages downstream.

Thanks again

Hello, when I take back the confetti rain from the documentation my whole page starts to lag whereas on the documentation site no problem, would you know where this could be coming from? Example here. The today's answer is "Neon".

I just upgraded to the latest version "svelte-confetti": "^1.2.1" and found this warning:

svelte-confetti doesn't appear to be written in CJS, but also doesn't appear to be a valid ES module (i.e. it doesn't have "type": "module" or an .mjs extension for the entry point). Please contact the package author to fix.

So like my computer said, I'm contacting you here to fix this :)