ministryofjustice / cloud-platform-terraform-ecr-credentials Goto Github PK
View Code? Open in Web Editor NEWECR repositories and credentials for the Cloud Platform
License: MIT License
ECR repositories and credentials for the Cloud Platform
License: MIT License
Hi CP.
Recently, I was forced to provide a prefix for ECR to write variables to GitHub environments. An issue occurred that prevented me from optimising my deployment script.
Problem
Even though GitHub environments were defined in the ECR module, the module persistently tried to write variables at the application repository level using the names ECR_REGION and ECR_ROLE_TO_ASSUME for each deployment, regardless of the configured github_environment
.
This issue caused the ECR module to fail in concourse builds due to an inability to overwrite repository variables.
Solution
Prevent the ECR module from writing application repository-level variables when github_environment
is set.
If the team name in the user's variables.tf file has upper-case letters (e.g.
WebOps), then ECR creation will fail because AWS will reject the name
WebOops/my-test
(assuming a namespace called my-test
).
This PR helps to mitigate this:
ministryofjustice/cloud-platform-cli#38
However, users can still edit their variables.tf file, and the upper-case team
name is technically correct, so we should adjust this module so that it still
works correctly in that case.
A declarative, efficient, and flexible JavaScript library for building user interfaces.
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. ๐๐๐
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google โค๏ธ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.