minhtranite / react-tooltip-component Goto Github PK

I don't see any need to continue firing off the callbacks when you're moving within the element. For me, mousemove has resulted in some tooltips having instability/jittery effects. By using mouseenter/mouseleave, you completely bypass that because the position only gets calculated once.

Just curious if this was an important design decision. Otherwise, I'd switch the events you set up listeners on.

I'm getting this error while using the react-tooltip-component on the server side.

/front/node_modules/react-tooltip-component/lib/Tooltip.js:188
      container: document.body,
                 ^
ReferenceError: document is not defined
    at /Users/rloubradou/workspace/front/node_modules/react-tooltip-component/lib/Tooltip.js:188:18

Setting container: null fixes the issue, and the component is still functional.

If you check the value of title is not a string, assume that it is a react element, this allows for the tooltip to render anything in the tooltip with no issues

renderTooltip = (element) => {
    if (typeof this.props.title === 'string') {
      element.textContent = this.props.title;
    } else {
      ReactDOM.render(this.props.title, element);
    }
  };

componentDidMount = () => {
    // Removed code
    let tooltipContentEl = document.createElement('div');
    tooltipContentEl.className = 'tooltip-inner';
    this.renderTooltip(tooltipContentEl);
    // Removed code
  };

componentDidUpdate = () => {
    this.tooltipEl.className = 'tooltip ' + this.props.position;
    this.renderTooltip(this.tooltipEl.childNodes[1]);
  };

(Notice how the second text is strong)

By doing this I can also use React.Fragment to allow direct rendering to that tooltip element

<Tooltip title={<React.Fragment>Test <strong>Test</strong></React.Fragment>}>{/*Removed*/}</Tooltip>

Love the component, thanks!

However, there is no License file in the directory of the project nor the readme.
I see it's stated in the package.json however as in other projects, its convention to put it in the root directory under the file name LICENSE.

May I suggest the MIT license such as in this project
https://github.com/reactjs/react-tabs/blob/master/LICENSE