mingweisamuel / zyra Goto Github PK

Do you have an estimation completion on the new version of this library?

Currently only supports getting league position, with the lower rate limit it is worth also supporting getLeagues

Riot keys have been updated to this.

Rate Limit(s):
20 requests every 1 seconds
100 requests every 2 minutes
Note that rate limits are enforced per region. For example, with the above rate limit, you could make 500 requests every 10 minutes to both NA and EUW endpoints simultaneously

Currently will just throw a RiotResponseException, I believe

Enums need to be updated for V3.

Rate limits are now included in headers. Deprecate constructors that take rate limits and instead detect rate limits in the response headers of the first request (and check the current request counts).

current uses query param

Currently there is the logic to divide a key evenly between n machines. It may be better to allow users to supply a percentage corresponding to the percent of the key the instance gets to use, so it doesn't have to been even among all machines.

Roles are pretty finicky and annoying to deal with, would be nice to have a system to deal with them in the entity API. Sometimes bot lanes are mislabeled as (bot, duo), (bot, duo) instead of (bot, duo_carry), (but, duo_support), could maybe deal with cases like that

I'm a lazy bum

One of the weird things with the API is that matches use TEAM_BUILDER_RANKED_SOLO (420) but then when pulling the rank uses the string "RANKED_SOLO_5x5" (for example). May be worth adding some sort of logic to translate between the match queues and rank queues, but not sure if its worth trying to cover up issues with the API. Should at least add a note about this in docs.