Git Product home page Git Product logo

nether's People

Contributors

cure avatar diablosxm avatar fling- avatar fluxionary avatar joeenderman avatar lortas avatar louisroyer avatar lukc avatar mio-19 avatar paramat avatar pilzadam avatar programmerjake avatar rudzik8 avatar smalljoker avatar sofar avatar sys4-fr avatar tenplus1 avatar treer avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar

nether's Issues

Burning-related notices

I've noticed there is not much lava pools in nether, nor randomly scattered burning fires in big amounts, it is pretty dark and quite, the only danger is falling down the cliff.

Not sure if this is an issue, tried the mod but it dried up the nearby oceans

Server : multicraft
mapgen : v7


Installed the mod correctly.
All nether stuff works fine.
Issue is where-ever i marked the spawn was surrounded by a large ocean. Now after installing mod that ocean is being replaced by air as i move around the ocean. Is this a bug or expected behaviour ?? or Mapgen is doing something nasty with oceans/water bodies on surface ?

Glitched into exit portal

When you spawn a portal and walk into it in 0.5.0-git and 0.4.17 stable you will spawn immersed with your feet into bottom obsidian block of exit portal, this adds confusion and led to my quick death by falling in the void.

Nether trees.

A species of tree for the nether could make the place look more alive, maybe it could be based on coral?

Is anything needed before I update ContentDB?

ContentDB is still listing a buggy version from 2018. Rubenwardy has added me to the ContentDB nether maintainers so I plan to eventually tag and release a v2 of nether, and possibly add more information to the page.

Is there anything wanting attention before that? Or anything that should be added to the ContentDB page?

We can always post new versions to ContentDB as new PRs are merged.

Edit: Will wait on #26 - sounds like it's not sorted yet.

fumaroles in the overworld don't create fire, but do extinguish fire if they're near some

a player was trying to use them to add a smoking effect to a bonfire build, but the fire kept going out. it took a while to understand what was going on.

the correct behavior should probably be either:

  1. fumaroles work the same in both the nether and in the "overworld"
  2. fumaroles neither create nor extinguish fire in the "overworld"

i prefer #2, but i thought i'd ask before submitting a PR.

Exit portal at -33.5 surrounded by rock

If you create portal in nether and walk into it, new portal is created at -33.5 in rock, trapping you inside (Carpathian mapgen). Managed to do it twice, so it is problem a potential problem. Engine 0.5.0
Note, above it is ocean.

default
default

use abs(cave_noise) value should be used

I haven't made that change in PR #13 because while the change is backwards-compatible, it wouldn't be forwards-compatible (rolling a server back to an older version of the Nether mod might leave chunk-boundary walls in the nether) so this can be a separately considered topic/PR.

Why

Currently the nether exists as small sparsely distributed "bubbles" where the 3d noise value exceeds 0.6. By using the abs value of the noise we pack twice as many of these unconnected Nether bubbles into the same space:

  • Portals will locate a bubble of Nether faster.
  • If PR #13 gets merged then the Nether will no longer default to taking up the entire underground (to play nicely with any other mods that may wish to add underground realms), in which case better use of the space it does have is better.
  • If trying to tunnel your way out of your local Nether bubble, it becomes more likely you could eventually break through into another one. Currently the Nether bubbles are too far apart for that.

Edit/Correction

Originally this Issue erroneously suggested:

I reckon the np_cave noiseparams should have the absvalue flag set.

However the absvalue flag does something very different, using an abs() value at every octave rather than after the octaves have been combined.

Invalid UTF-8 string in init.lua

See this comment regarding this: b8dab52#commitcomment-34536461

In commit b8dab52 a UTF-8 byte mark order was inadvertently inserted at the beginning (ef bb bf) -- possibly inserted by a text editor.

And it generates the error mentioned in the comment.

2019-08-01 11:58:30: ERROR[Main]: ModError: Failed to load and run script from /home/william/.minetest/mods/nether/init.lua:
2019-08-01 11:58:30: ERROR[Main]: /home/william/.minetest/mods/nether/init.lua:1: unexpected symbol near '�'
2019-08-01 11:58:30: ERROR[Main]: Check debug.txt for details.

lava crust not walkable

in nodes.lua , ln 530, walkable_to = true, is wrong, it should be walkable = true. This is causing issues with mobs not being able to walk on lava_crust.

Use node timer

A node time would be more efficient, ideally only on one of the nodes

Portal into protected area

Currently it is possible to activate a portal on one side and let the corresponding portal create itself in a protected area.

Can you add a is_protected check to where the new portal is created?

nether_brick_deep.png -- what license!?

In README.md, it's said it's "Unlicensed but permission for inclusion by kovaszos_uborka"...

But what does it mean "permission"? Permission to do what?

I'm the Debian packager, and it's problematic not to have a clear view of what is allowed with this file.

Error with Ore Info

Incorrect work with ore_info. Error:

AsyncErr: Lua: Runtime error from mod 'ore_info' in callback on_playerReceiveFields(): /home/username/.minetest/mods/ore_info/init.lua:85: attempt to concatenate a table value

ore_info accesses minetest.registered_nodes[ore_name].tiles[1] and it looks like you have implemented this with an error

Unknown node: stairs:stair_cobble

ModError: Failed to load and run script from ~/.minetest/mods/nether/init.lua:
Unknown node: stairs:stair_cobble
stack traceback:
	[C]: in function 'get_content_id'
	~/.minetest/mods/nether/mapgen.lua:78: in main chunk
	[C]: in function 'dofile'
	~/.minetest/mods/nether/init.lua:59: in main chunk

When launching a world,
I am running the most recent version of
https://notabug.org/TenPlus1/stairs
and 5.2.0 of Minetest and its game.

mapgen crash

When exploring the nether, occasionally the server will crash with the following error:

2021-02-28 18:48:28: ERROR[Main]: ServerError: AsyncErr: Lua: finishGenRuntime error from mod 'nether' in callback environment_OnGenerated(): ...minetest/minetest/bin/../mods/nether/mapgen_dungeons.lua:176: attempt to index field 'nether_caverns' (a nil value)
2021-02-28 18:48:28: ERROR[Main]: stack traceback:
2021-02-28 18:48:28: ERROR[Main]:       ...minetest/minetest/bin/../mods/nether/mapgen_dungeons.lua:176: in function 'excavate_dungeons'
2021-02-28 18:48:28: ERROR[Main]:       ...projects/minetest/minetest/bin/../mods/nether/mapgen.lua:462: in function <...projects/minetest/minetest/bin/../mods/nether/mapgen.lua:328>
2021-02-28 18:48:28: ERROR[Main]:       ...jects/minetest/minetest/bin/../builtin/game/register.lua:422: in function <...jects/minetest/minetest/bin/../builtin/game/register.lua:406>

I believe it occurs only on master (bafa4e8) and not v3 (1fbab74).

I have only been able to reproduce it on my survival world with a lot of mods enabled (see attached file). I have not been able to reproduce on a brand new world.

example_world_mt.txt

portal to nether fails to teleport player, if nether is located above the overworld

With these settings, the nether will be located way above the overworld:

nether_depth_ymax = 30500
nether_depth_ymin = 25000

Result is that is_within_realm pos.y is always lower than nether.DEPTH_CEILING on any portal. This leads to the first, igniting portal found as teleport target.

Solution is too small for a proper pull request, so just here:

init.lua 154:

is_within_realm = function(pos) -- return true if pos is inside the Nether
	return pos.y < nether.DEPTH_CEILING
end,

=>

is_within_realm = function(pos) -- return true if pos is inside the Nether
	return (pos.y < nether.DEPTH_CEILING and pos.y > nether.DEPTH_FLOOR)
end,

There needs to be a way out if you start in the Nether

All we need is a source of food, a source of wood, some tools, probably a new ore, and a way to make an exit portal. Food and wood could be solved by the mushroom trees me and the other guy are working on. Tools and ore could be Murexium or Veridium. Murexium would be deep purple. Veridium would be dark green. Or Xenium. Xenium would probably be light blue? To contrast with Mithril? Portals require Mese to ignite, so maybe a Mese crater rarely? Or add Mese to stronghold chests? Or, maybe a ruined portal generates rarely? I need feedback, but I can add most of these features I think.

ERROR ver 5.2.0 Release

2020-04-07 05:32:44: ERROR[Main]: ModError: Failed to load and run script from /home/imk/minetest/bin/../mods/nether/init.lua:
2020-04-07 05:32:44: ERROR[Main]: Unknown node: stairs:stair_cobble
2020-04-07 05:32:44: ERROR[Main]: stack traceback:
2020-04-07 05:32:44: ERROR[Main]:       [C]: in function 'get_content_id'
2020-04-07 05:32:44: ERROR[Main]:       /home/imk/minetest/bin/../mods/nether/mapgen.lua:78: in main chunk
2020-04-07 05:32:44: ERROR[Main]:       [C]: in function 'dofile'
2020-04-07 05:32:44: ERROR[Main]:       /home/imk/minetest/bin/../mods/nether/init.lua:59: in main chunk

ERROR ver 5.2.0 Release
5.2.0-dev-0df646e-dirty worked well

mapgen.lua:122: attempt to compare nil with number

Using current master (89a4676):

ERROR[Main]: ModError: Failed to load and run script from …/mods/nether/init.lua:
ERROR[Main]: …/mods/nether/mapgen.lua:122: attempt to compare nil with number
ERROR[Main]: stack traceback:
ERROR[Main]:       …/mods/nether/mapgen.lua:122: in function 'override_underground_biomes'
ERROR[Main]:       …/mods/nether/mapgen.lua:152: in main chunk
ERROR[Main]:       [C]: in function 'dofile'
ERROR[Main]:       …/mods/nether/init.lua:122: in main chunk
ERROR[Main]: Check debug.txt for details.
ACTION[Main]: Server: Shutting down

I added debug code to obtain the effective values:

number:31000 > number:-11000 && nil:nil < number:-5000 ?

The bug only occurrs with other mods, but I have too many to disect which one causes the conflict. I'd prefer we have a safe fallback here, but I'm not sure which decision would err on the safe side.

Unknown nodes appear below the nether

The nodes in question are the "node_stone" of the nether_caverns biome, they just look like unknown nodes because node_stone is set to "nether:native_mapgen" and "nether:native_mapgen" has an empty definition.

I'm unsure whether this is an engine bug, or a constraint I don't understand.

With a biome defined from -5000 to -11000, the entire chunk below the biome ends up with the biome's node_stone appearing at underhangs.

The relevant chunk spans 10992 to 11072, so the node_stone appears down to 11072 even though the biome was defined with a y_min of -11000, and has its vertical_blend set to 0.

This can be hidden by using a biome y_min of -11072 instead (i.e. align the biome boundary to the chunk boundary by setting the bottom of the nether to -11072), but I'd like to understand whether it's an engine bug or blend feature or an oversight in my understanding of biomes.

(Ignore the fact that the node_stone appears as "unknown" in the screenshot, that's unrelated and doesn't affect the issue)
screenshot_20210705_225643_small

To "fix"

Set the bottom of the nether to -11072 (or your nearest chunk boundary y value)

override_craftitem (a nil value) error on startup

Engine f1d2bc09

ERROR[Main]: ModError: Failed to load and run script from \minetest\bin\..\mods\nether\init.lua:
ERROR[Main]: \minetest\bin\..\mods\nether\init.lua:533: attempt to call field 'override_craftitem' (a nil value)
ERROR[Main]: stack traceback:
ERROR[Main]: 	\minetest\bin\..\mods\nether\init.lua:533: in main chunk

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.