Add support for bypass_pull_request_allowances argument from github_branch_protection resource about terraform-github-repository HOT 6 OPEN

I would assume so because this is a feature that was merged into the provider fairly recently which means supporting the feature in this module would have to drop support for a lot of versions ( from 4.20 to 5.20 ).

After going through most of the feature / pull requests here that might introduce breaking changes, the highest version ( that I observed ) to bump would be to 5.8.0 which is still much older than 5.20.0.

My opinion is that downstream projects should support as many older versions as possible so that it includes as many users as possible. However, there are some projects that consider the opposite. I am not sure how the project maintainers consider releasing breaking changes for this project since I am not part of that group.

PS : My previous comment was merely an attempt to make triaging issues easier for the project maintainers.

from terraform-github-repository.

@shinenelson thanks for your input, I got your point, on the other side people can just stick with an older module version if they don't want to upgrade. But i got your point.

from terraform-github-repository.

hello folks, we will update this module once the 6.0 provide has been released https://github.com/integrations/terraform-provider-github/releases/tag/v6.0.0-rc1

from terraform-github-repository.

bypass_pull_request_allowances is an argument that was added to the github_branch_protection_v3 resource in v5.20.0 via integrations/terraform-provider-github#1578.
This means that we would have to bump our minimum provider requirements to >= 5.20.0.

from terraform-github-repository.

@shinenelson is this an issue for a new release?

from terraform-github-repository.

lesson learned -> don't use modules or unmaintained stuff with terraform

from terraform-github-repository.