mindera / fastlane-plugin-cosigner Goto Github PK
View Code? Open in Web Editor NEWA fastlane plugin to help you sign your iOS builds
License: MIT License
A fastlane plugin to help you sign your iOS builds
License: MIT License
Hey @p4checo ๐ค
we recently integrated one of my plugins into fastlane automatic_code_signing
for setting team_id and signing mode (manual, auto).
your plugin looks super awesome, how about combining forces and integrating the differences/missing-parts into the core action - providing all fastlane users a smooth way to handle codesigning?
namely:
:code_sign_identity
set:profile_name
set:profile_uuid
setbundle_identifier
setfor easy backward compatibility - we can add aliases and even transform parameters in alias_used
let me know if that is something you might wan't to do, if you need help anywhere let me know.
Here is the action i am talking about:
once you have a PR - feel free to directly mention me, and i am going to review it. ๐
regards โ
The team is always set to the default value of "$(PROFILE_UUID)" instead of the specified development_team.
The issue is here:
build_settings['DEVELOPMENT_TEAM'] = params[:development_team]
then later on
FastlaneCore::ConfigItem.new(key: :development_team,
env_name: "TEAM_ID",
description: "Development team identifier",
default_value: "\"$(PROFILE_UUID)\""),
instead of using the DEVELOPMENT_TEAM id which is set, it is here trying to use the TEAM_ID. And when that does not work it tries to use the default value of "$(PROFILE_UUID)" (which also should have a better default value).
NoMethodError: [!] undefined method `[]' for nil:NilClass
/usr/local/lib/ruby/gems/2.5.0/gems/fastlane-plugin-cosigner-2.0.1/lib/fastlane/plugin/cosigner/actions/cosigner_action.rb:21:in `run'
/usr/local/lib/ruby/gems/2.5.0/gems/fastlane-2.85.0/fastlane/lib/fastlane/runner.rb:257:in `block (2 levels) in execute_action'
/usr/local/lib/ruby/gems/2.5.0/gems/fastlane-2.85.0/fastlane/lib/fastlane/actions/actions_helper.rb:50:in `execute_action'
/usr/local/lib/ruby/gems/2.5.0/gems/fastlane-2.85.0/fastlane/lib/fastlane/runner.rb:236:in `block in execute_action'
/usr/local/lib/ruby/gems/2.5.0/gems/fastlane-2.85.0/fastlane/lib/fastlane/runner.rb:231:in `chdir'
/usr/local/lib/ruby/gems/2.5.0/gems/fastlane-2.85.0/fastlane/lib/fastlane/runner.rb:231:in `execute_action'
/usr/local/lib/ruby/gems/2.5.0/gems/fastlane-2.85.0/fastlane/lib/fastlane/runner.rb:157:in `trigger_action_by_name'
/usr/local/lib/ruby/gems/2.5.0/gems/fastlane-2.85.0/fastlane/lib/fastlane/fast_file.rb:148:in `method_missing'
Fastfile:24:in `block (2 levels) in parsing_binding'
/usr/local/lib/ruby/gems/2.5.0/gems/fastlane-2.85.0/fastlane/lib/fastlane/lane.rb:33:in `call'
/usr/local/lib/ruby/gems/2.5.0/gems/fastlane-2.85.0/fastlane/lib/fastlane/runner.rb:49:in `block in execute'
/usr/local/lib/ruby/gems/2.5.0/gems/fastlane-2.85.0/fastlane/lib/fastlane/runner.rb:45:in `chdir'
/usr/local/lib/ruby/gems/2.5.0/gems/fastlane-2.85.0/fastlane/lib/fastlane/runner.rb:45:in `execute'
/usr/local/lib/ruby/gems/2.5.0/gems/fastlane-2.85.0/fastlane/lib/fastlane/lane_manager.rb:57:in `cruise_lane'
/usr/local/lib/ruby/gems/2.5.0/gems/fastlane-2.85.0/fastlane/lib/fastlane/command_line_handler.rb:36:in `handle'
/usr/local/lib/ruby/gems/2.5.0/gems/fastlane-2.85.0/fastlane/lib/fastlane/commands_generator.rb:108:in `block (2 levels) in run'
/usr/local/lib/ruby/gems/2.5.0/gems/commander-fastlane-4.4.6/lib/commander/command.rb:178:in `call'
/usr/local/lib/ruby/gems/2.5.0/gems/commander-fastlane-4.4.6/lib/commander/command.rb:153:in `run'
/usr/local/lib/ruby/gems/2.5.0/gems/commander-fastlane-4.4.6/lib/commander/runner.rb:476:in `run_active_command'
/usr/local/lib/ruby/gems/2.5.0/gems/fastlane-2.85.0/fastlane_core/lib/fastlane_core/ui/fastlane_runner.rb:75:in `run!'
/usr/local/lib/ruby/gems/2.5.0/gems/commander-fastlane-4.4.6/lib/commander/delegates.rb:15:in `run!'
/usr/local/lib/ruby/gems/2.5.0/gems/fastlane-2.85.0/fastlane/lib/fastlane/commands_generator.rb:333:in `run'
/usr/local/lib/ruby/gems/2.5.0/gems/fastlane-2.85.0/fastlane/lib/fastlane/commands_generator.rb:42:in `start'
/usr/local/lib/ruby/gems/2.5.0/gems/fastlane-2.85.0/fastlane/lib/fastlane/cli_tools_distributor.rb:98:in `take_off'
/usr/local/lib/ruby/gems/2.5.0/gems/fastlane-2.85.0/bin/fastlane:20:in `<top (required)>'
/usr/local/bin/fastlane:23:in `load'
/usr/local/bin/fastlane:23:in `<top (required)>'
A declarative, efficient, and flexible JavaScript library for building user interfaces.
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. ๐๐๐
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google โค๏ธ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.