The minor_wd_wafs from mimaaa

minor_wd_wafs's People

Contributors

Watchers

minor_wd_wafs's Issues

section#nav is redundant

Don't nest nav in section element. Nor single article/section element in section element.

Section elements must group multiple elements together

Use relevant names

sections.hide() seems more appropriate

https://github.com/Mimaaa/WAFS/blob/4585e8053d4524d276ebc74741d56acfa6eac4d6/Week1/SPA/static/js/app.js#L19

try the following to fix your problem

(function() {
  "use strict";

  window.location.hash = '#home';

  var sectionsRemove = document.querySelectorAll('section:not(:first-child)');


  (function () {
    for (var i = 0; i < sectionsRemove.length; i++) {
      sectionsRemove[i].classList.add('hidden');
    }
  })();

  var app = {
    init: function() {
      routes.init();
    }
  };

  var routes = {
    init: function(){
              window.addEventListener('hashchange', () => sections.toggle(window.location.hash), false)
          };
    }
  };

  console.log(routes);

  var sections = {
    toggle: function(route){
      document.querySelector(route).classList.remove('hidden');
      document.querySelectorAll('section:not(:first-child)').forEach(function (section){
        section.classList.add('hidden')
      });
    }
  };
  app.init();
}());

This will probably be unnecessary u should test it without this part now

var sectionsRemove = document.querySelectorAll('section:not(:first-child)');


 (function () {
   for (var i = 0; i < sectionsRemove.length; i++) {
     sectionsRemove[i].classList.add('hidden');
   }
 })();