milankovacic / vitest-visual-studio-code-extension Goto Github PK

First off thank you for forking and improving this plugin!

Describe the bug
The inline display of a test error value shows the error. The peek popup only shows "undefined" for expected and actual.

To Reproduce

assert.deepEqual(["123"], ["234"])

Expected behavior
Error peek should show the expanded error content, not undefined

Screenshots

Environment

• OS: macOS

• VSCode version: Cursor Version: 0.24.1
  VSCode Version: 1.85.1

• Vitest version: vitest/1.2.2 darwin-arm64 node-v20.10.0

• Vitest plugin version: 0.3.0

Additional context

Describe the bug
A clear and concise description of what the bug is.

To Reproduce
Steps to reproduce the behavior on the example project:

1. Go to '...'
2. Click on '....'
3. Scroll down to '....'
4. See error

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots
If applicable, add screenshots to help explain your problem.

Environment

(Paste info.txt content generated by the example project)

• OS: [e.g. macOS]
• VSCode version:
• Vitest version:
• Vitest plugin version:

Additional context
Add any other context about the problem here.

A link to

https://marketplace.visualstudio.com/items?itemName=milan-kovacic.vitest-lab

somewhere in the README file or the github project description would be helpful

Is your feature request related to a problem? Please describe.
The feature is related to a crashing behavior in case the names of the tests to executed can't be determined statically without running the test module code.

Describe the solution you'd like
Please let the test run somehow terminate orderly in case it has been started via green triangles in the code editor or the Testingview, s.t. it does not write to such outputs to the console, for example:

Test runs should not spin forever within the test results view:

The same applies to the Testing view/explorer:

It's clear that (pseudo) dynamically created tests (and test names) can't be guessed without executing the test module correctly.

Additional context
Two breaking examples:

describe('Foo', () => {
    const x = '1';
    test(x, () => {});
});

describe('Foo', () => {
    for (const x of ['1', '2']) {
        test('1', () => {});
    }
});

Thank you very much in advance!!