Git Product home page Git Product logo

cwf-frontend's People

Contributors

dependabot[bot] avatar mikecthurgood avatar

Watchers

 avatar  avatar

cwf-frontend's Issues

Code review / Questions

Hi Mike, Niklas from Ticketmaster here! I hope you don't mind me submitting this as an issue. After reading the code I have a couple of questions and suggestions for improvements.

  • To make the code easier to read I strongly suggest using a code formatter like prettier and perhaps eslint with some basic rules
  • I suggest adding some notes to the README explaining what the project does so it's not just the default create-react-app template
  • Some files are specifying classes but do not import a sass file e.g. src/components/singleWallComponents/contentTabs.js which makes it difficult to track where the styles come from
  • Any reason why you call localStorage.removeItem in the reducer? You don't usually see side-effects in a reducer I think
  • In src/helpers/Auth.js you have some async functions that create new promises with new Promise. Do we need to do this or can we make the top function async and just awaiting the fetch directly?
  • When encoding query parameter values I recommend using encodeUriComponent (src/components/singleWallComponents/map.js) and you won't have to manually replace the & and other special characters
  • In some places we get quite a deeply nested dom. Can it be flattened? Example: src/components/singleWallComponents/contentTabs.js
  • Multiple function components with the same name e.g. SingleWall makes debugging difficult
  • There are some accessibility issues: inputs without a label, inputs using a placeholder instead of a label e.g. src/components/sortAndFilter/PostcodeSort.js
  • There are some places where I think extracting parts into separate components could make it easier to read and reduce some duplication e.g. src/components/sortAndFilter/WallFilter.js

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.