mike-koch / ets2-mobile-route-advisor Goto Github PK

Should weekdays stay as is (Monday, Tuesday, etc) or be shortened (Mon, Tue, etc)? Also, should the strings be localized?

Another option is to look into possibly using Date.prototype.toLocaleString() which might be able to handle formatting as well as localization.
Date.prototype.toLocaleString() will always return the short date, and using the options parameter isn't supported by many browsers. So it won't be used.

I changed the weight to tonns and by some trailers it shows up to 10 decimal Places like:

15,3450000005 t

is there a way to round this to two decimal places?

In the latest beta of ETS2 and ATS, the section where the speed is displayed will start to turn red, and will be a "solid" red once the driver is 5 km/h (ETS2) or 5 mph (ATS) over the speed limit.

Some discussion about this has occurred in #63, however I am creating a separate issue to keep track of this specific event.

...at some point I'll get this finally resolved 😆

As recommended in #2

1. Provide download/install instructions
2. Indicate that skin requires ETS2 Telemetry Server 3.0.7

Looks like something happened to pl-PL.json, because it isn't a valid JSON file anymore.
(Reported here: http://forum.scssoft.com/viewtopic.php?f=34&t=178742&start=170#p653061 )

I took a small trip using a WoT contract, and the mobile route advisor showed the "Expected" time to be Mon 12:00 and the remaining time at 0 minutes. This should instead display "World of Trucks Contract" (there's logic for it, but it obviously isn't working)

Tested on OS X 10.10.5:

As there currently is a way to add the city names as layers to the map, perhaps it would be worth it to do the same for the default map in ETS2. I have adjusted @Funbit 's map to be more in line with the original map for ETS2.

What does this mean?
Dark-grey background, orange roads. No country names, city names or borders. This way it should be less distracting to use.

A download link: http://www.mediafire.com/view/lj0bvz95wbti737/map-funbit-edited.png
Please be aware that this is a large image, so it may consume quite some memory.

Reported in #2

There are some new translations by new translators since the last time I updated the list, and @Koenvh1 needs to be added as well for "Development" and "Map". A couple translations were submitted to me either by e-mail or via the forums, so I will have to go digging for them.

Its me again. The first issue dont show up, because github thought i was a spam bot?!
Now it should work :)

I changed the weight to tonns (also i change the language to german) and by some trailers it shows up to 16 decimal Places like:

15,3450000005 t

or like in the screenshot

is there a way to round this to two decimal places?

So, I tested my map, and I found a little problem.

Once a city name gets into view, the map disappears.
The problem lies in the createTextStyle function (can be tested by commenting out feature.setStyle(createTextStyle);)

This happens with the ETS2 Telemetry Server app for Android (5.0.1). Huawei P8 Lite. (Not on Firefox or Chrome). The map only disappears when using "point in vehicle's direction". When having north at the top, it doesn't malfunction (but the cities still aren't shown)
(Also, it seems like the map doesn't disappear with OpenLayers 3.9, but it does with 3.14.2)

Hey not sure how much work it is but would it be possible to add GPS support to ATS?

Use Jekyll to improve the consistency and abstraction of the site.

Instead of having fuel markers (and other POIs) directly embedded into the image tiles, we should use layers instead. A list of POIs can be found at https://gist.github.com/mike-koch/bdadae22eb616b4b9dfb. These POIs include:

(Checkboxes are for default ETS2 map only)

• Cities
• Businesses
• Fuel
• Service
• Garage
• Dealer
• Highway/motorway numbers (country and number)
• Speed camera locations
• Hotel
• Parking
• Toll booths
• Quarries

Items that are not in the POIs, but would be nice:

• Ferries
• Train Tunnels (there might be a more specific, better name that that 😛

It would be nice to have each layer separate, allowing users to toggle the layers they want to see on the map. Also these layers should never rotate, so they are always the correct orientation when viewing the map, regardless of the map's rotation.

Roads images might be able to be pulled via: http://ets2map.com/mapicons/Roads/<road-name>

It's still the image from v1.0.3. Should still be 480x275 px.

In the game, when there is no posted speed limit (such as at loading docks), the speed limit icon disappears. However, a speed of "0" is displayed on the skin (since the telemetry API returns 0). We hide the speed limit whenever the limit is "0" to improve overall UX.

So I load up both single and multiplayer ets2 and the route advisor is not showing the map at all, even if I let it sit for longer than 5 minutes skin is version 3.3.0 and the telemetry server is 3.1.0 any ideas on how to force it to show the map or get it to in the first place

Even after starting a drive (or even grabbing a load), the "Connected, waiting for the drive" will remain on-screen until the skin is manually refreshed. Additionally, it looks like "Current Job" is repeated at the bottom, and "Cargo Name" appears even if you do not have a job in the "connecting" phase

Now that we have a new map available (#85), there should be a simple way to add/remove map packs. Ideally it would be nice to be able to switch between "map packs" via the config file (that way the user does not need to download 2 different versions of the skin; they can just change a config parameter). Currently I'm viewing the each map pack to be a folder with the following folder structure:

- vanilla-ets2
  +- /tiles
  +- map.js
- promods-rusmap
  +- /tiles
  +- map.js
..... and so forth

Then in the config the user will enter the folder name of the map they want to use (i.e. vanilla-ets2 or promods-rusmap).

"Expected": "Expected" should be added to each language file.

In the config.json, add two new config options:

• currency code: allow the user to enter their currency code to display the proper symbol on the screen. The telemetry SDK does not provide this information, so the user will need to enter this manually to update the Mobile Route Advisor.

TODO: Add list of currency codes supported in ETS2 and their cooresponding currency symbols to use as reference. There (hopefully) should be HTML codes for each currency code

I tried to sign the Contributor License Agreement you made (at https://www.clahub.com/agreements/mkoch227/ets2-mobile-route-advisor/ ) but every time I get this message :

We're sorry, but something went wrong.

Any idea on how to fix it ?

The in-game route advisor doesn't display this, but I think it would be nice to show the current cruise control speed (if cruise control is turned on).

Add a new tab between "damage" and "about" to display various graphs (acceleration over time, speed over time, etc). Allow the user to enable/disable graphs based on config file parameters.

Just throwing this out here, but I'm wondering if it would be beneficial to have an update check on the "About" panel of the skin. We would only need to check once (when the skin is initialized), and then display the update status when the "about" panel is viewed (or perhaps some sort of alert indicating that a new version is available).

Instead of:

<span class="lJob"></span>

use:

<span data-mra-text="job"></span>

Related to #85

The promods-support branch holds the necessary map tiles and such for Promods and RusMap support. Everything is working, however a few things need to be done:

• Look into hiding some labels at certain zoom levels. Right now, everything looks awfully congested when zoomed out.
• Add Brest (FR). Both goto brect and goto brest went to the same place. The map editor might be necessary to find the location of Brest (FR)
• Bordeaux (FR). The teleporter goes to Bor (CZ), cannot find it and chooses Bordeaux.
• San Sebastian/Donestia (ES). For some reason, it chooses Douglas over San Sebastian/Donestia.
• Haparanda (S). It also has Aranda de Duero as a value.
• Turku (FI). It also has Ulm.
• Timisoara (RO). It is missing.
• All countries from Going East are missing too (Whoops, my bad)
• Convert this into a map pack

Blocking this until ATS is officially released on Feb 3

ATS is coming out this Wednesday, and there are a few things that need to be updated:

• The truck icon (for damage) is different in ATS (see screenshot)
  
  • @denilsonsa , I believe you made the SVGs for the ETS2 truck symbol. Was there a tool/utility that you used to generate the SVG, or did you freehand it? Would you be willing to generate a new SVG for the ATS truck symbol?
• The map is obviously different, and will somehow need to be re-captured
• Speed limit signs are different in ATS (white rectangle shape instead of the red and white circle)

Should I hard-fork this to a new repository (ats-mobile-route-advisor)? Or should this repository hold both skins, and be renamed to something more generic?

Of course, this all depends on ATS being released with telemetry support. If there is no telemetry support, this is impossible to do.
ATS does have telemetry support. The existing plugin works just fine on ATS.

As reported by @raflix261

With the WoT contracts being added, the "Time Remaining" is always 0 minutes, and expected is always at Mon 12:00. It looks like the complete time remaining is not being returned in the API, so I'm not 100% sure how to include remaining time.

I opened a forum topic at http://forum.scssoft.com/viewtopic.php?f=41&t=197521 in regards to this. Hopefully I'll get a helpful response.

Once 1.17 is out, the following will be added to the telemetry SDK:

• Added dashboard-displayed gear, more wheel channels
• Added differential and all gear ratios
• Average consumption made real instead of statistical
• Adblue channels are working now
• Added navigation distance and time channels
• Added current speed limit channel

Those in bold will be useful to et2-mobile-route-advisor and will be added in the next release.

A highly requested feature is to include 3rd-party maps (such as ProMods). However there is no easy way to capture maps. There are two options:

• Try to get Funbit's capture tool working yet again to accurately gather information
• Use nlhan's ets2-map utility which can map most of the roads out, but seem to be missing prefabs.

I tried using the Google Maps API by obtaining lat/lon pairs in relationship to X/Z pairs; however it didn't work too well, most likely since google maps requires a square map, and funbit's is not square.

Possible options:

• Use funbit's image as a regular JPG and try to line up lat/lon with pixels.
• Try to reverse-engineer (or just ask for source code) of ets2map.com's map and modify it for single-player
• ....something else??

Change gradients to #1e1e1e-#505050, #181818-#404040, and #2c2c2c-#535353

Update http://www.mikekoch.me/ets2-mobile-route-advisor for the 3.0.0 release

• Updated screenshots (perhaps some sort of carousel on the tablet?)
• Pull latest release via GitHub API, rather than _config.yml
• Provide download for custom ets2-telemetry-server
• Display list of translations via the GitHub API. API to call: https://api.github.com/repos/mkoch227/ets2-mobile-route-advisor/contents?ref=i18n

To make sure nothing breaks in the future, it may be beneficial to refactor the existing JavaScript code and write tests for them that can be ran through Travis CI or another build server.

Right now, all languages are included in the download binary. The only issue I have with this is when new translations are submitted, they won't be available in the download unless a new version is released. Should we continue to release updates that just include translations, or should we only release with one language (en-US) and provide a page where users can download translations?

Not sure if users really want this, but perhaps it would be nice to add server information directly in the skin?

DKK is supported in ETS2; however the mobile route advisor does not. Will need to check out economy_data.sii to find the multiplier.

Missing currency codes are now on the wiki. They just need to be added to the game.

Wie kann ich mir die Routen anzeigen lassen bei eurem telemtry Skin TSM Map in Benutzung

Translation: How can I display the routes in your telemtry Skin TSM Map in use

As recommended in #2

Make sure the translations match one-to-one with the translations in-game.

A few people on the SCS forums have asked if there would be voice prompt support in areas... not exactly sure what prompts they would like though. Maybe some of these?

• Over speed limit
• Approaching destination

Perhaps if we utilize the list of POIs we can have triggers for arriving to tolls, etc. I don't think tolls are in the list I found, though.

ETA currently does not support days. It only supports hours and minutes at this point since the day of week is never taken into consideration.

Instead of gameName being either ets2 or ats (in v3.1.0), it is now ETS2 and ATS.

• Update feature list in the README to include mini-map support
• Update screenshots to showcase the new look and mini-map
• Add contributors section to README