Git Product home page Git Product logo

torrent-control's People

Contributors

5im-0n avatar alexey71 avatar anthonyryan1 avatar antorell avatar delgan avatar emteedee avatar jesec avatar mika- avatar penguicky avatar simonbcn avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar

torrent-control's Issues

Error when adding magnet link to rutorrent

Hi, I'm trying out this add-on but I get an error when using it with a rutorrent hosted in seedbox.io.

image

rtorrent version: 0.9.6/0.13.6 (not sure if the rutorrent version is the same or part of it).

Let me know if you need more info.

[Bug] qBittorrent 404 Error

When trying to test the connection or send torrents to qBittorrent it doesn't work and instead gets a 404 error.
I think this maybe because qBittorrent nightly has dropped support for their old API.

Also, i am using the most up to date vershon of torrent-control.

HTTP request failed: [404:NotFound] [POST] at [http://163.172.39.74:9000/login]

API Documentations:
https://github.com/qbittorrent/qBittorrent/wiki#webui-related

"null" auto-populating - flood

When adding torrents to flood, the extension is automatically trying to place new torrents into the directory "null" by default with a tag of "null". This causes the torrents not to start. I would expect the default behavior to be no tag at all if I don't specify a tag, and the default directory if I don't specify one.

Labels don't work with deluge

I have the labels plugin enabled in deluge and I added the label torrentcontrol manually. In Torrent Control's settings I set it to use the same label, but any torrents I add don't have that label set.

I'm using Deluge 1.3.15

Add as pause ?

Hi,
I don't understand how to add torrent as pause.
How to do ?
Thanks :)

Add-on terminates/quits/crashes transmission-daemon

(In reply to https://addons.mozilla.org/en-US/firefox/addon/torrent-control/reviews/996230/)

My setup:

  • Ubuntu Server 16.04 running headless transmission-daemon: 2.92-1ubuntu1~16.104.2.
    RPC port open to clients on local network.
  • Firefox addon on multiple clients

Installing this addon and adding a torrent from the context menu terminates/quits/crashes transmission-daemon.

syslog:
Dec 3 13:13:00 ubuntu-server transmission-daemon[11338]: Closing transmission session... done.

transmission-daemon debug-log:

[2017-12-03 13:44:21.497] ubuntu-17.10-desktop-amd64.iso Verifying torrent (verify.c:224)
[2017-12-03 13:44:21.497] ubuntu-17.10-desktop-amd64.iso verifying torrent... (verify.c:62)
[2017-12-03 13:44:21.497] ubuntu-17.10-desktop-amd64.iso Verification is done. It took 0 seconds to verify 1501102080 bytes (1501102080 bytes per second) (verify.c:167)
[2017-12-03 13:44:21.497] ubuntu-17.10-desktop-amd64.iso Announcing to tracker (announcer.c:1552)
[2017-12-03 13:44:21.497] ubuntu-17.10-desktop-amd64.iso Announcing to tracker (announcer.c:1552)
[2017-12-03 13:44:24.301] Saved "/home/transmission/.config/transmission-daemon/settings.json" (variant.c:1266)
[2017-12-03 13:44:24.301] DHT Uninitializing DHT (tr-dht.c:348)
[2017-12-03 13:44:24.301] DHT Not saving nodes, DHT not ready (tr-dht.c:359)
[2017-12-03 13:44:24.301] DHT Done uninitializing DHT (tr-dht.c:396)
[2017-12-03 13:44:24.301] Port Forwarding Stopped (port-forwarding.c:180)
[2017-12-03 13:44:24.301] RPC Server Stopped listening on 0.0.0.0:9091 (rpc-server.c:801)
[2017-12-03 13:44:24.301] ubuntu-17.10-desktop-amd64.iso Removing torrent (torrent.c:1915)
[2017-12-03 13:44:24.301] ubuntu-17.10-desktop-amd64.iso Pausing (torrent.c:1856)
[2017-12-03 13:44:24.301] Saved "/home/transmission/.config/transmission-daemon/resume/ubuntu-17.10-desktop-amd64.iso.40448d478d9203a3.resume" (variant.c:1266)
[2017-12-03 13:44:24.301] Saved "/home/transmission/.config/transmission-daemon/stats.json" (variant.c:1266)
[2017-12-03 13:44:24.301] Closing libevent thread (trevent.c:262)```

As you can see, a couple of seconds after the torrent file is added, the daemon starts shutting down...

Thanks for you quick feedback before. I'm happy to help debugging and troubleshooting in order to get it working.

- Robert

Unable to download torrent on some trackers

Hi.

I tried to fix it by myself but I could not find what was going wrong.

Basically, while trying to download a torrent on this tracker: https://yggtorrent.com/ (most popular semi-private french tracker), I get a "Failed to add torrent" error.
Actually, my PR #11 was wrong and should be reverted. The returned response type is indeed "text / html", but it does not contain torrent bytes, it contains a string: "Vous devez vous connecter pour télécharger un torrent" which imply that for some reason the credentials are not properly supplied to the get request.

I tried to pass cookies and headers manually from my browser to the fetch() function but it did not work any better.

torrent fetch issue

I tried to add a torrent file to deluge with the right click context menu and it failed with the message "failed to read torrent". After little debugging of the problem I found the type of the torrent is ""application/x-bittorrent; charset=utf-8" at line 64 of index.js, and thus string match fails triggering the error message.

Hopefully this info helps.

Failed to fetch (404)

Hi therre,

Using a private torrent, I'm getting "Failed to fetch" errors trying to download a torrent with Torrent control (FireFox 62.0 (64-bit) notification in MacOSX 10.13.6 )
Downloading the torrent directly works, so I suspect some session download problems?
I still need to learn/shown how to debug the extension inside FireFox to be able to give better information

Connecting with username and Deluge

Hiya! When I select Deluge from client list the username becomes locked.

screenshot from 2018-06-15 15-45-52

I glanced at deluge.js and of course have no idea what I am looking at, but I noticed no mention of username.

I am new to using deluge on local network (but thanks, I've used your plugin with qBit for months!), and have always connected with deluge-console. That requires a credential in auth.

I notice there is also a web UI, a separate web daemon that connects to deluged.

Okay, am I missing something? I am not sure how to connect without a username. I tried [email protected]:58846, with and without http://, etc. Regardless of what I try I get, Server address is invalid.

Is the web UI required for the add-on to connect?

Add an option to toggle "Catch torrents url" on icon click

Hi.

What do you think of adding an option so that clicking on the Torrent-Control icon in the navbar would enable / disable catching torrents urls?

That would be very convenient (this was how Bittorrent WebUI extensions worked in Firefox < Quantum), because some time I need to download a bunch of torrents to me seedbox so I would like to avoid using the context menu, and sometimes I just want to download the torrent on my local computer and I would prefer to avoid going through the Torrent-Control settings just to switch the "catch torrents url" option.

So this would just be one-click to alternate between the two downloads mode.

(Btw I already said it but your extension is super useful, thanks!)

BUG No text in options

I just downloaded torrent control. After installation I tried to set it up and none of the fields were labeled and when I typed into them, nothing appeared.

User session gets logged out too

Adding a torrent via torrent-control logs out my deluge WebUI session.
E.g.: I need to re-log into my deluge WebUI each time torrent-control adds a torrent.
(It might happen with other torrent client, but I did not test it.)

I debug the plugin a bit, and I found the plugin listens to all the requests to the server (the plugin's requests, and my own requests when I visit the deluge WebUI). So the plugin catches and injects the same session cookie of all those requests, so when the plugin logOut() after adding a torrent, it actually logs me out too because it is the same session.

I cannot tell if hijacking all session cookie is a feature or a bug.

If sharing the same session cookie between the plugin and the user is a feature (instead of having the plugin create it's own session), then a fix could be to simply add an option to optionally not log out the session ?

(Tested on FF 58, Linux, torrent-control 0.1.10, deluge WebUI)

Does not appear to do anything

Just installed and while config works, no icon is appearing to add to the toolbar and just a save dialog is opening when torrents links are clicked. If I select "Add Torrent" from right click menu, I get a failed to read torrent error.

Wrong username or password

Clean qBittorrent (with -nox package) install with no matter which password.
Without any problem log in to webui, but cannot add torrent file by extension getting error in title.
Configuration is:
server address: http://192.168.5.222:8080/gui/
Username: admin
Password: adminadmin | secret | password

If change address to http://192.168.5.222:8080/ - getting error "Failed to add torrent"

OS: CentOS 7
qBittorrent: 3.3.7

NetworkError when attempt to fetch resource. Deluge

Clicking on magnet links or rightclicking and adding a torrent by torrent control throws me the error.
Connection to the server doesn't seem to be the problem as I get to the deluge web ui if I click on the tc button in the firefox menu.

Roll back to previous version? (or a minor adjustment suggestion)

I understand this is free, and it is by far the best thing to use on Firefox, but since I am using a split-tunneled VPN where the torrents are using a VPN, but my browser isn't always, this plugin has always and still is a perfect work-around.

I don't know how to do it from source, but I'd prefer to go back to the version were the context menu doesn't have the tree expand with the new Add Paused.
I understand how that could be useful to some, but it isn't for me, and after trying for a full month, I still sometimes miss/forget it and just click on the Torrent Control (in the right click context menu).

I had hopped in the settings I could disable the new tree... not just uncheck the "add torrent (paused" and leave the "add torrent" as a single item on the tree... I am talking about reverting to the old single item if you choose to remove the (paused) option via some type of checkbox on the options page.
Again, I am completely happy to just uninstall v0.23 and reinstall the version prior to this multi-option, whatever is easier.., if nobody else is bothered by the tree, then I am fine staying on the previous version.
Lastly, what exactly is the check box for "Catch Torrent URLs" ? I can't find help info anywhere on what that actually does. I can only assume it has something to do with that line about uTorrent, but with me using qBittorrent I haven't seen any effect.

Not working if ruTorrent authentication requested is not "Basic"

Hi again.

I have trouble configuring torrent-control so that it can work on ruTorrent, I always have "Failed to login" error.

After digging through the code, I think this is maybe because of torrent-control using "Basic" authentification while my seedbox only accept "Digest". I am not sure because I do not know much about HTTP requests en Authentification, but after looking manually at the headers on my browser, Firefox automatically use Digest and the server does not return 401.
I the auth is not Digest, the response header looks like this (status code = 401 Unauthorized):

Date: Thu, 11 Jan 2018 20:03:35 GMT
Server: Apache/2.4.18 (Ubuntu)
WWW-Authenticate: Digest realm="rutorrent", nonce="9EuWjkXcYDE=adf164bbt687a3e33727f321104f1e0de1hp365d", algorithm=MD5, qop="auth"
Content-Length: 462
Keep-Alive: timeout=5, max=100
Connection: Keep-Alive
Content-Type: text/html; charset=iso-8859-1

According to the documentation, the request header Authorization has to be set after a 401 response, the 401 response contains a WWW-Authenticate header which should be used to determine the proper authentification method.

But there exist many methods, we need something generic rather than implement them all.

The fetch() function is described as accepting an init parameter, which itself may contain a credentials value. The latter could accept a PasswordCredential object which looks nice, but unfortunately is only available in Chrome, not Firefox...

Before Firefox Quantum I used bittorrent-webui which worked very well with my seedbox. So I looked at the source code, and it seems it was using XMLHttpRequest.open() which I guess take care of formatting authentification as requested.

Do you have any idea how we could integrate this with torrent-control using fetch() or something else? Because I must admit that I have not managed to make it work unfortunately.

[Feature Request] Optional Clipboard Monitor

Can you please add optional (with enable option) clipboard monitoring particularly for android support.
For example, if any magnet links or links ending in .torrent are found within the clipboard then send them to the torrent client.
Thanks

Doesn't automatically log in?

I figured the username & password settings was for logging in automatically but it asks for them every time I restart my browser. Is this normal behavior?

TypeError:

Gday

When trying to add a magnet link with a previous add on, i started getting an error "TypeError: NetworkError when attempting to fetch resource" Nothing changed with browser/password/URL that I know of to have caused it. Ditched that add on and installed Torrent-Control and still get the same error trying to add torrents to my media PC.
Site is Pirate Bay if that matters
FF 61.0.1
Windows 10 Home

Bulk add torrents from a webpage [Feature Request]

Hello,

Can you please add an option to "bulk add" torrent links (even those not pointing to a .torrent file directly) to rutorrent and other interfaces?

Let me know if you need more clarification.

Thanks

Unknown response. (404: Not Found) while sending magnet link to qBittorrent v3 webui

Hi,

I just installed the extension and wanted to test it with my qBittorrent setup and ended up with this error message.

The reason for it is probably because the version of qBittorrent on my Debian 9 (Stretch) box is 3.3.7. There are no newer versions available for that platform (it is my current Raspberry Pi installation).

Could you please introduce an additional"client" in your add-on? Something like "qBittorrrent v3" and adapt the code to the APIs of v3? It would help a lot.

Thanks in advance!

Add support for qBittorrent 4.1.x

I keep getting this message though I have checked my credentials many times. My client is v4.1.0alpha. What could be the problem?

server.address/login is not a valid URL (WAN/Internet & qBittorrent 4.0.4)

Hello.

This addon seems to have an issue when used through WAN/Internet with qBittorrent 4.0.4.

It works fine if I attempt to use it on the local computer running the torrent client it is supposed to send things to. However by going through the internet it seems there is an issue of the addon trying to fetch a /login page from the server address field.

image

This is despite the configuration amounting to the following, obviously with no /login entered in the server address field. Both LAN and WAN are configured the same way as I have a local DNS resolving the address of the server.

image

The server address in both cases is in the format of:
https://name.ddns.net:port/

Using the dialog option instead of the right click contextual menu also results in the same pop up notification.

I should also note that clicking the icon of the addon in the customizeable toolbar does not open the WebUI on the WAN, but does on the LAN.

Can't change server through configuration

I have two servers defined in the configuration, but I don't seem to be able to use the second server. I have tried changing the server - and then (a) reloading the tab (b) restarting the browser.

This is on Firefox 62.

Clarify the support of Deluge GTK and web client

It'd be nice to see the difference of Deluge GTK and web client reflected in the labels of connection types in the add-on configuration. The initial port 8112 and the inavailability of a username field makes me think that the support is for Deluge web, however it'd be nice if it was just clear.

Not really an issue but a feature request

So far this works great for me, but I am hoping maybe a simple left-click to send / capture the torrent over to the manager would be possible instead of always having to right-click for a context menu to send the torrent over. Is this a possibility?

Add torrent to ruTorrent with both a label AND path

I was previously using Remote Torrent Adder on Chrome which gives users the ability to select both a path AND a label when adding torrents to ruTorrent.

I also add torrents to ruTorrent by uploading them from my local machine to a ~/watch/ directory on my seedbox and I have ruTorrent's AutoWatch feature set to add torrents with a label matching the name of the subdirectory it finds them in within the ~/watch directory. For example, when ruTorrent finds a torrent file in ~/watch/tvshows/, the torrent is added with the label "tvshows". ruTorrent then uses the label "tvshows" to set the download path as ~/seeding/tvshows/ and, when download is complete it copies the files to ~/done/tvshows/.

I know that with Torrent-control, I can use the options "add torrent with label" OR "add torrent with path" but there doesn't appear to be a way to select a label AND a path when adding a torrent to ruTorrent. When I use "add torrent with label" option, the torrent gets added with that label but the files don't get saved to ~/seeding/[label]/ they just save to ~/seeding/. And when I use the "add torrent with path" option with the path set to ~/seeding/tvshows/, the ruTorrent AutoTools feature doesn't add a label based on the path and it doesn't send a copy to ~/done/tvshows/.

Can someone tell me:

  1. Is it possible to configure Torrent-control so that I can select a label AND a path when sending torrent's to ruTorrent?
  2. If Torrent-control can't do this, is it possible to set Torrent-control so that it saves torrents without adding them? This would allow me to save them to my ~/watch/ directory and then I can let ruTorrent's Autotools add the torrent, label and set the path to download and copy to.
  3. Alternatively, if Torrent-control can't be set to just save and not add, does anyone know if Autotools can be configured to set a torrent's:
    • path based on the label selected in Torrent-control
      or
    • label based on the path selected in Torrent-control?

Any help would be appreciated.

Doesn't work on a specific tracker

Hello Mika

I love Torrent Control and use it since release. Thank you for your work.

I joined a tracker that's relatively new and Torrent Control doesn't work there. It just says "Failed to read torrent" if I try to add one via right click. The admins don't really know what could be wrong tracker wise. I thought maybe you can tell us a bit more about this error or how we can get a bit more information. If I download the torrent and manually upload it to my Deluge WebUI it works without a problem. It also works on every other tracker I use without a flaw.

I can't really give you more infos on this now, but if you need further information I'll be glad to do more research.

Thanks in advance and have a nice weekend

pic-55c42a55e0e4f55a0acf3feb03e8fdb4

[Feature Request] Multiple client support

Just a suggestion, since firefox webext is not really mature/complete yet, so it may be not feasible right now.

Right now if you click the extension icon you're taken to the webclient.
I would prefer it it would toggle the extension on/off instead, maybe with a right click opt menu.

That way I could send magnet to my local client when it's off, OR to the remote client if it's on.
I think this would need to wait for proper mimetype handling to be implemented i ffox58?

Would this be feasible? Thanks anyway, this addon is already helpful in replacing the pre ffox57 ones.

[Bug] Not working on android

When clicking on magnet links or torrent download links, unlike on windows where it automatically adds the torrent to the client but, on android nothing seems to happen.

customise torrent url catch regexp

I was confused why catch torrent urls option didn't work sometimes. but I found on #10 it said webextension doesn't allow mime intercept just check regexp for href="*.torrent"

could you pls add a custom option to add new regexps? so for sites with torrent.php?id=12345 it can still work

[Feature Request] URL Monitor

Can you please add support for URL monitoring.
For example, if I was to click a link ending in .torrent or starting with magnet:?xt= it will automatically be sent to the configured torrent client.
Thank You

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.