Git Product home page Git Product logo

carouselview.maui's People

Contributors

microspaze avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar

carouselview.maui's Issues

iOS: Animation always scrolling on the same side when the position is updated in code behind.

When the position is updated in code behind, the animation will always be the same and want go back and forth if the item the position is updated by the code behind. The bug can pe reproduced by running the sample of the repository on an iOS device. When scrolling the horizontal Carousel back and forth, the vertical Carousel will be updated but always using the animation in the same direction. The same can be observed if you scroll the vertical Carousel back and forth, then the horizontal Carousel will update it's content but always using the same side for the animation.

Android Java.Lang.NullPointerException crash in CarouselViewRenderer.SetNativeView when Context is AndroidX.AppCompat.View.ContextThemeWrapper

First of all, thank you for migrating CarouselView to MAUI!

We faced with a crash, when using regular navigation in the .NET MAUI App project, e.g:
MainPage = new NavigationPage(new MainPage()); (imagine MainPage contains CarouselView)

Java.Lang.NullPointerException crash happens in CarouselViewRenderer.SetNativeView on Android.

It happens because context is StackNavigationManager_StackContext which derives from AndroidX.AppCompat.View.ContextThemeWrapper but CarouselViewRenderer.FindActivity method expects Android.Views.ContextThemeWrapper. So, FindActivity returns null and NullPointerException occurs in CarouselViewRenderer.SetNativeView method.
Screenshot 2023-12-12 at 14 23 53

You can reproduce this issue on the sample project attached.
NullPointerCrashDemo.zip

A FIX is to use Android.Content.ContextWrapper class which contains BaseContext we are looking for and is base class for both AndroidX.AppCompat.View.ContextThemeWrapper and Android.Views.ContextThemeWrapper.

I will create a fork with fix to speed up fix of this issue.

Will appreciate if you can handle it as soon as possible.

Regards,
Vitalii

.net 8 support

Hi,

Is it possible to upgrade the package to support .NET8?

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.