The project at https://github.com/kcherenkov/redis-windows-service presents a solution to run Redis as a Windows Service.
Did you try and recommend this solution?

We should remove pthreads and use Windows native Thread support instead.

It would be nice if you guys put together a Nuget package with the latest binaries.

Building by hand is a bit of a pain when it comes to (re)distribution.

No result for keys * for relatively large number of keys, by relatively large meaning more than 5200 keys. It is seen for number of keys less than 5100 , the expected multi bulk output is returned.

To reproduce this, populate the database with appropriate number of normal keys.

Sample Output

Working for keys <= 5100

    [6684] 03 Aug 18:57:04 * The server is now ready to accept connections on port 5970
    [6684] 03 Aug 18:57:04 - Accepted 127.0.0.1:61913
    [6684] 03 Aug 18:57:04 - 1 clients connected (0 slaves), 452324 bytes in use
    [6684] 03 Aug 18:57:09 - DB 0: 5106 keys (0 volatile) in 8192 slots HT.

redis-cli.exe output : of **keys *** [trimmed]

   5104) "3929"
   5105) "4658"
   5106) "4659"
   redis 127.0.0.1:5970>

Observed scenario for keys >=5200

   [4312] 03 Aug 19:03:33 * The server is now ready to accept connections on port 7178
   [4312] 03 Aug 19:03:33 - Accepted 127.0.0.1:62110
   [4312] 03 Aug 19:03:33 - 1 clients connected (0 slaves), 452324 bytes in use
   [4312] 03 Aug 19:03:38 - DB 0: 5206 keys (0 volatile) in 8192 slots HT.

redis-cli.exe output :

   redis 127.0.0.1:7178>
   redis 127.0.0.1:7178> dbsize
   (integer) 5206
   redis 127.0.0.1:7178> keys *
   redis 127.0.0.1:7178> 

Another Scenario where the time is returned

Database 0 populated with more than 50000 keys:

    [7296] 03 Aug 18:43:08 - 0 clients connected (0 slaves), 3146972 bytes in use
    [7296] 03 Aug 18:43:13 - DB 0: 50006 keys (0 volatile) in 65536 slots HT.
    [7296] 03 Aug 18:43:13 - 0 clients connected (0 slaves), 3146972 bytes in use
    [7296] 03 Aug 18:43:18 - DB 0: 50006 keys (0 volatile) in 65536 slots HT.

redis-cli.exe output

   redis 127.0.0.1:8354> dbsize
   (integer) 50006
   redis 127.0.0.1:8354> keys *
   (0.65s)
   redis 127.0.0.1:8354>

Comparison with redis 2.4.16 stable release for non-windows operating systems

[Note: database is loaded from dump.rdb]

Database 9 populated with 1000000 keys:

   [2224] 03 Aug 18:39:47 * DB loaded from disk: 2 seconds
   [2224] 03 Aug 18:39:47 * The server is now ready to accept connections on port 21218
   [2224] 03 Aug 18:39:48 - DB 9: 1000000 keys (0 volatile) in 1048576 slots HT.
   [2224] 03 Aug 18:39:48 - 0 clients connected (0 slaves), 52581792 bytes in use
   [2224] 03 Aug 18:39:53 - DB 9: 1000000 keys (0 volatile) in 1048576 slots HT.
   [2224] 03 Aug 18:39:53 - 0 clients connected (0 slaves), 52581792 bytes in use
   [2224] 03 Aug 18:39:58 - DB 9: 1000000 keys (0 volatile) in 1048576 slots HT.

./redis-cli output of **keys *** [trimmed]

  999997) "415969"
  999998) "343798"
  999999) "343799"
  1000000) "415970"
  (186.04s)
  redis 127.0.0.1:21218[9]>

We need to port Windows code to Redis 2.4.8 code base

I'm running redis 64bit, 2.4, the default branch; windows 2008 r2.
save settings:
save 900 1
save 300 10
save 60 10000
I keep getting
"# ==> ..\src\db.c:482 'dictFind(db->dict,key->ptr) != NULL' is not true"
in the log and redis-server.exe crashes.
I guess it happens when a bgsave is in progress, because a temp-XXXX.rdb, much smaller than dump.rdb, remains in the directory.
I have lots of expiring keys.
thanks in advance for any help.

Looks like a minor issue, process seems to be 64 bit.
Many thanks for the 2.6 alpha release by the way, great stuff.

E:\work\redis\dotnet\redis-2.6_alpha\msvs\x64\Release\redis-server.exe
[4996] 29 Jan 07:28:25.833 # Warning: no config file specified, using the default config. In order to specify a config file use E:\work\redis\dotnet\redis-2.6_alpha\msvs\x64\Release\redis-server.exe /path/to/redis.conf
                _._
           _.-``__ ''-._
      _.-``    `.  `_.  ''-._           Redis 2.6.8-pre2 (00000000/0) 32 bit
  .-`` .-```.  ```\/    _.,_ ''-._
 (    '      ,       .-`  | `,    )     Running in stand alone mode
 |`-._`-...-` __...-.``-._|'` _.-'|     Port: 6379
 |    `-._   `._    /     _.-'    |     PID: 4996
  `-._    `-._  `-./  _.-'    _.-'
 |`-._`-._    `-.__.-'    _.-'_.-'|
 |    `-._`-._        _.-'_.-'    |           http://redis.io
  `-._    `-._`-.__.-'_.-'    _.-'
 |`-._`-._    `-.__.-'    _.-'_.-'|
 |    `-._`-._        _.-'_.-'    |
  `-._    `-._`-.__.-'_.-'    _.-'
      `-._    `-.__.-'    _.-'
          `-._        _.-'
              `-.__.-'

[4996] 29 Jan 07:28:25.880 # Server started, Redis version 2.6.8-pre2
[4996] 29 Jan 07:28:25.880 * The server is now ready to accept connections on port 6379

when I run client applicationusing hiredis and AE module in a windows 2003 server（x86），the
app crashed at aeWinReceiveDone：WSARecv， i fixed it，by add one line before the call WSARecv， wsarecvflags = 0.
I seek all the source file， I can't see a wsarecvflags init code。Why？

I'm using localized version of windows and i've got following error

An error occurred whilte applying security settings .\Users is not a valid user or group

I'd run net localgroup /add Users and group was created, but this didn't help.

Can u guys distribute RedisWatcher through WebPI? As you may know, there is a comman line version of the procudt (WebPICMD.exe) and this would make some much easy to automate the installation process.

You can test this out by creating a Win32 project, link against hiredis, and then do the following:

w32initWinSock();
auto pRedisContext = redisAsyncConnect("127.0.0.1", 6379);
redisAsyncHandleRead(pRedisContext);

The redisAsyncHandleRead() call blocks.

To fix this, you probably need to put the following into the win32 version of redisContextConnectTcp():
if (redisSetBlocking(c,s,blocking) != REDIS_OK)
return REDIS_ERR;

I did that just after the redisSetTcpNoDelay() and it seems to work nicely.

My symptoms are this:

When running Sentinel, any time I shut down the master, I get "tilt" errors on each of the sentinels. I can shut down the Slaves with no problem.

I'm running all my instances on the same PC (I've tried other configurations too, but this is the simplest one to describe).

My config files are:

Master

port 6379
timeout 0

Slave

port 6380
timeout 0
slaveof 127.0.0.1 6379
slave-serve-stale-data yes
repl-ping-slave-period 10
repl-timeout 60

Sentinel01

port 26379
sentinel monitor mymaster 127.0.0.1 6379 2
sentinel down-after-milliseconds mymaster 5000
sentinel failover-timeout mymaster 900000
sentinel can-failover mymaster yes
sentinel parallel-syncs mymaster 1

Sentinel02

port 26380
sentinel monitor mymaster 127.0.0.1 6379 2
sentinel down-after-milliseconds mymaster 5000
sentinel failover-timeout mymaster 900000
sentinel can-failover mymaster yes
sentinel parallel-syncs mymaster 1

Sentinel03

port 26381
sentinel monitor mymaster 127.0.0.1 6379 2
sentinel down-after-milliseconds mymaster 5000
sentinel failover-timeout mymaster 900000
sentinel can-failover mymaster yes
sentinel parallel-syncs mymaster 1

Can you please check what is wrong? I am supplying the configuration for my redis server from standard input ("-"), and it seems to be executing at the default port instead of the the one given in the config.

Looks like a merge when bad:

<<<<<<< HEAD
ssize_t nread;

ea9d7b9

I found Redis-Server don't release socket.

When I open a redis-cli and closed it, but Redis-Server still show that the connection is alive.

I have tested in redis-2.4.5-win32-win64.zip (https://github.com/dmajkic/redis/downloads), this version of Redis-Server can release socket.

In a Win32 application, linked against hiredis:

static void sRedisCommandCallbackFn2(struct redisAsyncContext_, void_, void* pUserData)
{
bool* pContinue = (bool*)pUserData;
*pContinue = true;
}

int main()
{
w32initWinSock();

auto pRedisContext = redisAsyncConnect("127.0.0.1", 6379);

bool bContinue = false;
redisAsyncCommand(pRedisContext, sRedisCommandCallbackFn2, &bContinue, "SUBSCRIBE foo");
redisAsyncHandleWrite(pRedisContext);

while(!bContinue)
{
    redisAsyncHandleRead(pRedisContext);
}

redisAsyncCommand(pRedisContext, sRedisCommandCallbackFn2, &bContinue, "UNSUBSCRIBE foo");
redisAsyncHandleWrite(pRedisContext);

while(!bContinue)
{
    redisAsyncHandleRead(pRedisContext);
}

bContinue = false;
redisAsyncCommand(pRedisContext, sRedisCommandCallbackFn2, &bContinue, "PING");
redisAsyncHandleWrite(pRedisContext);

while(!bContinue)
{
    redisAsyncHandleRead(pRedisContext);
}

return 0;
}

The code asserts in the last call to redisAsyncHandleRead(). The assert is async.c line 408 (or thereabouts):
assert(c->flags & REDIS_SUBSCRIBED);

At this point, the library is no longer subscribed to any pubsub channels, so it should be valid to send regular commands at this point. It is incorrect for __redisShiftCallback() to return REDIS_ERR in this situation.

Folks should not be required to build the solution just to use the goodness of Redis. Where the binaries go is not of my concern, just that they are the official ones with a version attached to them and that they are publicly available. :)

I thought I followed your directions correctly, but upon compiling, I received 10 errors. Any ideas?

Error 4 error LNK2005: __initp_misc_invarg already defined in LIBCMTD.lib(invarg.obj) C:\dev\redis\Microsoft-Interop-redis-34c3eb3\msvs\LIBCMT.lib(invarg.obj) RedisServer
Error 5 error LNK2005: __call_reportfault already defined in LIBCMTD.lib(invarg.obj) C:\dev\redis\Microsoft-Interop-redis-34c3eb3\msvs\LIBCMT.lib(invarg.obj) RedisServer
Error 6 error LNK2005: __set_invalid_parameter_handler already defined in LIBCMTD.lib(invarg.obj) C:\dev\redis\Microsoft-Interop-redis-34c3eb3\msvs\LIBCMT.lib(invarg.obj) RedisServer
Error 7 error LNK2005: __get_invalid_parameter_handler already defined in LIBCMTD.lib(invarg.obj) C:\dev\redis\Microsoft-Interop-redis-34c3eb3\msvs\LIBCMT.lib(invarg.obj) RedisServer
Error 8 error LNK2005: __invoke_watson already defined in LIBCMTD.lib(invarg.obj) C:\dev\redis\Microsoft-Interop-redis-34c3eb3\msvs\LIBCMT.lib(invarg.obj) RedisServer
Error 9 error LNK2005: "void __cdecl _invoke_watson(unsigned short const *,unsigned short const *,unsigned short const *,unsigned int,unsigned int)" (?_invoke_watson@@YAXPBG00II@Z) already defined in LIBCMTD.lib(invarg.obj) C:\dev\redis\Microsoft-Interop-redis-34c3eb3\msvs\LIBCMT.lib(invarg.obj) RedisServer
Error 10 error LNK2005: __invalid_parameter already defined in LIBCMTD.lib(invarg.obj) C:\dev\redis\Microsoft-Interop-redis-34c3eb3\msvs\LIBCMT.lib(invarg.obj) RedisServer
Error 11 error LNK2005: "void __cdecl _invalid_parameter(unsigned short const *,unsigned short const *,unsigned short const *,unsigned int,unsigned int)" (?_invalid_parameter@@YAXPBG00II@Z) already defined in LIBCMTD.lib(invarg.obj) C:\dev\redis\Microsoft-Interop-redis-34c3eb3\msvs\LIBCMT.lib(invarg.obj) RedisServer
Error 12 error LNK2005: ___pInvalidArgHandler already defined in LIBCMTD.lib(invarg.obj) C:\dev\redis\Microsoft-Interop-redis-34c3eb3\msvs\LIBCMT.lib(invarg.obj) RedisServer
Error 14 error LNK1169: one or more multiply defined symbols found C:\dev\redis\Microsoft-Interop-redis-34c3eb3\msvs\Debug\redis-server.exe 1 1 RedisServer

We should add documentation to the wiki pages:

• links to redis configuration
• explain watcher.conf format

Hello,

it would be very helpfull if someone can provide a binary download of the redis windows version.
I, and I think a lot of others too, do not have visual studio installed.

excuse me,my english is not good

redis-server.exe --loglevel verbose

reproduce problem:
redis-benchmark.exe
press ctrl+c

on server screen, log show:
Accept 127.0.0.1:xxxx
Accept 127.0.0.1:xxxx
Accept 127.0.0.1:xxxx
....
Client closed connection <-- here,only one connection closed
99 clients connected

after run many times,server say:
Error registering fd event for the new client: Result too large
904 clients connected

redis-cli.exe can't connect to server

fast reproduce problem:
redis-benchmark.exe -l

The redis server will return error if fd is large than eventLoop->setsize (in ae.c aeCreateFileEvent function), and the fd is returned by aeWinAccept function in anet.c, which instead the accept function of raw redis server code.
This code will cause problem, in my test, accept in linux will return a value increase 1 every time, but aeWinAccept which call socket function will return a value increase 4 or 12 every time, so if eventLoop->setsize is set to 11024, the redis server will only accept about 11024/12 client connection concurrently. Then the redis server will refuse the new connection and shows ERANGE error.
My test environment is 64bits windows7 and 64bits windows 2003.

My solution is add a array in aeEventLoop to map real fd to events index, and change the access of eventLoop->events[fd] to eventLoop->events[getEventIndex(fd)]

In redisAsyncHandleWrite,When redisBufferWrite not done, new WRITE_EVENT couldn't be register。
because hiredis thank here is an other write_event already registered.

I fix it by add one line "_EL_DEL_WRITE(ac);" before _EL_ADD_WRITE(ac);

Redis-sentinel seems has the same problem。

Hi,

What do you guys say about upgrading the project files to support VS 2012? When one tries to open the solution in VS 2012 the following message appears:
Error 2 error MSB8020: The builds tools for Visual Studio 2010 (Platform Toolset = 'v100') cannot be found. To build using the v100 build tools, either click the Project menu or right-click the solution, and then select "Update VC++ Projects...". Install Visual Studio 2010 to build using the Visual Studio 2010 build tools. C:\Program Files (x86)\MSBuild\Microsoft.Cpp\v4.0\V110\Microsoft.Cpp.Platform.targets
It's easliy solved by setting <PlatformToolset>v110</PlatformToolset> in each project file. I could of course install VS 2010 but if we could upgrade to 2012 that would be perfect. I could not find any bugs when doing this.

I just downloaded the latest release which was labeled as 2.6.8-pre2 and included a dump from our 2.4 version. The only thing I did was double click on the redis-server to start it up. It seemed to sit there for a minute then hard crashed with this message. The entire virtual machine stopped working after this I had to hard shut down.

The hiredis library is being used from redis-cli and redis-benchmark. However there is an example-ae.c in the hiredis directory, and there is no project that shows how this works.

Hi, can you make a small gui (wpf or something) for redisinstwa.exe?
so that you have a small wizard. it makes it more open to other people

http://ossonazure.interoperabilitybridges.com/articles/how-to-deploy-redis-to-windows-azure-using-the-command-line-tool#h2Section4

I'm trying to run RedisWatcher on a Windows Server 2003 box and keep getting the error:

The procedure entry point EventRegister could not be located in the dynamic link library ADVAPI32.dll

From looking at the MSDN documentation, it suggests this function was introduced in Windows Server 2008.

Should Windows Server 2003 be support with the current release? Will it be considered for the future?

According to Redis official documentation Sentinels have functionality of resurrecting of the old master as a new slave (see http://redis.io/topics/sentinel section “Resurrecting master”) if the old master is online again. But it seems there is no resurrection in the version I've tried.
Repro steps:

1. Start Redis master server with two slaves and two sentinels
2. Close master server
3. Wait until the failover is done
4. Start master server again
5. There is no new Sentinel’s actions observed, although resurrecting should have been started according to the spec.

OS : windows server 2003 32bit
RAM: 8G (free)

But the redis-server.exe Out of memory when it's memory just to 2G.

the message is : "zmalloc: Out of memory trying to allocate 52 bytes"

Can developers compile redis for Windows via MinGW? It would be nice to not have to depend on Visual Studio.

On sds.c, line 485:

while(1) {
    /* skip blanks */
    while(*p && isspace(*p)) p++; <-------- This line fails with an assert when redis.conf has a UTF-8 bottom signure
    if (*p) {
        /* get a token */

The redis-benchmark using random does not initialize the random proc address

Running redis-benchmark.exe on Windows 8 almost always fails after PING test complete. Output:
====== PING_INLINE ======
10000 requests completed in 0.07 seconds
50 parallel clients
3 bytes payload
keep alive: 1

68.85% <= 1 milliseconds
100.00% <= 1 milliseconds
135135.14 requests per second

Could not connect to Redis at 127.0.0.1:6379: setsockopt(TCP_NODELAY): 10022

about once every 5 times it will continue after the PING test but will still fail later:
====== LPOP ======
10000 requests completed in 0.07 seconds
50 parallel clients
3 bytes payload
keep alive: 1

68.32% <= 1 milliseconds
100.00% <= 1 milliseconds
140845.08 requests per second

Could not connect to Redis at 127.0.0.1:6379: setsockopt(TCP_NODELAY): 10022

can't use pipe Mode

Currently the MSI installer just defaults to c:\program files.... with no option to change the path. Please give an option to select the path.

I'm trying to execute redis commands using nodeJs(node_redis from https://github.com/nitesh123/node_redis ) for windows

After dumping a key the encoded value returned has 10 extra bits appended to it.
On restore of dumped key with this encoded value these extra 10 bits are decoded and checked for its integrity

In the above image what i did is
set key value
dump key
which returned a encoded string value

and then on restore the first 2 bits of the value of footer variable is checked against REDIS_RDB_Version (which is 6) and since the value donot match it throws the checksum error. Please refer the below image

Hi,

By default, we apparently cannot install Redis Server 2.4/2.6 as a Windows service.

So, we would like to know if there is a way to install it as a Windows service?

Moreover, in a previous "issue", you were talking about RedisWatcherSvc as a solution:
#1

Our understanding is that RedisWatcherSvc is basically a watchdog that will restart Redis instance(s) if necessary.

When RedisWatcherSvc starts a Redis Instance, is it the Redis console application launched or Redis is running in background?

Thanks,

Thierry

Is it possible to install redis-server.exe as windows service? How?

Hi
When i tried running RedisInstWA.exe with source as redis-server physical path it threw an error saying "Path not found"
this is what i tried

  RedisInstWA.exe -source samples/redis-server.exe  -config samples -redisconfig samples -emu 

Then i tried giving url instead of source path and i threw an error saying "Did not find redisbin64.zip"
This is what i tried

  RedisInstWA.exe -source https://github.com/MSOpenTech/redis/archive/2.6.zip -x64  -config samples -redisconfig samples -emu 

and this is the error

redis-cli eval test.lua 1 2 fails to execute.

however redis-cli --eval test.lua woks.

why this part is not as per standard redis documentation?

SOCKET (cast to int) is used as an index into an array in src/ae_wsiocp.c.

Hello,

I would like to know if your Redis 2.4 version can be used in production (on a Windows 2008 Server 64 bits) or if it's only for development purpose?

Who can assist us if we have some issues using it?

Moreover, we would like to use the "Sentinel" feature with Redis 2.6. Do you known when a stable version will be available?

Thanks

[1936] 12 Aug 11:09:03.375 * DB saved on disk
[1936] 12 Aug 11:09:03.381 * Background saving terminated with success
[1936] 12 Aug 11:09:03.383 * cowBkgdSaveReset deleting 5 SDS and 7060 obj items
[1936] 12 Aug 11:09:28.803 # Out Of Memory allocating 743763 bytes!

the memory is enough and the memory of redis server is only 110MB

Please port Redis 2.6 to Windows. Redis 2.6 contains critical new features, such as LUA scripting for transactions.

I forked redis from antirez/redis.

and I also want to fork this project. but I failed it.

Do you have a plan to change this repo name?

Hi,

When I issue a SHUTDOWN command to the server I get the following assertion failure:

crt\src\close.c Line:46
(fh >= 0 && (unsigned)fh < (unsigned)_nhandle

To reproduce:

• Run redis-server.exe
• Run redis-cli.exe
• Enter SHUTDOWN in the client

MS 2.6.8-pre2 / x64 on Windows 8 x64:
redis 127.0.0.1:6379> set foo 2
OK
redis 127.0.0.1:6379> incrbyfloat foo 1.1
"3.1000000000000001"
redis 127.0.0.1:6379> incrbyfloat foo 5.0
"8.0999999999999996"
redis 127.0.0.1:6379> incrbyfloat foo -2.0
"6.0999999999999996"
redis 127.0.0.1:6379> incrbyfloat foo -1.0
"5.0999999999999996"
redis 127.0.0.1:6379> incrbyfloat foo -5.0
"0.09999999999999965"
redis 127.0.0.1:6379> incrbyfloat foo 2.0
"2.0999999999999996"
redis 127.0.0.1:6379> get foo
"2.0999999999999996"
And this is the main 2.6.9 on Centos x64
redis 127.0.0.1:6379> set foo 2
OK
redis 127.0.0.1:6379> incrbyfloat foo 1.1
"3.1"
redis 127.0.0.1:6379> incrbyfloat foo 5.0
"8.1"
redis 127.0.0.1:6379> incrbyfloat foo -2.0
"6.1"
redis 127.0.0.1:6379> incrbyfloat foo -1.0
"5.1"
redis 127.0.0.1:6379> incrbyfloat foo -5.0
"0.1"
redis 127.0.0.1:6379> incrbyfloat foo 2.0
"2.1"
redis 127.0.0.1:6379> get foo
"2.1"

When running redis-server using the --sentinel flag, the sentinel connects to master, but is unable to retrieve the list of slaves, nor other sentinels. This prevents the sentinels from acting as a quora, and promoting a slave when the master goes down.

I'm running some proof-of-concepts on my local machine to mimic a possible Redis HA topology. My local machine is Windows 7 x64; I've disabled (all profiles) the Windows Firewall, and shut down any network protection services running (i.e., Symantec,etc.)

I've built from the 2.6 branch (small change to remove the erroneous merge flags in redis-cli.c). I run the run_all.cmd (see below) from an elevated command prompt.

In order to reproduce the error, I've pushed my local test environment/configuration up to:
http://github.com/jstclair/redis-sentinel-win-demo

I've also included the original redis.conf (renamed in root as redis-default.conf) and sentinel.conf (sentinel-default.conf) for comparison.

When I run the run_all.cmd, after hitting space twice, the redis sentinels masters command returns (relevant parts):

21. "num-slaves"
22. "0"
23. "num-other-sentinels"
24. "0"
25. "quorum"
26. "3"

Watching the master server console, I see that it has accepted connections from everyone (it lists "6 clients connected (2 slaves)", but each sentinel merely cycles through:

[7360] 15 May 13:35:08.854 . +cmd-link master mymaster 127.0.0.1 6379
[7360] 15 May 13:35:08.855 . +pubsub-link master mymaster 127.0.0.1 6379
[7360] 15 May 13:35:13.854 # +sdown master mymaster 127.0.0.1 6379
[7360] 15 May 13:35:23.955 . +cmd-link master mymaster 127.0.0.1 6379

I'm not sure what's exactly going on; perhaps a missing pubsub channel?

Thanks!