microsoft / windows-appconsult-samples-desktopbridge Goto Github PK

I am trying to get https://github.com/microsoft/Windows-AppConsult-Samples-DesktopBridge/tree/main/Docs-ContextMenuSample/ExplorerCommandVerb going:

1. The 64 bit build configuration is set to teat warnings as errors
2. Building the x64 Release configuration fails to register with regsvr32:
   The module "ExplorerCommandVerb.dll" was loaded but the entry-point DllRegisterServer was not found.
   Make sure that "ExplorerCommandVerb.dll" is a valid DLL or OCX file and then try again.
3. Building the x64 Debug configuration registers with regsvr32 ok but no changes are seen in the File Explorer .txt file context menu even after restarting File Explorer?
4. Fixing the warnings in 1. does not fix 2. nor 3.

I am using Visual Studio 2019 16.10.4 and 64 bit Windows 10 10.0.19043.1110.

I tried to build the Blog-ModernizationStory solution but can't seem to get it working.

I've tried with the most recent VS Community 2019 (16.8.6 as well as 16.9.0 Preview 4.0) but always get this for the WAP project

and when removing that from the solution it builds but then throws this

Application log:

Activation context generation failed for "C:\temp\test\Windows-AppConsult-Samples-DesktopBridge-master\Blog-ModernizationStory\DynamicWindowsForms\bin\x64\Debug\netcoreapp3.1\DynamicWindowsForms.exe".
Error in manifest or policy file "C:\temp\test\Windows-AppConsult-Samples-DesktopBridge-master\Blog-ModernizationStory\DynamicWindowsForms\bin\x64\Debug\netcoreapp3.1\DynamicWindowsForms.exe" on line 2. 
The attribute internalKeyToken is not permitted in this context on element assemblyIdentity.

In the SourceGenerator example, MvvmGenerator, it makes it seem like public properties are fair game.

because it can handle public properties that are COMPUTED, I took it to mean that all public properties are also able to receive the [AutoNotify] attribute, and the propertyChanged would be correctly handled.

This is absolutely not the case, and so I would like for there to be a readme that addresses this so that other devs are not confused as to why the generator "isn't working".

The Readme should mention how only computed public properties are valid, and this is only the case if something is raising the property changed event for all the variables in the computation and the [AutoNotify] attribute is on it.

Normal public properties are not valid for usage with the [AutoNotify] attribute.

Even if the example had included this:

 public partial class MainWindowViewModel
  {
  	//Note, [AutoNotify] is Not going to be generated if you 
              //assign it to any normal public property, such as an AutoProperty. 
  	//for example, This :
  	//
  	//	[AutoNotify]
  	//	public string FirstName { get; set; }
  	//	[AutoNotify]
  	//	public string LastName { get; set; }
  	//
  	//Will NOT cause the MvvmGenerator to consider them as candidates
              // to generate PropertyChanged invocations for. 
  	//The MvvmGenerator is still meant primarily to be used with fields, 
              // but with the added benefit/exception of public computed properties being also usable. 

  	[AutoNotify]
  	private string _firstName;
  	[AutoNotify]
  	private string _lastName;
  
  	[AutoNotify]
      public string FullName => $"{FirstName} {LastName}";
  }

I would not have wasted a day thinking I'd gone mad. lol.

Thank you!

I was interested in seeing the initial blog post that was talking about the MvvmGenerator sample, and upon clicking the link to the blog I get a 404. https://docs.microsoft.com/en-us/archive/blogs/appconsult/tag/desktop-bridge

There are important files that Microsoft projects should all have that are not present in this repository. A pull request has been opened to add the missing file(s). When the pr is merged this issue will be closed automatically.

Microsoft teams can learn more about this effort and share feedback within the open source guidance available internally.

Merge this pull request