Git Product home page Git Product logo

ripgrep-prebuilt's Introduction

ripgrep-prebuilt

Build Status

Builds ripgrep on Azure Pipelines for multiple platforms, used by VS Code.

Details

Reads config.json to determine which repo to clone and which tag to check out. If the build was triggered by a tag, each job will package the build outputs and publish them as pipeline artifacts, and the last job will upload those artifacts to the Github release. The Github release is consumed by the vscode-ripgrep NPM package.

Contributing

This project welcomes contributions and suggestions. Most contributions require you to agree to a Contributor License Agreement (CLA) declaring that you have the right to, and actually do, grant us the rights to use your contribution. For details, visit https://cla.microsoft.com.

When you submit a pull request, a CLA-bot will automatically determine whether you need to provide a CLA and decorate the PR appropriately (e.g., label, comment). Simply follow the instructions provided by the bot. You will only need to do this once across all repos using our CLA.

This project has adopted the Microsoft Open Source Code of Conduct. For more information see the Code of Conduct FAQ or contact [email protected] with any additional questions or comments.

ripgrep-prebuilt's People

Contributors

andreamah avatar deepak1556 avatar microsoftopensource avatar msftgits avatar roblourens avatar rohan-shinde-98 avatar rzhao271 avatar svghadi avatar tylerleonhardt avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

ripgrep-prebuilt's Issues

Prebuilt provides debug builds

We recently noticed that our build size suddenly increased after updating dependencies. The reasons for this is a 40MB ripgrep application with debug information on Linux (other OSs not tested). I hope you can fix this issue and provide a release version without debug information. Thanks in advance!

$ file vscode-ripgrep/bin/rg
rg: ELF 64-bit LSB pie executable, x86-64, version 1 (SYSV), dynamically linked, BuildID[sha1]=153fc3eda21c189844e41173c5c07bd6738fde4c, with debug_info, not stripped

Edit: Target x86_64-unknown-linux-musl

Search function for vscode is failing on Power powerpc64le-unknown-linux-gnu enforces a minimum glibc

Type: Bug
Related: microsoft/vscode#179121, microsoft/ripgrep#24

The Search function fro Red Hat Dev Spaces is failing on Power and is giving no results found unless the files are open.

Had a look at the Outputs tab for Extension(Remote) with the Developer: Set Log Level set to Trace and this is the error.

2023-10-31 03:41:07.947 [debug] RipgrepSearchEH#search /checode/checode-linux-libc/node_modules/@vscode/ripgrep/bin/rg: /usr/lib64/glibc-hwcaps/power9/libc.so.6: version `GLIBC_2.29' not found (required by /checode/checode-linux-libc/node_modules/@vscode/ripgrep/bin/rg)
/checode/checode-linux-libc/node_modules/@vscode/ripgrep/bin/rg: /usr/lib64/glibc-hwcaps/power9/libc.so.6: version `GLIBC_2.33' not found (required by /checode/checode-linux-libc/node_modules/@vscode/ripgrep/bin/rg)
/checode/checode-linux-libc/node_modules/@vscode/ripgrep/bin/rg: /usr/lib64/glibc-hwcaps/power9/libc.so.6: version `GLIBC_2.32' not found (required by /checode/checode-linux-libc/node_modules/@vscode/ripgrep/bin/rg)
/checode/checode-linux-libc/node_modules/@vscode/ripgrep/bin/rg: /usr/lib64/glibc-hwcaps/power9/libc.so.6: version `GLIBC_2.34' not found (required by /checode/checode-linux-libc/node_modules/@vscode/ripgrep/bin/rg)

2023-10-31 03:41:07.948 [debug] RipgrepSearchEH#search No data from stdout
2023-10-31 03:41:07.948 [debug] RipgrepSearchEH#search No result from parser

There is a workaround for this issue by replacing the ripgrep version to the v13.0.0-4 and that seems to resolve the issue temporarily however would appreciate a Permanent fix.

I can see that there is a PR to fix this issue on arm. Can we add a fix for Power to it as well. Thanks any help would be appreciated.

Downloading ripgrep failed

I'm having some problems with yarn vscode and it looks like it's because I'm using a proxy, do you have any clues?

error /vscode/node_modules/vscode-ripgrep: Command failed.
Exit code: 1
Command: node ./lib/postinstall.js
Arguments:
Directory: /vscode/node_modules/vscode-ripgrep
Output:
Finding release for v13.0.0-4
GET https://api.github.com/repos/microsoft/ripgrep-prebuilt/releases/tags/v13.0.0-4
Deleting invalid download cache
Downloading ripgrep failed: TypeError [ERR_INVALID_PROTOCOL]: Protocol "https:" not supported. Expected "http:"

Bug on FUJITSU A64FX(ARM)

Hi VS Code developers,

I am using VS Code on a FUJITSU A64FX machine, and I found the search in VS Code doesn't work on my machine. I checked the ripgrep and got the following bug information:

[bshan@login1 bin]$ ./rg --version
<jemalloc>: Unsupported system page size
<jemalloc>: Unsupported system page size
memory allocation of 5 bytes failed
Aborted (core dumped)

Then, I download the ripgrep source code and compile it manually, and copy rp to node_modules/@vscode/ripgrep/bin.
Finally, it works.
Could you fix/update the configuration of the ripgrep-prebuilt of VS Code.
If you need any help on the Fujitsu machine, just let me know.

Thanks

Reduce package size with rust compile flags.

The vscode CLI uses these flags to reduce package size. https://github.com/microsoft/vscode/blob/9b8114e6b9e7fe6217def08b60e240172b12489a/cli/Cargo.toml#L75-L78

strip=true removes debug symbols
lto=true enables link time optimization
codegen-units=1 makes it link in a single progress, where it normally runs in multiple independent workers in parallel. Might make compilation a little slower.

It would be nice to incorporate them into ripgrep-prebuilt to reduce package size also.

`arm-unknown-linux-gnueabihf` enforces a minimum GLIBC

Related: microsoft/vscode#179121 (comment)

It seems like systems that use arm-unknown-linux-gnueabihf looks for GLIBC_2.29 despite vscode supporting lower GLIBC versions. This is since that prebuilt is still not statically compiled, so building it against ubuntu-latest likely increased the GLIBC version that it required from dynamically linked dependences.

We should try to make this prebuilt statically compiled by using the musl version, as we did with microsoft/vscode-ripgrep#34

ripgrep v14

ripgrep v14 has lots of improvements. It would be great if v14 becomes available here and other depending projects, such as vscode-ripgrep.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.