validator enhancements about qcodes HOT 4 CLOSED

Update: Same value error reproduces, when I use an int in a loop it breaks, setting directly by hand works. Changing the input to a float in my loop takes away the problem. Because the exception is so nondescript I do not know why it fails.

Calling directly from the command line (cell below it) runs fine.

from qcodes.

Huh, that's a very strange error. Any chance you can produce a self-contained version of this?

Numbers does explicitly accept both integers and floats - doesn't convert ints to floats though, the validator never actually manipulates the values, just tests them. I think this is OK, it's pretty rare, especially in python3, the ints will behave differently from an equivalent float if a float is expected.

I can definitely improve the error message though, great idea.

from qcodes.

As I make validate_all from #51, I'm noticing that we only ever call is_valid and then raise immediately afterward. Not sure why I did this; maybe I thought we'd want to use the False results without error, or maybe I just wanted more control over the error message; regardless, I'm thinking the better way to do this is to instead have a method Validator.validate(self, value, context) which raises the exception itself (could raise ValueError or TypeError) with a message that includes a context specified by the caller.

from qcodes.

Closed as solved (in some long ago unkonwn PR)

from qcodes.