Git Product home page Git Product logo

Comments (5)

thangleiter avatar thangleiter commented on August 16, 2024 1

Ah, apologies for not searching for an existing issue. I don't actually use the functionality, so I'm all for keeping Parameter simple.

I can open up a PR for validation in register_parameter, but it's only putting out one small fire compared to the proper solution in #5036.

from qcodes.

thangleiter avatar thangleiter commented on August 16, 2024 1

@thangleiter I think we should reopen since we have only resolved this partially? Do you agree

I guess it makes sense to keep it open for bookkeeping. The last of the examples above is indeed not fixed by #6084.

from qcodes.

jenshnielsen avatar jenshnielsen commented on August 16, 2024 1

Thinking a bit more about this my proposed solution is.

  • Add sweep and __getitem__ above to a new Sweeper class in qcodes-loop and update all of that pacakge to make use of this.
  • Cut a new release of qcodes-loop
  • Deprecate these two methods

from qcodes.

jenshnielsen avatar jenshnielsen commented on August 16, 2024

It should indeed be deprecated see #5036

__getitem__ and parameter.sweep (which already exists) are both remaining leftovers of qcodes_loop in qcodes that I have not yet found a clean way to get rid of without breaking that package.

We are not planning to introduce any sweep functionality into the parameter to use with qcodes.dataset but parameters can be sweep by passing them to LinSweep and friends. This choice is made since

  • The parameter class is already too complicated and does too many things
  • Having the sweeper externally gives greater flexibility in implementing different sweep strategies.

I however, agree that it would be great to have better validation in register_parameter to error early if setpoints is a ParameterBase subclass. A pr for that is most welcome.

from qcodes.

jenshnielsen avatar jenshnielsen commented on August 16, 2024

@thangleiter I think we should reopen since we have only resolved this partially? Do you agree

from qcodes.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.