Extend screen driver

Attach a SVG icon for robotis so that we can update the skin of this editor.

We've enable a compile service for you: codal2robotis

Update home page hero image

Hi, @pelikhan, @mmoskal.

Describe the bug
Although the member function of a specific class not implemented in codal-core was implemented in a class that inherited the class, MakeCode does not link the proper runtime HEX file.
Of course, these work without problems when using only the CODAL build system.

The CODAL code related to the previously modified Serial package or the newly added DYNAMIXEL worked well.
Is there anything different about the core package?

To Reproduce
Steps to reproduce the behavior:

1. Modify member function of CODAL Core Class
2. Commit & Push to GitHub.
3. pxt serve or pxt serve --localbuild
4. Write code at MakeCode (eg. MakeCode ROBOTIS)

forever(function () {
    serial.writeValue("V", pins.VOLTAGE.analogRead())
    pause(500)
})

5. Download & Upload to target board (The code has changed, so it must be compiled, not the cached hex file, but it is not recompiled. If you delete the "built/hexcache" folder and clear the browser's cache, it will be recompiled, but the hex hash value is the same.)
6. Look at the behavior of the board (The changed member function was not applied)

Expected behavior
I wrote it as a more specific example.

1. The getAnalogValue() function in Pin.h of codal-core is not implemented.
2. Therefore, we implemented getAnalogValue() in NRF52Pin of codal-nrf52.
3. We implemented to print 4444 instead of -1013(DEVICE_NOT_IMPLEMENTED) value.
4. Now it is applied. (We have confirmed that this compiles normally through various methods and creates a .hex file in the dockercodal or codal folder. We made sure that this compiles normally, such as by creating additional functions, inserting error codes or checking the .map file.)
5. Now, the value that was output as -1013 should be output as 4444. But...

Screenshots

• Before

int NRF52Pin::getAnalogValue()
{
    return DEVICE_NOT_IMPLEMENTED;
}

• After

int NRF52Pin::getAnalogValue()
{
    int data = 4444;
    return data;//DEVICE_NOT_IMPLEMENTED;
}

• But...
  

Desktop:

• OS: Windows10 Pro
• Browser: chrome / NAVER whale(based on chrome)
• Version: chrome 80.0.3987.149

Additional context

It is possible to tune the skin of the editor via many LESS variables. Do you already have a design in mind?

In general, you cannot move buttons around but you can device about colors and shapes (as long as it can be done in CSS).

<robotis-cm-550/pxt.json>

<screen-st7735/targetoverrides.ts>

<pxtarget.json>

result:

I created an image related block (using targetoverrides on screen--st7735).
And if don't put any items in bannedCategories like the image above, the block will be exposed.

[Issue]

After that, the image category was unnecessary, so I applied “image” to the forbidden category.
Then the "image" category was successfully removed, but I had the problem that the blocks I made were not exposed.

Does this issue occur when a class related to a category entered in bannedCategories is used in a block? If so, what should I do to expose the blocks I create and not the Image category?

Thanks in advance for your help.

Hi.

Can I change download message UI like microbit?

->

I tried with below codes to change body ("Move the ...") but not work.

And I tried with below. It works. Do I have to change pxt?
https://github.com/microsoft/pxt/blob/5531f0a3fe88242be6d4ce899c25ca3c61323ca6/webapp/src/cmds.ts#L82

thanks.

My Korean is unfortunately non-existent. Are you ok doing some kind of online meeting in English every week to track progress?

I clicked "... more" of "PINS" category on local PC.
But blocks are not refreshed like below.

Working fine on the website "maker.makecode.com".
Working fine on another local PC.

Hi.

How does it work to display the bread board in simulator area.

for example...
The BB is displayed only when the block is connected in case of LCD extension.

But The BB is displayed by adding Game extension. (even though blocks are not connected.)

We do not want to have to maintain multiple version of a CODAL layer for NRF52. Please use https://github.com/lancaster-university/codal-nrf52

Is it possible to make a triangle or star shaped buttons by modifying the data of "buttons" of board.json in Makecode?

Or do I need to parse svg data like lego or brainpad way to create simulation ui like button, screen, motor etc.

Thanks.

Hi, @pelikhan.

Below is the question I asked about the GitHub workflow I asked you after you gave me write permission previously.

Can you explain how you would like to collaborate with us about the following?

Hi, @pelikhan

During the development period, would you like to proceed with the way we merge PR when you approve it?
Or, would you only want to make a review if we requested it? (That is, if the PR does pass the CI if we did not request a review, are we merging without your review?)

Also, in the case of release, what do you want to do?

All of these questions are about the development stage.

Originally posted by @OpusK in #28 (comment)

Do you need the SAMD stuff? Remove all the project you do not need.

@pelikhan,

The issue below (#23) has not been resolved.
And even though it is declared as below in shims.d.ts, it still shows 'of undefined', not 'of dynamixel' ...
Strangely, despite this error, the board works fine.

declare namespace dynamixel {
    /**
     * Opens a DYNAMIXEL communication driver
     */
    //% shim=dynamixel::internalCreateDXLDevice
    function internalCreateDXLDevice(tx: DigitalInOutPin, rx: DigitalInOutPin, dir: DigitalInOutPin, id: int32): DynamixelDevice;
}

And, the below .png file is the example code with the above error.

Originally posted by @OpusK in #23

What you need to do is to implement a javascript version of the C++ call.

I think I wrote a shim through the code above as per the manual.

See serial shim: https://github.com/microsoft/pxt-common-packages/blob/76fe391800fd44825839573da32cdca3ca5076ed/libs/core/sim/serial.ts#L40

Your link is not a shim, but a sim file (for simulation). Isn't it right to refer to shims.d.ts for shim?
Of course, I haven't implemented simulation yet, so when implementing sim it's right to refer to the file you gave the link to.
I've also seen errors related to simulation, so I know I need to implement sim someday. However, the current error is about shim.

I think it was implemented properly except for simulation, isn't it?
Like docs, should it be uploaded to the cloud to be recognized as a namespace called dynamixel, not undefined?
If so, please merge. I will implement the simulator later.

Originally posted by @OpusK in #23

For example
For categories, is it possible to selectively expose only the desired category, not all categories included in the "dependencies":{ } in the pxt.json file?

I have "block_1", "block_2"
I want to display "block_1", "block_2" in "category_1" for "robot_1".
I want to display "block_1" in "category_1", "block_2" in "category_2" for "robot_2".

Is it possible to create common blocks and display them in different category of different robots?

Now I made the code as shown below.

Set "dependencies: file:../robot_1_blocks" for "robot_1".
Make a ".ts file" in "robot_1_blocks" and defile "namespace c1 {b1, b2}"

Set "dependencies: file:../robot_2_blocks" for "robot_2".
Make a ".ts file" in "robot_2_blocks" and defile "namespace c1 {b1}, namespace c2 {b2}"

Thank you.

HI,

How can I hide some blocks in predefined(?) category?

for example,
do not show "repeat (4) times" and "pause until " blocks.
show others.

Thank you.

Hi,

When I delete a project in Editor, It shows following message.
What should I do?

https://drive.google.com/file/d/1r855a0YfpovR9NKn37MYKNdtHisVBAEL/view?usp=sharing

and

https://drive.google.com/open?id=1wsJU4dAlwPeTaoBymS8hZTEem0eoQvOk

Thanks.

Hi, @pelikhan

This is not yet PR on Microsoft.
Currently, the base-code merge operation is pending, so I'm asking about the result from ROBOTIS-GIT. (This is what happened in #3 earlier.)

The link below is a PR from ROBOTIS-GIT.

• ROBOTIS-GIT#2

And below is the result.
https://github.com/ROBOTIS-GIT/pxt-robotis/runs/486499666

This problem does not exist when the --localbuild option is used, but if we use the pxt serve command without any options we get this error.
Since it's an HTTP 412 error, it looks like something needs to be configured in the cloud running build. Is there anything we need to fix in pxt-robotis? Or is it something Microsoft has to deal with?

Hi,

To set up a category to display "On Start" block.
I found this..... "onStartNamespace": "loops" in "pxtarget.json"
It shows "On Start" block in "loops" category.

Can I set different categories to display "On start" block.
for example,
"basic" category for "Robot A".
"loops" category for "Robot B".

Thank you.

Describe the bug
If I want to use ILI9341 LCD (320x240), the value of img->pixLength() in updateScreen() in libs/st7735---screen/scree.cpp is 38400. But it should be 9600.

To Reproduce
Steps to reproduce the behavior:

1. Set LCD related parameters as follows in config.ts. (If I use parameters of ST7735, LCD works fine)

export const PIN_DISPLAY_SCK = DAL.P0_1;
export const PIN_DISPLAY_MISO = DAL.P0_24;
export const PIN_DISPLAY_MOSI = DAL.P1_2;
export const PIN_DISPLAY_CS = DAL.P0_5;
export const PIN_DISPLAY_DC = DAL.P1_5;
export const PIN_DISPLAY_RST = DAL.P1_3;
export const PIN_DISPLAY_BL = DAL.P1_7;

export const DISPLAY_TYPE = 9341
export const DISPLAY_WIDTH = 320
export const DISPLAY_HEIGHT = 240
export const DISPLAY_CFG0 = 0x08
export const DISPLAY_CFG1 = 0x0010ff
export const DISPLAY_CFG2 = 50

2. Add "game": "file:../game" to "dependencies" category of pxt.json.
3. Then from the makecode editor, I can use [Scene] category. If I use [Set background image to ()] block and download uf2 file to my board, my board blinks LED irregularly.
4. I found it entered target_panic(PANIC_GC_TOO_BIG_ALLOCATION). It is because it satisfies if (numbytes > GC_MAX_ALLOC_SIZE) condition in void *gcAllocate(int numbytes) in libs/base/gc.cpp. The value of GC_MAX_ALLOC_SIZE is 16k while numbytes is 38416.
5. If I change GC_MAX_ALLOC_SIZE to larger value, like 64k, then this panic doesn't happen.
6. But target_panic(PANIC_SCREEN_ERROR) happens. Because img->width() * mult != display->width condition and img->height() * mult != display->displayHeight condition are satisfied in updateScreen() of libs/st7735---screen/scree.cpp.
7. Followings are related values:
   For the explanation why img->pixLength() should be 9600, please refer to lancaster-university/codal-core#118. This PR is closed but I think the calculation result is correct.

display->doubleSize : 1
mult : 2
img->bpp : 4
img->width() : 320   ---> it should be 160, since actually use LCD as 160x120 resolutuion
img->height() : 240   ---> it should be 120, since actually use LCD as 160x120 resolutuion
display->width : 320
display->height : 240
img->pixLength() : 38400 ---> it should be 9600, since actually use LCD as 160x120 resolutuion

8. I think if the image buffer size is corrected, the PANIC_GC_TOO_BIG_ALLOCATION panic will not happen.

How can I expose only the items I want when exposing extensions?

For example:
If you look at the capture below, libs / base, libs / core, etc. are included in the extension and exposed.

However, as shown below, the extension is not exposed in the case of Lego. Which part should I change? Or is there a reference you can refer to?