Git Product home page Git Product logo

insiderdevtour18-labs's Introduction

Contributing

This project welcomes contributions and suggestions. Most contributions require you to agree to a Contributor License Agreement (CLA) declaring that you have the right to, and actually do, grant us the rights to use your contribution. For details, visit https://cla.microsoft.com.

When you submit a pull request, a CLA-bot will automatically determine whether you need to provide a CLA and decorate the PR appropriately (e.g., label, comment). Simply follow the instructions provided by the bot. You will only need to do this once across all repos using our CLA.

This project has adopted the Microsoft Open Source Code of Conduct. For more information see the Code of Conduct FAQ or contact [email protected] with any additional questions or comments.

insiderdevtour18-labs's People

Contributors

cbarkerms avatar ericahlstrom avatar fpelaez avatar mccoykillian avatar michael-hawker avatar microsoft-github-policy-service[bot] avatar microsoftopensource avatar msftgits avatar rbermejotokiota avatar tklarslynch avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

insiderdevtour18-labs's Issues

Graph - Typos in index file

"title: Drive user engagement across all your devices with Microsoft Graph"

  • Should each word be capitalized?

"In this lab your learn what is graph, how use it and the possibilities that offers us. You write C# code and see tthe results in UWP App."

  • Phrasing is a bit off here as well.

"title: Integrating MS Graph into you app"

PWA: Grammar

"In these labs you will be introduced how to build a Progressive web application".

would be better as:

"This lab will explain how to build a Progressive Web App (PWA)".

Graph - OneDrive Console App - Not Seeing Files

https://review.docs.microsoft.com/en-us/labs/insiderdevtour2018/graph/index?branch=insiderdevtour%2Fdev&ocid=idt_labs_cta_web2lab_graph&tutorial-step=2

In the Get call to Get all items in OneDrive section, I'm not seeing any onedrive items when I run the sample:

image

Graph Explorer earlier showed me items with this call:
https://graph.microsoft.com/v1.0/$metadata#users('<userid>')/drive/root/children

So, I'm not sure what's wrong, the request doesn't contain any items:

image

Also, should these calls be using the async method pattern rather than .Result?

Modernize - change order of sections

Distribution and versioning should come first as some Windows 10 APIs require a package identity.

  1. Distribution and versioning
  2. UI modernization
  3. Windows 10 APIs - Toast
  4. Adaptive cards

Graph - Link in Getting Started doesn't point to Console Project

https://review.docs.microsoft.com/en-us/labs/insiderdevtour2018/graph/index?branch=insiderdevtour%2Fdev&ocid=idt_labs_cta_web2lab_graph&tutorial-step=2

Under 'Sample API calls' and Create a console app it doesn't link to the project directory like the previous sample did. It should link here I'm assuming: https://github.com/Microsoft/InsiderDevTour18-Labs/tree/master/graph/Microsoft.Graph.HOL.ConsoleBase

It could be useful to put the git clone link in the documentation as well?

(Also, should this section be broken up a bit. We do the app setup, then we do this separate investigation in the graph explorer, and then we go to the console app...?)

Office 365 - adjust structure

Adjust .md/.yml files to give the following:

"Exercise 1: Create a Team" (it's own .md file - and remove the "Exercise 1" numbering)
"Graph APIs" (it's own .md file - and remove the "Exercise 2" numbering)
"Canvases across Office 365" (it's own .md file)

MixedReality: Terminology

The term "HMDU MR experience" is used in the Introduction. HMDU is not a recognized term. Even if it was meant to be HMD (for Head Mounted Display), that is not recommended. "Mixed Reality Headset" is the preferred term.

BTW, do not google HMDU. This is a Pri 0 Policheck issue.

Mixed Reality - Issues with Visual Studio Build instructions

The instructions state:

To deploy the project to an immersive headset.
Navigate to the Build Window: Mixed Reality Toolkit -> Build Window.

Click on Open in Visual Studio.

Note: If Unity says there is no "open project solution" and asks if you still want to build, select "Yes, 
Build"

Navigate to Build -> Configuration Manager in Visual Studios or use the drop-down at the top of the 
page and select x64 in your platform options.

In the debug toolbar, select "Local Machine" as the target (or remote device if you are pushing to 
another machine).

Run the app by hitting play.

I ran into the following issues:

Click on Open in Visual Studio.

Visual Studio did not open for me. I had to click on Open in Visual Studio again after the export of the project completed.

Run the app by hitting play.

If you hit play you will get build errors with several missing methods. Selecting Build Solution from the Build menu resulted in a successful build

PWA: Grammar

  • Note *
    I am working through the content, and will submit a PR with some grammar improvements.

This lab really needs a good copy edit. Here are some suggestions for the PWA Foundations page.

"Technologically speaking" - remove this text.

"Standard Manifest: The site should be controlled by a W3C manifest that determines the experience and behavior of your PWA"

would be better as

"Standard manifest file: The site requires a manifest file to define the features and behavior of the PWA. The file follows the W3C standard".

"Since at their core PWAs are still websites, they’re already supported on numerous platforms like Windows, Android, iOS, and Mac. They can be enhanced over time to function more like native apps, and even use native APIs, on supported platforms. This can turn your website into a Rockstar app by combining the best of the web and native application worlds. Plus, the work of turning your website into a PWA can also improve your website’s experience."

would be better as:

"PWA apps are still websites, and are therefore supported on most platforms including Windows, Android, iOS and Mac. They can enhanced to function more like native apps, and even use native APIs on support platforms. A PWA can combine the best features of a web site and a native application."

i.e. removing "Rockstar app"

"PWAs aren't very different that a web application, when you access to a PWA you will see the same as a simple web application. After complete this lab, your PWA will looks like this:"

ok, I give up :-) This sentence alone has about 10 issues :-)

Mixed Reality - Typos

In 4. Environment Setup (VR)

"Next, we need to choice an experience scale" - choice should be choose

"Select the MixedRealityCameraParent in the hierarchy and change the Transform -> Position -> Y to 0.8. This will move the camera to a natural eye level." - The image shows 0.0 for the Transform -> Position -> Y. It should show 0.8.

ML - add missing pictures

There are broken pictures/missing images scattered throughout the different pages. Right now there are small black boxes with "x"s in their places.

Flow from Creating Team page to Graph not smooth

At the end of the “Exercise 1: Create a Team” page, you have a section on “Graph APIs” – It doesn’t seem to flow naturally from the previous point (number 11). Can you please be a bit more descriptive about what you will do next – example: “read on to see what a developer can do with the Microsoft Graph”.

PWA: Publish your PWA and PWA on Windows

Publish your PWA

The instructions say "Pull the "manifest.json" file and the "images" folder that are inside of the PWA folder "
It is unclear what "pull" means in this context. Delete? Copy?

PWA on Windows
Broken images.

Some later pages in the git repo don't appear to be published at all, at least they aren't in the TOC. Maybe by design, as they look a little rough.

Graph UI Lab - Can't Connect?

Was on the last step of https://review.docs.microsoft.com/en-us/labs/insiderdevtour2018/graph/index?tutorial-step=2&branch=insiderdevtour%2Fdev

image

I'm getting this can't connect to service after typing in my username and 'getting redirected to organization sign-in page' (the console app is still working fine, as does logging in a browser).

If I close the window, the page contents has a Microsoft.Identity.Client.MsalException: WAB authentication failed followed by a FileNotFoundException.

BuildingTeamHub - download location incorrect

For the following:

"Click on the Test and Distribute selector from the left panel under Distribute and then the Export button to download and save the LunchMenu.zip manifest file to your desktop."

The download location was the "Downloads" folder.

Mixed Reality - MRTK default project settings different

The docs show this for the default settings:

image

My fresh install of Unity 2017.4.2 and fresh import of the Holotoolkit.unitypackage displayed this:

image

Note: Use Toolkit-specific InputManager axes was NOT enabled by default in my fresh install.

It would be better to state the exact settings you require to be selected.

Also user should click Apply

Mixed Reality - Images are different than installed version of MRTK

I am getting different options from the images in the docs. The docs show this for the "Apply Mixed Reality Scene Settings"

image

The Holotoolkit.unitypackage from the InsiderDevTour18-Labs shows this:

image

Did you use the same version of the Holotoolkit.unitypackage when you created the docs?

Graph Creating event in outlook calender issues

  1. Helpers/OutlookHelper.cs SetAppintment should be SetAppointment. Correct spelling in code and the lab as well.

  2. In the app, both Date Time say Start. One should say Date Time Stop. Also update image in lab.

  3. After scheduling event in app, it creates the event on the outlook calender but the subject is incorrect. It doesn't show the subject provided in the app, it always creates an event with Subject "Subject"

Graph Lab- Doesn't indicate which project to open

In this section-
Choosing the project template
Now we will download the UWP application. We will use it and configure it with the Application Id and the Redirect Uri that we saved before.

It asks to download project from here. But there are two projects under graph folder. Doesn't indicate which project to open.

Mixed Reality - No Scenes are present error when "Open in Visual Studio"

When following these instructions:

To deploy the project to an immersive headset.
Navigate to the Build Window: Mixed Reality Toolkit -> Build Window.
Click on Open in Visual Studio.
Navigate to Build -> Configuration Manager in Visual Studios or use the drop-down at the top of the page and select x64 in your platform options.
In the debug toolbar, select "Local Machine" as the target (or remote device if you are pushing to another machine).
Run the app by hitting play.

I get the following error:

image

Need instructions on how to make sure the scene is added to the build.

Get 403 Forbidden when navigating backwards from lab

image

Repro:

  1. Start InPrivate session
  2. From labs page
  3. Click Graph's Start Lab
  4. Login
  5. Let doc page load
  6. Hit back button in browser.

Expected

Return to lab selection page

Actual

Get 403 forbidden page as in image above.

Not sure if this matters since there's permissions on it currently, but figured I'd report it, just in case.

Graph - English grammar / phrase check required

Examples:

MS Graph => either "Graph" or "Microsoft Graph"
"In UWP project go to Helpers/OneDriverHelper.cs" => "In the UWP project go to …"
"Integrating with office" => "Integrating with Office"
"Advance app feature" => "Cortana integration"

Graph Lab Split up Integrating Graph with you app section

I think it'd be nicer if each task in the integration section was broken up on it's own page. This way you could move the Timeline paragraph from the Introduction page as the intro to the Timeline activity. I think it'd make more sense there in context with performing the activity right after. Otherwise, you read about timeline in the intro and will forget about it by the time you get to the activity.

  • Using OneDrive for app data storage
  • Writing data to the MS Graph
  • Integrating with office
  • Writing to the Timeline (I'd probably put the deeplink in here and then end with the pick-up where you left off as all part of this same module, as they're all interconnected)

MixedReality: Terminology & Missing Lab Files

In the "Exporting a WinMR UWP app from Unity" section:

  • "WinMR" and "Win MR" are not the correct terms. Use Windows Mixed Reality.

  • The first step requires importing files from the "lab files". There is no link to these files, and so I am
    blocked from getting any further.

  • Use of the phrase "super simple" is discouraged. It may be "super simple" to the author, but not the person trying to do it.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.