Comments (10)
from git.
This seems to be caused by a bug in cURL where it does not handle the --write-out
option correctly:
$ sh -x $(which git-update-git-for-windows)
+ use_recently_seen=no
+ test --test-version-compare '!=' ''
+ update_git_for_windows
[...]
+ echo 'Update 2.45.2.windows.1 is available'
Update 2.45.2.windows.1 is available
++ http_get https://api.github.com/repos/git-for-windows/git/releases/latest
++ url=https://api.github.com/repos/git-for-windows/git/releases/latest
+++ mktemp -t gfw-httpget-XXXXXXXX.txt
++ output=/tmp/gfw-httpget-ruMLqjGG.txt
+++ curl --silent --show-error --output /tmp/gfw-httpget-ruMLqjGG.txt --write-out '%{http_code}' https://api.github.com/repos/git-for-windows/git/releases/latest
curl: (43) A libcurl function was given a bad argument
++ code=000
++ return 43
+ releases=
+ return
If I remove the --write-out '%{http_code}'
option, the command succeeds (but of course the HTTP code is no longer reported).
curl/curl#13845 looks closely related, and I am currently building cURL v8.8.0 with curl/curl@9aa1d41 applied on top, to see whether this fixes the bug.
from git.
I am currently building cURL v8.8.0 with curl/curl@9aa1d41 applied on top, to see whether this fixes the bug.
Sadly, it does not address the bug.
Aha! I managed to test with the original DLL the entire time because I failed to realize that the custom build I ran in place would pick up /mingw64/bin/libcurl-4.dll
instead. Once I overwrite that with the just-built binary, it does fix the bug!
from git.
I am currently building cURL v8.8.0 with curl/curl@9aa1d41 applied on top, to see whether this fixes the bug.
Sadly, it does not address the bug.
from git.
Reopening until new release bits can be generated.
They are generated as we speak ;-)
from git.
I confirmed this worked for me, too. In my opinion, this issue can be closed when 2.45.2.vfs.0.1 is available as a pre-release, to match the exposure of 2.45.2.vfs.0.0.
from git.
Reopening until new release bits can be generated.
from git.
NORTHAMERICA+dstolee@stoleedesk2023 MINGW64 ~
$ git update-microsoft-git
curl: (43) A libcurl function was given a bad argument
NORTHAMERICA+dstolee@stoleedesk2023 MINGW64 ~
$ git version
git version 2.45.2.vfs.0.1
Doesn't seem to have stuck.
from git.
Doesn't seem to have stuck.
Indeed. I had to kicked off another sync
run in git-sdk-64
that updated curl to the -2 version, and then I re-ran the windows_pkg
job. The release workflow run is now completing, and I will test it immediately once it's done.
from git.
Now, that's better:
There's room for improvement (Portable Git should decline to run update-git-for-windows
, for example), but the bug is gone.
from git.
Related Issues (20)
- microsoft-git cask returns a 404 in the latest version of Git
- `git for-each-repo` stops on non-existent repo (Windows?) HOT 3
- git-maintenance doesn't work with git-credential-manager & pass HOT 4
- Steps when a scalar repo becomes corrupted
- Broken link in README
- git commit take a long time
- microsoft-git version 2.44.0.vfs.0.1 is broken on Mac HOT 4
- microsoft/git: review use of homebrew libintl.a
- winget deployment error (as of v2.44.0.vfs.0.2) HOT 4
- Release for v2.44.0.vfs.0.3 ? Patch for sparse-checkout crashes HOT 3
- Some scalar clones are putting GVFS packs in local object dir instead of shared object dir HOT 6
- Git reset --mixed HEAD~1 does not leave modified files in working tree
- `git update-git-for-windows` fails with curl error in v2.45.2.vfs.0.0 HOT 1
- git difftool with visual editor takes 4.5 seconds to open next file HOT 1
- status: Hydration percentage not printed when gvfs status cache is used HOT 2
- Scalar/GVFS not working on latest MacOS (Sequoia) HOT 7
- WSL: Ubuntu 20.04: Broken install for git 2.45.2.vfs.0.2 - missing libc dependency on clean install HOT 6
- v2.45.2.vfs.0.2: performance regression in pathspec checkouts HOT 1
- multi-pack-index expiration ineffective due to many pack-files keeping small object counts HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from git.