Comments (6)
The agents in question are actually OMR-based (and technically Server 2022 instead of Win11). We have 1JS agents too, but haven't dug in there because they aren't impacted like our OMR agents are.
from git.
I figured this one out. When running scalar clone
initially, we clone by specifying a path like c:\foo
, with the problem itself being the lowercase c
. The lowercase c
persists itself all the way through into the repo's config:
[gvfs]
sharedCache = c:\\.scalarCache/id_ba47400f-eebe-4850-a8bf-ef694ef81414
This becomes problematic in this code, which uses strcmp
instead of something like stricmp
:
Lines 326 to 331 in b68812e
odb->path
above uses C:
instead of c:
, the comparison doesn't match, and it falls back to .git/objects
.
from git.
A possible direction to be as safe as possible is to update the
incremental-repack
maintenance step to move objects from.git/objects
into the shared object cache.
My major concern about this strategy is that .git/objects
can very well contain objects that have not originated from the remote repository, and one single ill-considered re-creation of the shared object cache might very well wipe out objects that will now be irretrievably lost.
from git.
@AtOMiCNebula great find! This strcmp()
should be replaced with fspathcmp()
. Would you mind opening a PR that makes it so?
from git.
One thing @AtOMiCNebula pointed out is that we want to make sure that users in this state are getting into a better state when the config is parsed correctly.
A possible direction to be as safe as possible is to update the incremental-repack
maintenance step to move objects from .git/objects
into the shared object cache. Move packs wholesale to keep their prefetch-<timestamp>...
names. This could be a helpful feature, anyway, since the local object store isn't being repacked in Scalar clones with a shared object cache.
from git.
I created #660 to fix this.
from git.
Related Issues (20)
- Google.com
- unable to normalize alternate object path HOT 2
- git fetch --depth 1 is not working HOT 4
- How to slim down .scalarCache? HOT 8
- git pull takes a long time
- microsoft-git cask returns a 404 in the latest version of Git
- `git for-each-repo` stops on non-existent repo (Windows?) HOT 3
- git-maintenance doesn't work with git-credential-manager & pass HOT 4
- Steps when a scalar repo becomes corrupted
- Broken link in README
- git commit take a long time
- microsoft-git version 2.44.0.vfs.0.1 is broken on Mac HOT 4
- microsoft/git: review use of homebrew libintl.a
- winget deployment error (as of v2.44.0.vfs.0.2) HOT 4
- Release for v2.44.0.vfs.0.3 ? Patch for sparse-checkout crashes HOT 3
- Git reset --mixed HEAD~1 does not leave modified files in working tree
- update-git-for-windows seems to be broken on 2.45.2.vfs.0.0 HOT 10
- `git update-git-for-windows` fails with curl error in v2.45.2.vfs.0.0 HOT 1
- git difftool with visual editor takes 4.5 seconds to open next file HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from git.