Git Product home page Git Product logo

Comments (5)

derrickstolee avatar derrickstolee commented on May 27, 2024

Hi @shalinikhare27, thanks for the report!

This definitely seems like a case where the installer is not behaving the way that you expect. The microsoft/git fork inherits its installer from git-for-windows/git, so any change would need to happen in that project (and probably specifically in git-for-windows/build-extra).

One thing that would help us investigate this concern is how winget communicates the --disable-interactivity flag down to the installer. Somehow we know to not display the wizard, so some amount of integration already exists. It just hasn't been wired down to these kind of pop-up error messages.

It is important to note is that this prompt is communicating a failed installation procedure, so any integration to prevent the pop-up will still need to write an error to stderr and return a failure.

from git.

shalinikhare27 avatar shalinikhare27 commented on May 27, 2024

@derrickstolee - yes, ideally we want it to respect the --disable-interactivity flag and write an error to stderr. This is important when we run certain installations in non-user context where prompts are meaningless. We want to just exit with a failure. Please let me know if I can provide any other data to debug this.

from git.

derrickstolee avatar derrickstolee commented on May 27, 2024

I think I found the way to do it, but it will require some manual testing.

from git.

shalinikhare27 avatar shalinikhare27 commented on May 27, 2024

@derrickstolee How can I test this on my end?

from git.

derrickstolee avatar derrickstolee commented on May 27, 2024

@shalinikhare27: Sorry for the delay in updating this issue, but the git-for-windows/build-extra fix ended up not being needed since there is a way to fix it via updating the winget manifest.

There are instructions in the PR description of how to test this locally, without needing any changes to the microsoft/git release assets. I've tested it myself and as soon as that PR is merged by the winget team this issue will be fixed.

from git.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.