I'm looking to onboard this to microsoft/netperf to grab state for every run, and upload it with the other logs, but when this is run there are effectively two copies of the data in the output, raw and compressed (zip). I would like two additional command line options:

• -RawOutputOnly - which disables the compression step.
• -CompressedOutputOnly - which deletes the raw output directory after it has been zipped.

New execution option necessary for Azure Hosts

• Identify a way for execution to be constrained to a selected set of CPUs. This is necessary to ensure that diagnosis does not disrupt Guest/Container workloads.

Two options:

1. Ideally only using Host Cores for execution.
2. Identify a way to throttle the execution such that it doesn't consume 100% CPU.

1. When we enable Network Debug, Network adapter is renamed to "Local Area Connection* 1"
2. if wild card char is observed, get-netview.ps1 fails to run.

Get-NetAdapterQos -Name "Ethernet 2" -IncludeHidden -ErrorAction SilentlyContinue | Format-List -Property *
New-Item : Illegal characters in path.
At C:\Users\Administrator\Desktop\Get-NetView.PS1:651 char:5

• New-Item -ItemType directory -Path $dir | Out-Null
  

• ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  

  • CategoryInfo : InvalidArgument: (C:\Users\Admini...Network Adapter:String) [New-Item], ArgumentExceptio
    n
  • FullyQualifiedErrorId : CreateDirectoryArgumentError,Microsoft.PowerShell.Commands.NewItemCommand

Processing: pNic.8.Local Area Connection* 1.Microsoft Kernel Debug Network Adapter

Hi all.
I don't know, is Get-NetView working ok with any localization of Windows desktop?
So I get the following result:
PS D:\PS> netsh advfirewall show allprofiles
????????? ??????? ??????

????????? ????????
???????? ??????????? BlockInbound,AllowOutbound
LocalFirewallRules ?/? (?????? ????????? GPO)
LocalConSecRules ?/? (?????? ????????? GPO)
and so on.

I know this is a pretty big ask. As I mentioned in #72, I am looking to leverage this in our netperf automation; which is cross-platform. It would be great if we could start (small) standardizing collection on Linux/Ubuntu in addition to Windows.

On Azure Hosts (or any similar live system), we to need to avoid spiking CPU for an extended duration to avoid impacting the service. -BackgroundThreads 0 option will minimize the "magnitude" of CPU usage, so the only option is to spread the CPU usage over time. Adding a delay between command executions is one way to do this.

Multiple vNics can have the same name, so this won't always work.

Execution time display requires column alignment {0,6:n0} or similar.

(35 ms) Stop-NetEventSession NetRundown (31 ms) Remove-NetEventSession NetRundown
(171 ms) netsh dump
(55 ms) netsh interface ipv4 show icmpstats
(54 ms) netsh interface ipv4 show ipstats
(59 ms) netsh interface ipv4 show tcpstats
(62 ms) netsh interface ipv4 show udpstats
(57 ms) netsh interface ipv6 show ipstats
(54 ms) netsh interface ipv6 show tcpstats
(56 ms) netsh interface ipv6 show udpstats
(63 ms) netsh -?
(70 ms) netsh trace show scenarios
(11 ms) Get-ChildItem -Path C:\DELETEME\msdbg.WORKSTATION -Exclude Get-NetView.log -File -Recurse | Get-FileHash -Algorithm SHA1 | Format-Table -AutoSize | Out-String -Width 4096
(2 ms) Get-FileHash -Path "C:\DELETEME\Get-NetView.ps1" -Algorithm SHA1 | Format-List -Property * | Out-String -Width 4096

I have some changes regarding Chelsio Nic logs collection. Need a way to push changes to this repository.

1. Avoids possible race condition between copy and log write.
2. Includes format information for correct rendering of events.

Hi!

Since Start-Transcript outputs to "$OutDir\Get-NetView.log", when stopped, host output points to $OutDir. Since the log actually gets moved to "$OutDir_Logs", users aren't aware of where to go for the actual Get-NetView.log.

For potential mitigation, can think of two options:
1)
Pipe Stop-Transcript to Out-Null;
After moving the file, Write-Output your own message pointing to "$logDir\Get-NetView.log" in the try/catch blocks for Stop-Transcript.
2)
Define $logDir in the "Initialize" function instead of "Completion";
Change the Path for Start-Transcript to "$logDir\Get-NetView.log";
Remove Move-Item from the Stop-Transcript try block.

Without knowing what else could break by moving things in option #2, I'd suggestion option #1.

Line  | Code
----- | ------------------
2648  | Stop-Transcript | Out-Null
2649  | <...>
2650  | Write-Output "Transcript stopped, output file is $logDir\Get-NetView.log"

Essentially, don't use MaxThreads, or modify MaxThreads such that a value of 1, means just one thread is used instead of the current base (1) + MaxThread (1) = 2 execution threads.

The latest version of Get-NetView are not running on hosts that have PowerShell running in Constrained Language Mode.
So if you use Windows Defender Application Control (WDAC), formerly known as Code Integrity this will not run.
An earlier version included in SDDCDiag is running ( 2018.05.03.0m)

Would it be possible to evaluate the possibility of having Get-NetView respecting Constrained Language Mode ?

(sorry if this is the wrong place for these kind of request)

To workaround: check REG setting first at the four script locations calling Get-NetAdapterStatistics

$AnyConnectKey = "HKLM:\SYSTEM\CurrentControlSet\Services\vpnagent"
if (-Not (Test-Path $AnyConnectKey))
{
if ($Global:noNetAdapters -ne $true) {
$file = "Get-NetAdapterStatistics.txt"
[String []] $cmds = "Get-NetAdapterStatistics -IncludeHidden | Sort-Object InterfaceDescription | Format-Table -Autosize | Out-String -Width $columns",
"Get-NetAdapterStatistics -IncludeHidden | Sort-Object InterfaceDescription | Format-Table -Property * -Autosize | Out-String -Width $columns"
ExecCommandsAsync -OutDir $dir -File $file -Commands $cmds
}
}

Current -ExtraCommands parameter is preprocess only, there should be an additional parameter that executes after data collection.

The Get-VMNetworkAdapter* cmdlets reference the DeviceID to try to identify the adapter, but the DeviceID only exists in the output of the Get-VMNetworkAdapter cmdlet. I submitted a PR (#69) that allows the cmdlets to correctly reference the adapters and get the required data.

I was just trying to migrate to calling this via aka.ms/Get-NetView and it didn't work. So I just checked and it doesn't exist, as the readme docs suggest.

In many scenarios (Exchange Online servers) we need to be very careful about the kind of information that is collected. No PII should be removed from the machines by default. If we (networking teams) want to standardize around this tool, we need to make sure we don't collect stuff we shouldn't in those environments.

@dl2n and the Get-SDDCDiagnosticInfo team would like to integrate Get-NetView more fully. However Get-SDDC often runs remotely and would need Get-NetView to be able to do so as well.

Some systems have a large number of ETW events, in such cases it is impractical to collect the entire log.

There are important files that Microsoft projects should all have that are not present in this repository. A pull request has been opened to add the missing file(s). When the pr is merged this issue will be closed automatically.

Microsoft teams can learn more about this effort and share feedback within the open source guidance available internally.

Merge this pull request

The pNIC.Hidden directory is incorrectly named. It contains Software/Virtual NICs.

Recommended changes:

1. Refactor the directory to NIC.Hidden
2. use swNIC for SW NICs
3. use pNIC if it is a Physical NIC
4. use vNIC if it's a Virtual NIC.

Avoid marking the SW NICs as vNICs. swNIC is a better naming. Specifically because they are not part of the Virtualization stack. Marking them as vNICs will be confusing to non-network folks.

Hey Tom, We discussed this internally over email.
#2. Also still need a file with the time sorted output by time so we can point folks concerned about execution time to said file. And they can follow up with the relevant CMDLET owners instead of Get-NetView.