Git Product home page Git Product logo

embeddedsocial-android-sdk's Introduction

embeddedsocial-android-sdk's People

Contributors

acrown-msft avatar barbeau avatar msftgits avatar sharadagarwal avatar ssaroiu avatar tslilyai avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

embeddedsocial-android-sdk's Issues

[Functional-Social Embedded- Edit Profile]: After removing the photo "Profile photo" is still displaying.

Priority:

Repro Steps

  1. Install ""One Bus Away"" app on Android.
  2. Start ""One Bus Away"" app from Android phone.
  3. ""One Bus Away "" Home page will get appear.
  4. Navigate to ""Open Navigation Drawer"" button and press ENTER (or double tap) to open.
  5. Navigate to ""Sign In"" and press ENTER (or double tap) to open.
  6. Navigate to ""Sign In with google"" and press ENTER (or double tap) to open.
  7. Login with valid google account credentials.
  8. “Create Profile” page will get appear.
  9. Fill all the input fields with valid inputs.
  10. Navigate to ""Done"" button and press ENTER.
  11. Navigate to ""Open Navigation Drawer"" button and press ENTER (or double tap).
  12. Navigate to ""My Profile"" and press ENTER (or double tap) to open.
  13. Navigate to ""Edit Profile"" and press ENTER (or double tap) to open.
  14. Navigate to ""Upload Photo"" and press ENTER (or double tap) to open, Select any one option form the two options that is ""Take new photo"" and ""Choose existing photo"".
  15. Navigate to ""Edit"" button and press ENTER (or double tap) to open, Select ""Remove Photo"" and press ENTER (or double tap) to remove photo.
  16. Verify that photo is still displaying.

Expected
When user upload photo, and photo has been uploaded. Again user edit the profile and remove the photo then photo should be remove. It should not be display.

Actual
When user upload photo, and photo has been uploaded. Again user edit the profile and remove the photo, but photo is still displaying.

MAS Rule: Functional

Impact
If user remove the photo but it is still display in the profile image then user will face difficulty and will not able to understand that photo has been removed or not.

Test Environment
OS: Android
Device Model No. : Nexus 5
Android Version : 6.0.1
App: Social Embedded
App Version : v2.2.3 (84)
Tool : Talk Back

[Supporting the platform-Social Embedded-Create Profile]: Test is not resized when user toggle the large text setting.

Priority: Low

Repro Steps
Pre-requisite:
Settings -> Accessibility ->tap Font size -> Use the slider to choose your font size

  1. Install ""One Bus Away"" app on Android.
  2. Start ""One Bus Away"" app from Android phone.
  3. ""One Bus Away "" Home page will get appear.
  4. Navigate to ""Open Navigation Drawer"" button and press ENTER (or double tap) to open.
  5. Navigate to ""Sign In"" and press ENTER (or double tap) to open.
  6. Navigate to ""Sign In with google"" and press ENTER (or double tap) to open.
  7. Login with valid google account credentials.
  8. “Create Profile” page will get appear.
  9. Verify the text is resized in large text setting or not.

Expected
""Create Profile"" page should be resize when user select large text setting. Page should adopt system controls in large text setting.

Actual
""Create Profile"" page is not resizing when user select large text setting. Page is not adopting system controls in large text setting.

Note:
1> Issue is repro throughout the application.

MAS Rule: MAS1.4.4

Impact
People with vision impairment and cognitive disabilities will get confused if text is not adopting system controls in large text setting.

Test Environment
OS: Android
Device Model No. : Nexus 5
Android Version : 6.0.1
App: Social Embedded
App Version : v2.2.3 (84)
Tool :Large Text Setting

[Functional-Social Embedded- Profile]: "Navigate Up" button functionality is not working.

Priority:

Repro Steps

  1. Install ""One Bus Away"" app on Android.
  2. Start ""One Bus Away"" app from Android phone.
  3. ""One Bus Away "" Home page will get appear.
  4. Navigate to ""Open Navigation Drawer"" button and press ENTER (or double tap) to open.
  5. Navigate to ""Sign In"" and press ENTER (or double tap) to open.
  6. Navigate to ""Sign In with google"" and press ENTER (or double tap) to open.
  7. Login with valid google account credentials.
  8. “Create Profile” page will get appear.
  9. Fill all the input fields with valid inputs.
  10. Navigate to ""Done"" button and press ENTER.
  11. Navigate to ""Open Navigation Drawer"" button and press ENTER (or double tap).
  12. Navigate to ""My Profile"" and press ENTER (or double tap) to open.
  13. Navigate to ""New Follow Requests"" and press ENTER (or double tap) to open.
  14. Verify that ""Navigate Up"" button is working or not.

Expected
""Navigate Up"" button functionality should be work properly so that user can come back previous page using ""Navigate Up"" button.

Actual
""Navigate Up"" button functionality is not working. User unable to come back previous page using ""Navigate Up"" button.

MAS Rule: Functional

Impact
User would get confuse and face difficulty If the ""Navigate Up"" button functionality is not working.

Test Environment
OS: Android
Device Model No. : Nexus 5
Android Version : 6.0.1
App: Social Embedded
App Version : v2.2.3 (84)
Tool : Talk Back

[Visual Requirement -Embedded-Create Profile]: The Luminosity ratio of the "Create Profile", "Account Information" and "Done" button is less than 4.5:1.

Priority: Medium

Repro Steps

  1. Install ""One Bus Away"" app on Android.
  2. Start ""One Bus Away"" app from Android phone.
  3. ""One Bus Away "" Home page will get appear.
  4. Navigate to ""Open Navigation Drawer"" button and press ENTER (or double tap) to open.
  5. Navigate to ""Sign In"" and press ENTER (or double tap) to open.
  6. Navigate to ""Sign In with google"" and press ENTER (or double tap) to open.
  7. Login with valid google account credentials.
  8. “Create Profile” page will get appear.
  9. Verify that the luminosity ratio of the ""Create Profile"" page is less than 4.5:1.

Note:

  1. Luminosity ratio is less than 4.5:1 for many other different other elements texts and icons. (see attachment)

Expected
The luminosity ratio of the ""Create Profile"", ""Account Information"" and ""Done"" button should be greater than or equal to 4.5:1.

Actual
The luminosity ratio of the ""Create Profile"", ""Account Information"" and ""Done"" button is less than 4.5:1.

Note :
1> Same issue is repro throughout application for this color.

MAS Rule: MAS1.4.3

Impact
User who have vision Issues will find difficulty as Luminosity ratio is less than 4.5:1

Test Environment
OS: Android
Device Model No. : Nexus 5
Android Version : 6.0.1
App: Social Embedded
App Version : v2.2.3 (84)
Tool : CCA

Change "Delete account" to "Close account" per Privacy guidance

original id: 1182

During our Privacy review for the Android SDK, Privacy brought to us awareness that when a user deletes data we need to delete said data within 30 days.  Contrast this to the expectation that if a user closes their account (effectively deleting the account) we have 90 days to delete the data associated with their account.   Our current close account  flow uses the language  Delete account . The key takeaway is that Privacy feels by using Delete  in the language around a user closing/deleting their account, they may expect their account and related data to be deleted within 30 days instead of 90. 
To remedy this, Privacy recommends changing the Delete account  language to 
Close account . 
Please substitute  Close  for  Delete  in this flow.    
From the Options menu:   Delete account  should be  Close account     
From the  Delete account  screen   
-- Delete account  should be   -- Close account        
Please also change the language on this screen.    
Before:   This action will permanently delete your account and all associated information.  The account deletion cannot be undone.  Do you really want to do it?     
Suggested:   This action cannot be undone and will permanently close your account and remove your profile.  Are you sure you want to close your account?

[Screen Reader-Social Embedded-Edit Profile]: Label should be defined for "Toggle" button under privacy.

"Priority: High

Repro Steps

  1. Install ""One Bus Away"" app on Android.
  2. Start ""One Bus Away"" app from Android phone.
  3. ""One Bus Away "" Home page will get appear.
  4. Navigate to ""Open Navigation Drawer"" button and press ENTER (or double tap) to open.
  5. Navigate to ""Sign In"" and press ENTER (or double tap) to open.
  6. Navigate to ""Sign In with google"" and press ENTER (or double tap) to open.
  7. Login with valid google account credentials.
  8. “Create Profile” page will get appear.
  9. Fill all the input fields with valid inputs.
  10. Navigate to ""Done"" button and press ENTER.
  11. Navigate to ""Open Navigation Drawer"" button and press ENTER (or double tap).
  12. Navigate to ""My Profile"" and press ENTER (or double tap) to open.
  13. Navigate to ""Edit Profile"" and press ENTER (or double tap) to open.
  14. Navigate to ""Toggle"" button under ""Privacy"" .
  15. Verify that label is defined for ""Toggle"" button or not.

Expected
Label should be defined for ""Toggle"" button under privacy, So that Talk Back should announce ""Only approved followers can see my posts & comments toggle button switch ON"" or ""Only approved followers can see my posts & comments toggle button switch OFF"".

Actual
Label is not defined for ""Toggle"" button under privacy, Talk Back is announcing only ""On Switch"" and ""Off Switch"".

MAS Rule: MAS4.2.5

Impact
User who is rely on screen reader will not get complete information and might get confuse if label is not defined for the ""Toggle"" button.

Test Environment
OS: Android
Device Model No. : Nexus 5
Android Version : 6.0.1
App: Social Embedded
App Version : v2.2.3 (84)
Tool : Talk Back"

need some indication that images are still loading

When loading a topic feed, there is a spinner that spins while fetching the feed from the server. After the feed has been downloaded, the spinner stops. But some images may still be loading. During that time, the user experience is strange - the default image icon is visible for topics, but it is not clear to the user that the topic image is still loading.

I propose one of two solutions:

  1. spinner continues to spin while the images are loading
  2. use a different default image icon for topics/comments/users that have an image but the image has not yet been fetched; this default image icon could have some text that says "loading..." or some other visual indication that the image is loading. Once the image has been fetched, this default icon will be replaced with the actual image.

[Screen Reader-Social Embedded-Create Profile]: TalkBack is not announcing the labels with edit box.

Priority: High

Repro Steps

  1. Install ""One Bus Away"" app on Android.
  2. Start ""One Bus Away"" app from Android phone.
  3. ""One Bus Away "" Home page will get appear.
  4. Navigate to ""Open Navigation Drawer"" button and press ENTER (or double tap) to open.
  5. Navigate to ""Sign In"" and press ENTER (or double tap) to open.
  6. Navigate to ""Sign In with google"" and press ENTER (or double tap) to open.
  7. Login with valid google account credentials.
  8. “Create Profile” page will get appear.
  9. Navigate to “First Name” edit box.
  10. Verify the speech of talkback.

Expected
TalkBack should announce the labels with edit box. It should not announce “Edit” box editing.

Actual
TalkBack is not announcing the labels with edit box. It is announcing “Edit” box editing.

MAS Rule: MAS4.2.5

Impact
User who is rely on screen reader will not get complete information and might get confuse if labels are not associated or no instructions is defined for edit box.

Test Environment
OS: Android
Device Model No. : Nexus 5
Android Version : 6.0.1
App: Social Embedded
App Version : v2.2.3 (84)
Tool : Talk Back

Handle excess newlines in discussion items

original id: 1040

One attack on our our system includes creating tons of new line characters. Ex:  Hi                                there      This clutters up the UI and can harm the user experience.  One possible way to deal with this issue is to show the first 5 lines or so of a comment and add an  expand  button to show the rest.

[Functional-Social Embedded-Create Profile]:There is no information provided for the input text limit.

Priority:

Repro Steps

  1. Install "One Bus Away" app on Android.
  2. Start "One Bus Away" app from Android phone.
  3. "One Bus Away " Home page will get appear.
  4. Navigate to "Open Navigation Drawer" button and press ENTER (or double tap) to open.
  5. Navigate to "Sign In" and press ENTER (or double tap) to open.
  6. Navigate to "Sign In with google" and press ENTER (or double tap) to open.
  7. Login with valid google account credentials.
  8. “Create Profile” page will get appear.
  9. Navigate to “First Name” and enter valid input continuously.
  10. Verify that there is any information is provided regarding input text limit.

Expected
Proper information should be provided regarding the input text limit. Screen reader should also convey proper information regarding input text limit.

Actual
There is no information provided for the input text limit. Screen reader does not convey any information regarding input text limit, while there is input text have an limit.

MAS Rule: Functional

Impact
User who is rely on screen reader will get confuse and face difficulty if there is no information is provided for input text limit.

Test Environment
OS: Android
Device Model No. : Nexus 5
Android Version : 6.0.1
App: Social Embedded
App Version : v2.2.3 (84)
Tool : Talk Back

[Visual Requirements-Embedded-Create Profile]: TalkBack does not announce anything when page is getting loaded.

"Priority: High

Repro Steps

  1. Install ""One Bus Away"" app on Android.
  2. Start ""One Bus Away"" app from Android phone.
  3. ""One Bus Away "" Home page will get appear.
  4. Navigate to ""Open Navigation Drawer"" button and press ENTER (or double tap) to open.
  5. Navigate to ""Sign In"" and press ENTER (or double tap) to open.
  6. Navigate to ""Sign In with google"" and press ENTER (or double tap) to open.
  7. Login with valid google account credentials.
  8. “Create Profile” page will get appear.
  9. Fill all the input fields with valid inputs.
  10. Navigate to ""Done"" button and press enter.
  11. Verify the speech of TalkBack when page is loading.

Expected
TalkBack should convey the information when page is loading, so that screen reader user can identify the status of the loading page.

Actual
TalkBack does not provide any information about the page spinner when page is getting loaded.

MAS Rule: MAS 1.3.3

Impact
User will get no idea what is happening  on the page if screen reader does not provide any information when page is loading.

Test Environment
OS: Android
Device Model No. : Nexus 5
Android Version : 6.0.1
App: Social Embedded
App Version : v2.2.3 (84)
Tool : Talk Back"

[Screen Reader-Social Embedded-Report Post]: TalkBack announces the state as "selected" for all radio buttons (selected/non-selected) while navigating through the list items via keyboard.

Priority: High

Repro Steps

  1. Launch the One Bus Away App.
  2. Navigate to ""Sign In"" link under Hamburger link and press ENTER.
  3. Sign in screen showing all currently supported identity service providers will appear.
  4. Use any service provider for log in.
  5. Select any location bubble and see the given arrivals.
  6. Navigate to ""Join Discussion"" button and press ENTER.
  7. Navigate to ellipses next to the post (topic) and press ENTER.
  8. Press ENTER key on ""Report Post"" link and press ENTER to open ""Report an Issue"" page.
  9. Using keyboard, navigate through the different issues in the list.
  10. Verify the speech of talkback for all issues.

Expected
Talkback should announce the state as ""selected"" only for the selected radio buttons.So that screen reader users will not get confused to identify the selected radio buttons.

Actual
TalkBack announces the state as ""selected"" for all radio buttons (selected/non-selected) while navigating through the list items via keyboard.

MAS Rule: MAS4.2.2

Impact
If talkback announces the ""selected"" state for all radio buttons (selected/non-selected), then screen reader users will get confused to identify which radio buttons are selected and which are not.

Test Environment
OS: Android
Device Model No. : Nexus 5
Android Version : 6.0.1
App: Social Embedded
App Version : v2.2.3 (84)
Tool : Talk Back

[Keyboard Navigation-Embedded-Sign In]: "Sign In" page is not accessible via keyboard.

Priority: Medium

Repro Steps

  1. Install ""One Bus Away"" app on Android.
  2. Start ""One Bus Away"" app from Android phone.
  3. ""One Bus Away "" Home page will get appear.
  4. Navigate to ""Open Navigation Drawer"" button and press ENTER (or double tap) to open.
  5. Navigate to ""Sign In"" and press ENTER (or double tap) to open.
  6. “Sign in” page will get appear.
  7. Verify that “Sign In” is accessible via keyboard or not.

Expected
“Sign In” page should be accessible via keyboard, as well as swipe gesture.

Actual
“Sign In” page is not accessible via keyboard, while it is accessible swipe gesture.

Note : “Privacy Statement: and “Terms of Use” link is not accessible via swipe gesture.

MAS Rule: MAS4.2.11

Impact
If any control is not accessible with keyboard, So keyboard users will not get the control information in the application.

Test Environment
OS: Android
Device Model No. : Nexus 5
Android Version : 6.0.1
App: Social Embedded
App Version : v2.2.3 (84)
Tool : Talk Back

[Screen Reader-Social Embedded-Social Activities]: TalkBack does not announce the name for "More option" button.

"Priority: High

Repro Steps

  1. Launch the One Bus Away App.
  2. Navigate to ""Sign In"" link under Hamburger link and press ENTER.
  3. Sign in screen showing all currently supported identity service providers will appear.
  4. Use any service provider for log in.
  5. Select any location bubble and see the given arrivals.
  6. Navigate to ""Join Discussion"" button and press ENTER.
  7. Navigate to ""More option"" (ellipses) button.
  8. Verify the speech of talkback for ""More option"" button.

Note:

  1. Same issue is repro for ""Like"", ""Comment"", ""Pin"", ""Take a picture"" buttons and after uploading picture, the uploaded image button also. (see attachment)

Expected
TalkBack does not announce the name for ""More option"" button.Also talkback should announce the state as ""selected"" for the selected buttons like- like, pin etc.

Actual
Talback should announce the name for ""More Option"" button. Also talkback does not announce the state as ""selected"" for the selected buttons like- like, pin etc.

MAS Rule: MAS4.2.1

Impact
If relevant names are not defined for the controls on the page, then screen reader users will not be able to understand the purpose of using different controls on the page.

Test Environment
OS: Android
Device Model No. : Nexus 5
Android Version : 6.0.1
App: Social Embedded
App Version : v2.2.3 (84)
Tool : Talk Back"

[Functional-Social Embedded-Social Activities]: Incorrect time is displaying for every posted topic (Comment, Reply or any other topic).

Priority:

Repro Steps

  1. Launch the One Bus Away App.
  2. Navigate to ""Sign In"" link under Hamburger link and press ENTER.
  3. Sign in screen showing all currently supported identity service providers will appear.
  4. Use any service provider for log in.
  5. Select any location bubble and see the given arrivals.
  6. Navigate to ""Join Discussion"" button and press ENTER.
  7. Create any profile and comment on that profile post.
  8. Navigate to ""reply"" button and press ENTER to reply on that comment.
  9. Verify the posted time for ""Comment"" ""Reply"" and ""Discussion"".

Note:
1> Same issue is repro when user ""reply comment"".
2> Same issue is repro when user ""Join Discussion"".

Expected
Correct posted time should be display for the every posted ""comment"", ""reply"" comment as well as""join discussion"" and this time should also get updated timely. So that user gets to know when any particular comment/reply was posted.

Actual
When user submit any comment then the posted time is displaying ""9h"" by default. Initially it is displaying ""0s"" after 1 second it changes to ""9h"".

MAS Rule: Functional

Impact
Users will get confused and face difficulty if the incorrect posted time is displayed for comment/reply/post.

Test Environment
OS: Android
Device Model No. : Nexus 5
Android Version : 6.0.1
App: Social Embedded
App Version : v2.2.3 (84)
Tool : Talk Back

[Screen Reader-Social Embedded-Social Activities]: TalkBack does not read the full forms of the initials used for time (weeks, hours, seconds etc.)

Priority: High

Repro Steps

  1. Launch the One Bus Away App.
  2. Navigate to ""Sign In"" link under Hamburger link and press ENTER.
  3. Sign in screen showing all currently supported identity service providers will appear.
  4. Use any service provider for log in.
  5. Select any location bubble and see the given arrivals.
  6. Navigate to ""Join Discussion"" button and press ENTER.
  7. Create any profile and comment on that profile post.
  8. Navigate to ""reply"" button and reply on that comment.
  9. Navigate the page via swipe gesture.
    10.Verify the speech of Talk Back for initials used for time (weeks, hours, seconds etc.)

Expected
TalkBack should read the full forms of the initials used for time (weeks, hours, minute, seconds etc.), Talk Back should announce ""25 week"" , ""9 hour"", ""0 seconds"" etc.

Actual
TalkBack does not read the full forms of the initials used for time (weeks, hours, minute, seconds etc.), Talk Back is annoucing ""25w"" , ""9h"" etc. which is quite confusing for screen reader users to understand .

MAS Rule: MAS1.3.1

Impact
User who is rely on screen reader will get confuse d and face difficulty if TalkBack does not read the full forms of the initials used for time (weeks, hours, minute, seconds etc.).

Test Environment
OS: Android
Device Model No. : Nexus 5
Android Version : 6.0.1
App: Social Embedded
App Version : v2.2.3 (84)
Tool : Talk Back

non-signed in experience should still show new comment & new reply text entry

When the user is not signed in, and looks at a topic's comment feed, or a comment's reply feed, the UI does not show a new comment/reply text entry field. This increases user friction to contribute content, and increases user friction to sign in.

In addition to showing the text entry field, when the user is done typing in their comment/reply, and subsequently triggering sign-in, after sign-in is successful, the comment/reply should be automatically posted for the user.

Pins feed does not display all pinned topics

There is no button to load more pins. If a user has more pins than the default response size only the newest pins appear in the pin feed. There should be a way for users to view all of their pins from the pins fragment.

[Screen Reader-Social Embedded-Social Activities]: TalkBack focus is moving to the hidden elements.

Priority: High

Repro Steps

  1. Launch the One Bus Away App.
  2. Navigate to ""Sign In"" link under Hamburger link and press ENTER.
  3. Sign in screen showing all currently supported identity service providers will appear.
  4. Use any service provider for log in.
  5. Select any location bubble and see the given arrivals.
  6. Navigate to ""Join Discussion"" button and press ENTER.
  7. Navigate through the page via swipe and keyboard gesture both.
  8. Verify the talkback focus is moving to the hidden elements on the page.

Expected
TalkBack focus should not move to any hidden elements.

Actual
TalkBack focus is moving to the hidden elements.

MAS Rule: MAS4.2.10

Impact
If talkback focus is moving to any hidden element, then screen reader users will get confused in navigating through the page.

Test Environment
OS: Android
Device Model No. : Nexus 5
Android Version : 6.0.1
App: Social Embedded
App Version : v2.2.3 (84)
Tool : Talk Back

[Screen Reader-Social Embedded-Edit Profile]: Name is not defined for the "Edit" button.

"Priority: High

Repro Steps

  1. Install ""One Bus Away"" app on Android.
  2. Start ""One Bus Away"" app from Android phone.
  3. ""One Bus Away "" Home page will get appear.
  4. Navigate to ""Open Navigation Drawer"" button and press ENTER (or double tap) to open.
  5. Navigate to ""Sign In"" and press ENTER (or double tap) to open.
  6. Navigate to ""Sign In with google"" and press ENTER (or double tap) to open.
  7. Login with valid google account credentials.
  8. “Create Profile” page will get appear.
  9. Fill all the input fields with valid inputs.
  10. Navigate to ""Done"" button and press ENTER.
  11. Navigate to ""Open Navigation Drawer"" button and press ENTER (or double tap).
  12. Navigate to ""My Profile"" and press ENTER (or double tap) to open.
  13. Navigate to ""Edit Profile"" and press ENTER (or double tap) to open.
  14. Navigate to ""Upload Photo"" and press ENTER (or double tap) to open, Select any one option form the two options that is ""Take new photo"" and ""Choose existing photo"".
  15. Navigate to ""Edit"" button.
  16. Verify that name is defined for ""Edit"" button or not.

Expected
Name should be defined for the ""Edit"" button. Talk Back should announce ""Edit"" button.

Actual
Name is not defined for the ""Edit"" button. Talk Back is announcing Unlabelled button.

MAS Rule: MAS4.2.1

Impact
User would get confuse and disorient, If the name is not defined for the any control. User will face difficulty to know the purpose of button.

Test Environment
OS: Android
Device Model No. : Nexus 5
Android Version : 6.0.1
App: Social Embedded
App Version : v2.2.3 (84)
Tool : Talk Back"

[Supporting the platform-Social Embedded-Sign In]:"Powered by Microsoft Embedded Social" text is not adopting system in high contrast setting.

Priority: Low

Repro Steps
Pre-requisite:
Apply High Contrast : (Settings> Accessibility> High contrast>Toggle on)

  1. Install ""One Bus Away"" app on Android.
  2. Start ""One Bus Away"" app from Android phone.
  3. ""One Bus Away "" Home page will get appear.
  4. Navigate to ""Open Navigation Drawer"" button and press ENTER (or double tap) to open.
  5. Navigate to ""Sign In"" and press ENTER (or double tap) to open.
  6. “Sign in” page will get appear.
  7. Verify if ""Powered by Microsoft Embedded Social"" text is adopting system control in all High Contrast Setting.

Expected
""Powered by Microsoft Embedded Social"" text should be adopt system controls in high contrast setting.

Actual
""Powered by Microsoft Embedded Social"" text is not adopting system control in high contrast setting.

Note:
1> Issue is repro throughout the application for ""Social Embedded"" part.

MAS Rule: MAS4.3.1

Impact
People with vision impairment and cognitive disabilities will get confused if text is not adopting system controls in High Contrast setting.

Test Environment
OS: Android
Device Model No. : Nexus 5
Android Version : 6.0.1
App: Social Embedded
App Version : v2.2.3 (84)
Tool : High Contrast Setting

[Functional-Social Embedded-Create Profile]: No textual information is provided for “Required” input fields

"Priority:

Repro Steps

  1. Install ""One Bus Away"" app on Android.
  2. Start ""One Bus Away"" app from Android phone.
  3. ""One Bus Away "" Home page will get appear.
  4. Navigate to ""Open Navigation Drawer"" button and press ENTER (or double tap) to open.
  5. Navigate to ""Sign In"" and press ENTER (or double tap) to open.
  6. Navigate to ""Sign In with google"" and press ENTER (or double tap) to open.
  7. Login with valid google account credentials.
  8. “Create Profile” page will get appear.
  9. Verify that there is any information provided regarding “Required” fields.

Expected
Textual information should be provided for the “Text” boxes, so that screen reader user or keyboard user will get proper information regarding “Required” fields.

Actual
There is no textual information is provided for “Required” fields, And screen reader also does not convey anything regarding “required” fields. While “First Name” and “Last Name” text box is required fields.

MAS Rule: Functional

Impact
User who is rely on screen reader or keyboard will not get any information if there is no textual information is provided for “Required” fields.

Test Environment
OS: Android
Device Model No. : Nexus 5
Android Version : 6.0.1
App: Social Embedded
App Version : v2.2.3 (84)
Tool : Talk Back"

Scope out work to fix Android SDK feeds

original id: 1263

Our feeds currently fetch every item in a feed and display them oldest (top) to newest (bottom).  We need to scope out the work to:   
Fix the client implementation to pull items down as needed (not the entire feed at once) 
Design more sensible UI for the various feeds 
Implement the changes to UI and create sensible triggers to fetch more data

refresh UI after executing user action after a user is forced to sign-in

When a user is not signed-in, and they attempt one of the following actions, they will be forced to sign-in:

  1. like
  2. post topic/comment/reply
  3. sign-in
  4. follow
  5. pin
  6. block
  7. report post

After they go through auth and successfully sign-in, the original action that they were attempting to do is then be executed automatically for the user.

In at least the case of like, the action is submitted but the UI is not refreshed automatically, so the like does not appear until you pull to refresh.

[Keyboard Navigation - Social Embedded-Edit Profile]: There is no consistent navigation on "Edit Profile" page.

"Priority: Low

Repro Steps

  1. Install ""One Bus Away"" app on Android.
  2. Start ""One Bus Away"" app from Android phone.
  3. ""One Bus Away "" Home page will get appear.
  4. Navigate to ""Open Navigation Drawer"" button and press ENTER (or double tap) to open.
  5. Navigate to ""Sign In"" and press ENTER (or double tap) to open.
  6. Navigate to ""Sign In with google"" and press ENTER (or double tap) to open.
  7. Login with valid google account credentials.
  8. “Create Profile” page will get appear.
  9. Fill all the input fields with valid inputs.
  10. Navigate to ""Done"" button and press ENTER.
  11. Navigate to ""Open Navigation Drawer"" button and press ENTER (or double tap).
  12. Navigate to ""My Profile"" and press ENTER (or double tap) to open.
  13. Navigate to ""Edit Profile"" and press ENTER (or double tap) to open.
  14. Navigate the page via ""TAB"" key .
  15. Verify the consistent navigation on page.

Expected
While navigating via TAB key, when focus goes on edit box if device keyboard is display then it should be display for all edit box, if not then it should not display for all edit box. It means there should be consistency in navigation.

Actual
While navigating via TAB key, when focus goes on edit box then device keyboard is displaying for ""Last Name"" & ""Bio(Optional)"" edit box, while keyboard is not displaying on ""First Name"" edit box.

MAS Rule: MAS3.2.3

Impact
User would get confuse and disorient, If the device keyboard is opens on ""First Name"" edit box, but not for other edit box.

Test Environment
OS: Android
Device Model No. : Nexus 5
Android Version : 6.0.1
App: Social Embedded
App Version : v2.2.3 (84)
Tool : Talk Back"

IllegalStateException in onTokenRequestCompleted()

From the OneBusAway Android rollout via the Android Developer Console - affecting 3 users (3 crashes):

java.lang.IllegalStateException: 
  at android.support.v4.app.Fragment.getResources (Fragment.java:608)
  at android.support.v4.app.Fragment.getString (Fragment.java:632)
  at com.microsoft.embeddedsocial.c.d$1.onTokenRequestCompleted (Unknown Source:30)
  at net.openid.appauth.AuthorizationService$TokenRequestTask.onPostExecute (AuthorizationService.java:308)
  at net.openid.appauth.AuthorizationService$TokenRequestTask.onPostExecute (AuthorizationService.java:238)
  at android.os.AsyncTask.finish (AsyncTask.java:695)
  at android.os.AsyncTask.-wrap1 (Unknown Source)
  at android.os.AsyncTask$InternalHandler.handleMessage (AsyncTask.java:712)
  at android.os.Handler.dispatchMessage (Handler.java:105)
  at android.os.Looper.loop (Looper.java:164)
  at android.app.ActivityThread.main (ActivityThread.java:6940)
  at java.lang.reflect.Method.invoke (Native Method)
  at com.android.internal.os.Zygote$MethodAndArgsCaller.run (Zygote.java:327)
  at com.android.internal.os.ZygoteInit.main (ZygoteInit.java:1374)

I'm assuming this happens when someone tries to log into Embedded Social in the OBA app and then closes it, likely under poor wireless conditions that cause a significant delay in onTokenRequestCompleted() returning.

Devices affected:

  • Samsung Galaxy Note8 (greatqlte), 6144MB RAM, Android 8.0
  • Google Pixel 2 (walleye), 4096MB RAM, Android 8.1
  • ZTE Blade X Max (stollen), 2048MB RAM, Android 7.1

Note that the Note 8 and Pixel 2 are affected, so this does affect flagship devices

[Keyboard Navigation-Embedded-Social Activities]:TalkBack focus is not going on "Report Post" link when user double tap on "More Option" button.

Priority: Medium

Repro Steps

  1. Launch the One Bus Away App.
  2. Navigate to ""Sign In"" link under Hamburger link and press ENTER.
  3. Sign in screen showing all currently supported identity service providers will appear.
  4. Use any service provider for log in.
  5. Select any location bubble and see the given arrivals.
  6. Navigate to ""Join Discussion"" button and press ENTER.
  7. Navigate to ellipses next to the post (topic) and press ENTER.
  8. Navigate to ""More Option"" (vertical ellipse) button and double tap or press ENTER key.
  9. Verify the TalkBack focus is going on ""Report Post"" link or not.

Expected
TalkBack focus should go on ""Report Post"" link when user press ENTER key or double tap on ""More Option"" button. It should not retains on the ""More Option"" button.

Actual
TalkBack focus is not going ""Report Post"" link when user press ENTER key or double tap on ""More Option"" button. It retains on the ""More Option"" button.

MAS Rule: MAS3.2.1

Impact
User who depend on the keyboard will face difficulty if TalkBack focus is not going on ""Report Post"" link after activating the ""More option"" button.

Test Environment
OS: Android
Device Model No. : Nexus 5
Android Version : 6.0.1
App: Social Embedded
App Version : v2.2.3 (84)
Tool : Talk Back

Update to new OpenID AppAuth-Android version that includes support library v26

I'm in the process of updating OneBusAway Android to support Android Studio 3.0 and v3 of the Android Gradle plugin.

Android Studio 3.0 now flags mismatched support library versions as an error (although the project still builds and runs ok):

image

Looking closer, the OpenID AppAuth library is still using support library v24. On OBA Android, if you run:

gradlew -q dependencies onebusaway-android:dependencies --configuration obaGoogleDebugAndroidTestCompileClasspath

You get:

...
\--- com.acrowntest.test:sdk:0.0.37
     +--- com.squareup.picasso:picasso:2.5.2
     +--- com.fasterxml.jackson.core:jackson-annotations:2.6.2 -> 2.7.0
     +--- com.google.android.gms:play-services-gcm:9.4.0
     |    +--- com.google.android.gms:play-services-base:9.4.0 (*)
     |    +--- com.google.android.gms:play-services-basement:9.4.0 (*)
     |    \--- com.google.android.gms:play-services-iid:9.4.0
     |         +--- com.google.android.gms:play-services-base:9.4.0 (*)
     |         \--- com.google.android.gms:play-services-basement:9.4.0 (*)
     +--- com.google.android.gms:play-services-auth:9.4.0
     |    +--- com.google.android.gms:play-services-auth-base:9.4.0
     |    |    +--- com.google.android.gms:play-services-base:9.4.0 (*)
     |    |    \--- com.google.android.gms:play-services-basement:9.4.0 (*)
     |    +--- com.google.android.gms:play-services-base:9.4.0 (*)
     |    \--- com.google.android.gms:play-services-basement:9.4.0 (*)
     +--- net.openid:appauth:0.3.0  // This library is still using support library v24
     |    \--- com.android.support:customtabs:24.0.0
     |         +--- com.android.support:support-annotations:24.0.0 -> 26.1.0
     |         \--- com.android.support:support-v4:24.0.0 -> 26.1.0 (*)
...

The ES SDK is currently using compile 'net.openid:appauth:0.3.0'. Version 0.7.0 is currently available on Maven Central, but this only supports v25 of the support library.

So, we need AppAuth to release a new version that includes support library v26. I've commented on an issue here on the AppAuth project requesting a new release to track this:
openid/AppAuth-Android#298

Add telemetry to SDK

original id: 998

We have chosen to go ahead with Aria as our telemetry solution.  This needs to be implemented in the SDK.    ---  Update  This is under development with Flurry analytics / some other provider.

[Screen Reader-Social Embedded-Report Post]: TalkBack announces incorrect state for the radio buttons.

"Priority: High

Repro Steps

  1. Launch the One Bus Away App.
  2. Navigate to ""Sign In"" link under Hamburger link and press ENTER.
  3. Sign in screen showing all currently supported identity service providers will appear.
  4. Use any service provider for log in.
  5. Select any location bubble and see the given arrivals.
  6. Navigate to ""Join Discussion"" button and press ENTER.
  7. Navigate to ellipses next to the post (topic) and press ENTER.
  8. Press ENTER key on ""Report Post"" link and press ENTER to open ""Report an Issue"" page.
  9. Swipe to navigae to any selected radio button.
  10. Verify the speech of talkback for the selected radio button.

Expected
Talkback should announce the state as ""Selected"" for selected radio buttons, so that screen reader users can have a clear idea, that radio buttons are given for the single selection on the page.

Actual
Talkback announces ""Checked"" state for the selected radio button. It might confuse screen reader users whether they can make multiple selection in case of checkboxes with ""checked"" state or they can make only one selection in case of radio button with ""Selected"" state.

MAS Rule: MAS4.2.1

Impact
If talkback announces the incorrect state as ""Checked""for radio buttons, then screen reader users will get confused to identify the radio buttons for the selection on the page.

Test Environment
OS: Android
Device Model No. : Nexus 5
Android Version : 6.0.1
App: Social Embedded
App Version : v2.2.3 (84)
Tool : Talk Back"

[Screen Reader-Social Embedded-Edit Profile]: Talk Back does not convey anything regarding user action.

"Priority: High

Repro Steps

  1. Install ""One Bus Away"" app on Android.
  2. Start ""One Bus Away"" app from Android phone.
  3. ""One Bus Away "" Home page will get appear.
  4. Navigate to ""Open Navigation Drawer"" button and press ENTER (or double tap) to open.
  5. Navigate to ""Sign In"" and press ENTER (or double tap) to open.
  6. Navigate to ""Sign In with google"" and press ENTER (or double tap) to open.
  7. Login with valid google account credentials.
  8. “Create Profile” page will get appear.
  9. Fill all the input fields with valid inputs.
  10. Navigate to ""Done"" button and press ENTER.
  11. Navigate to ""Open Navigation Drawer"" button and press ENTER (or double tap).
  12. Navigate to ""My Profile"" and press ENTER (or double tap) to open.
  13. Navigate to ""Edit Profile"" and press ENTER (or double tap) to open.
  14. Navigate to ""Upload Photo"" and press ENTER (or double tap) to open, Select any one option form the two options that is ""Take new photo"" and ""Choose existing photo"".
  15. Navigate to ""Edit"" button and press ENTER (or double tap) to open, Select ""Remove Photo"" and press ENTER (or double tap) to remove photo.
  16. Verify the speech of Talk Back.

Expected
Talk Back should convey proper notification regarding user action, when user remove, upload the photo as well as create the profile.

Actual
Talk Back does not announce anything regarding user action, when user remove the photo.

Note:
1> Same issue repro when user upload the photo.
2> Same issue repro when user create the profile.

MAS Rule: MAS4.2.12

Impact
User would get confuse and disorient, If Talk Back does not convey any information regarding user action. User will face difficulty to know the same.

Test Environment
OS: Android
Device Model No. : Nexus 5
Android Version : 6.0.1
App: Social Embedded
App Version : v2.2.3 (84)
Tool : Talk Back"

[Keyboard Navigation - Social Embedded-Edit Profile]: Focus order is not logical in forward navigation.

"Priority: Medium

Repro Steps

  1. Install ""One Bus Away"" app on Android.
  2. Start ""One Bus Away"" app from Android phone.
  3. ""One Bus Away "" Home page will get appear.
  4. Navigate to ""Open Navigation Drawer"" button and press ENTER (or double tap) to open.
  5. Navigate to ""Sign In"" and press ENTER (or double tap) to open.
  6. Navigate to ""Sign In with google"" and press ENTER (or double tap) to open.
  7. Login with valid google account credentials.
  8. “Create Profile” page will get appear.
  9. Fill all the input fields with valid inputs.
  10. Navigate to ""Done"" button and press ENTER.
  11. Navigate to ""Open Navigation Drawer"" button and press ENTER (or double tap).
  12. Navigate to ""My Profile"" and press ENTER (or double tap) to open.
  13. Navigate to ""Edit Profile"" and press ENTER (or double tap) to open.
  14. Navigate the page via ""TAB"" key and ""Shift+TAB"" key.
  15. Verify that label is defined for ""Toggle"" button or not.

Expected
Focus order is not logical on the ""Edit Profile"" page. Focus jumps on ""Done"" button after ""Bio(optional)"" edit box.

Actual
Focus order is not logical in forward navigation (TAB Key) on the ""Edit Profile"" page. Focus jumps on ""Done"" button after ""Bio(optional)"" edit box. While focus order is logical in backward navigation (Shift+TAB Key).

MAS Rule: MAS2.4.3

Impact
User would get confuse and disorient, If the focus order is not logical while navigating via TAB key. But focus order is logical while navigating via Shift+TAB key.

Test Environment
OS: Android
Device Model No. : Nexus 5
Android Version : 6.0.1
App: Social Embedded
App Version : v2.2.3 (84)
Tool : Talk Back"

[Functional-Social Embedded-Create Profile]:Error message is displaying after entering the valid input.

"Priority:

Repro Steps

  1. Install ""One Bus Away"" app on Android.
  2. Start ""One Bus Away"" app from Android phone.
  3. ""One Bus Away "" Home page will get appear.
  4. Navigate to ""Open Navigation Drawer"" button and press ENTER (or double tap) to open.
  5. Navigate to ""Sign In"" and press ENTER (or double tap) to open.
  6. Navigate to ""Sign In with google"" and press ENTER (or double tap) to open.
  7. Login with valid google account credentials.
  8. “Create Profile” page will get appear.
  9. Navigate to “First Name” and enter valid input.
  10. Navigate to “Done” button and press enter then error message will appear on “Last Name” edit box.
  11. Navigate to “First Name” and delete the entered input text.
  12. Navigate to “Last Name” and enter the valid input text.
  13. Navigate to “Done” button and press enter.
  14. Verify the error message on the edit boxes.

Expected
When user entered valid input text then error message should not be display.

Actual
When user entered valid input text but there is still error message is displaying.

MAS Rule: Functional

Impact
User who is rely on screen reader will get confuse and face difficulty if error message is still displaying after entering the correct input.

Test Environment
OS: Android
Device Model No. : Nexus 5
Android Version : 6.0.1
App: Social Embedded
App Version : v2.2.3 (84)
Tool : Talk Back"

[Screen Reader-Social Embedded-Social Activities]: TalkBack does not read the reply and comment text for the post.

Priority: High

Repro Steps

  1. Launch the One Bus Away App.
  2. Navigate to ""Sign In"" link under Hamburger link and press ENTER.
  3. Sign in screen showing all currently supported identity service providers will appear.
  4. Use any service provider for log in.
  5. Select any location bubble and see the given arrivals.
  6. Navigate to ""Join Discussion"" button and press ENTER.
  7. Create any profile and comment on that profile post.
  8. Navigate to ""reply"" button and press ENTER to reply on that comment.
  9. Verify the speech of talkback for the Reply text.

Note:

  1. Talkback focus is moving to the entire comment section first and read everything, however when talkback focus moves to separate text and controls, talkback does not read anything. Either focus should not move to the separate elements and if focus move to different elements, then talkback should read every elements.

Expected
TalkBack should read the Reply and Comment text for the post. What ever text is there under Reply section, talkback should read that text.

Actual
TalkBack does not read the Reply and Comment text for the post.

MAS Rule: MAS4.2.7

Impact
If talkback does not read the reply text, then screen reader users will not be able to read the reply for any post.

Test Environment
OS: Android
Device Model No. : Nexus 5
Android Version : 6.0.1
App: Social Embedded
App Version : v2.2.3 (84)
Tool : Talk Back

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.