Git Product home page Git Product logo

credential-secure-storage-for-java's People

Contributors

abyss638 avatar actions-user avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar

credential-secure-storage-for-java's Issues

Secure credentials encoding issue on Mac

Thanks for implementing this library, it's really useful! πŸŽ‰

I have bumped into a small issue while using it on Mac: if the username or the password contains any special characters, they are not stored and retrieved correctly. E.g. if I store the username "tΓ€st", it retrieves this string: 0x74C3A47374 "t\303\244st

My macOS version is Sonoma 14.0.

Here is the code that I use to store the credentials:

fun storeAccount(accountKey: String, urlKey: String, settings: ServerConfiguration) {
    val credentialStorage = StorageProvider.getCredentialStorage(true, StorageProvider.SecureOption.REQUIRED)
    val storedSettings = Settings()

    if (settings.url.isEmpty()) {
        storedSettings.remove(urlKey)
        credentialStorage.delete(accountKey)
        return
    }

    storedSettings.putString(urlKey, settings.url)
    if (settings.username.isEmpty()) {
        credentialStorage.delete(accountKey)
        return
    }

    val credentialsToStore = StoredCredential(settings.username, settings.password.toCharArray())
    credentialStorage.add(accountKey, credentialsToStore)
}

This is used to load them:

fun getAccount(accountKey: String, urlKey: String): ServerConfiguration {
    val storedSettings = Settings()
    val url = storedSettings.getString(urlKey, "")
    val credentialStorage = StorageProvider.getCredentialStorage(true, StorageProvider.SecureOption.REQUIRED)
    val credential: StoredCredential? = credentialStorage.get(accountKey)
    val username = credential?.username ?: ""
    val password = (credential?.password ?: CharArray(0)).joinToString("")
    return ServerConfiguration(url, username, password)
}

I also tested on Windows and there it worked without issues. (Not sure about Linux as I didn't manage to get it running at all due to some strange NPEs, I'm still looking into that.)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.