microsoft / botframework-wechat Goto Github PK

WeChat Adapter for BotFramework

License: MIT License

C# 71.61% JavaScript 7.66% TypeScript 20.25% PowerShell 0.48%

botframework-wechat's Introduction

BotFramework-WeChat

Branch	Description	Build Status	Coverage Status
Master	WeChat Adapter Builds

Contributing

This project welcomes contributions and suggestions. Most contributions require you to agree to a Contributor License Agreement (CLA) declaring that you have the right to, and actually do, grant us the rights to use your contribution. For details, visit https://cla.opensource.microsoft.com.

When you submit a pull request, a CLA bot will automatically determine whether you need to provide a CLA and decorate the PR appropriately (e.g., status check, comment). Simply follow the instructions provided by the bot. You will only need to do this once across all repos using our CLA.

This project has adopted the Microsoft Open Source Code of Conduct. For more information see the Code of Conduct FAQ or contact [email protected] with any additional questions or comments.

botframework-wechat's People

Contributors

Stargazers

Watchers

botframework-wechat's Issues

cannot start Microsoft.Bot.Builder.Adapters.WeChat.TestBot solution

Just took latest code from GitHub and can not run it in vs2019
receive below error:

Application startup exception: System.ArgumentNullException: Value cannot be null.
Parameter name: path1
   at System.IO.Path.Combine(String path1, String path2)
   at Microsoft.AspNetCore.Mvc.ApplicationParts.RelatedAssemblyAttribute.GetRelatedAssemblies(Assembly assembly, Boolean throwOnError, Func`2 fileExists, Func`2 loadFile)
   at Microsoft.AspNetCore.Mvc.ApplicationParts.RelatedAssemblyAttribute.GetRelatedAssemblies(Assembly assembly, Boolean throwOnError)
   at Microsoft.AspNetCore.Mvc.ApplicationParts.ApplicationAssembliesProvider.GetRelatedAssemblies(Assembly assembly)
   at Microsoft.AspNetCore.Mvc.ApplicationParts.ApplicationAssembliesProvider.GetAssemblyItem(Assembly assembly)
   at Microsoft.AspNetCore.Mvc.ApplicationParts.ApplicationAssembliesProvider.ResolveFromDependencyContext(DependencyContext dependencyContext)
   at Microsoft.AspNetCore.Mvc.ApplicationParts.ApplicationAssembliesProvider.ResolveAssemblies(Assembly entryAssembly)+MoveNext()
   at Microsoft.AspNetCore.Mvc.ApplicationParts.ApplicationPartManager.PopulateDefaultParts(String entryAssemblyName)
   at Microsoft.Extensions.DependencyInjection.MvcCoreServiceCollectionExtensions.GetApplicationPartManager(IServiceCollection services)
   at Microsoft.Extensions.DependencyInjection.MvcCoreServiceCollectionExtensions.AddMvcCore(IServiceCollection services)
   at Microsoft.Extensions.DependencyInjection.MvcServiceCollectionExtensions.AddMvc(IServiceCollection services)
   at Microsoft.Bot.Builder.Adapters.WeChat.TestBot.Startup.ConfigureServices(IServiceCollection services) in MSBotAdapters\BotFramework-WeChat-master\samples\csharp_dotnetcore\Microsoft.Bot.Builder.Adapters.WeChat.TestBot\Startup.cs:line 27
--- End of stack trace from previous location where exception was thrown ---
   at Microsoft.AspNetCore.Hosting.ConventionBasedStartup.ConfigureServices(IServiceCollection services)
   at Microsoft.AspNetCore.Hosting.Internal.WebHost.EnsureApplicationServices()
   at Microsoft.AspNetCore.Hosting.Internal.WebHost.Initialize()
--- End of stack trace from previous location where exception was thrown ---
   at Microsoft.AspNetCore.Hosting.Internal.WebHost.BuildApplication()
crit: Microsoft.AspNetCore.Hosting.Internal.WebHost[6]
      Application startup exception
System.ArgumentNullException: Value cannot be null.
Parameter name: path1
   at System.IO.Path.Combine(String path1, String path2)

In addition exist warning that The target framework 'netcoreapp2.2' is out of support . I have seen #55 , but it seems not in main repository still....

Convert LocationRequest to location event?

BotFramework-WeChat/libraries/csharp_dotnetcore/Microsoft.Bot.Builder.Adapters.WeChat/WeChatMessageMapper.cs

Line 129 in 39c0479

var geo = new GeoCoordinates

Solutions have a location event definition and have used in in several skills:
https://microsoft.github.io/botframework-solutions/virtual-assistant/handbook/events/

Maybe it is better

Test project upgrade to dotnetcore 3.1

We need to upgrade to dotnetcore 3.1 since 2.2 is deprecated

Better method to convert HeroCard

Sometimes it does not contain neither Tap nor Images..

I also noticed that it is a very limited support for AdaptiveCard, sad..

Need myget source for wechat adapter

Event name is empty

No event name when bot received a event activity

MessageMenu Id is not correct

Receive id not correct when try using user click the Satisfied button.

{
    "head_content": "Are you satisfied with this service?",
    "list": [{
            "id": "101_teststring",
            "content": "Satisfied"
        },
        {
            "id": "102_teststring",
            "content": "NotSatisfied"
        }
    ],
    "tail_content": "You are welcome to come back again."
}

Repeated incoming messages when paused in debugger

Is it a special feature in WeChat? Please clarify in document.

Will we filter these repeated messages in adapter?

upgrade Microsoft.Bot.Builder.Adapters.WeChat.TestBot to version 3.1

Hello @timenick
The example Microsoft.Bot.Builder.Adapters.WeChat.TestBot using 'netcoreapp2.2' which is out of support
Can you please upgrade it to netcore 3.1?
Thanks

can we inject all components into the servicecollection?

So that I can inject custom IWeChatStorage,and manage the access token by myself.

Need push JS version to MyGet

Need push JS package to MyGet source

Lack support of OAuth

Currently dialog with Oauth cannot work and the flow will be stay in a bad status.

If Wechat channel cannot support it, please add doc about this.

Should I even depend on the typescript version?

From documentation and code changes looks like C# version has more maintenance, should I even consider using the typescript version? I'm asking because most my other code are in nodejs and would prefer typescript if it's well maintained.

Add force refresh the access_token feature

Need to provide a way to force refresh the API access token when token is refresh outside the WeChat
Adapter. Only one valid access token at the same time.