microsoft / aspnetcore-react-webapp Goto Github PK

Is your feature request related to a problem? No.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

Describe the solution you'd like
A clear and concise description of what you want to happen.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

Docker container won't build because dockerfile is still referencing 3.1 SDK.

Further, to be compatible with users running BuildKit repository aliases should be updated to lowercase (e.g. servicebuild instead of serviceBuild.

Describe the bug
When any [HttpPost] handler contains "Create" in its name, Nswag generates corresponding ApiClient method so that even successfull Status200Ok response (return Ok(...)) causes ApiClient to throw exception.

To Reproduce
Steps to reproduce the behavior:

1. Define new group NEW_GROUP without validation problems.
2. Create group using ApiClient by calling new ApiClient().groups_CreateGroup(NEW_GROUP);
3. See output of console.log() placed into the catch block.

Expected behavior
If creation succeed then updated Group Dto should have been returned. Catch block should not have been reached.

Screenshots

Desktop (please complete the following information):

• OS: Any
• Browser: Any
• Version: Any

Smartphone (please complete the following information):

• Device: Any
• OS: Any
• Browser: Any
• Version: Any

Additional context
This issue can be easily solved by removing "Create" from the name of handler or by using Created(url, createdDto) instead of Ok(createdDto).

This issue is also discussed at RicoSuter/NSwag#700, RicoSuter/NSwag#1668 and RicoSuter/NSwag#1259.

Describe the bug
When fetching using ApiClient so that some validation problem occurs, it's not possible to access validation errors in the object returned - ProblemDetails.

To Reproduce
Steps to reproduce the behavior:

1. Define new group NEW_GROUP with validation problems.
2. Create group using ApiClient by calling new ApiClient().groups_CreateGroup(NEW_GROUP);
3. See output of console.log() placed into the catch block.

Expected behavior
Request should have failed with status code 400 and object typeof ValidationProblemDetails should have been returned so that property "errors" could have been accessed. However, returned object typeof ProblemDetails does not contain errors property.

Desktop (please complete the following information):

• OS: Any
• Browser: Any
• Version: Any

Smartphone (please complete the following information):

• Device: Any
• OS: Any
• Browser: Any
• Version: Any

Additional context
This issue can be easily solved by setting

[ProducesResponseType(typeof(ValidationProblemDetails), (int)HttpStatusCode.BadRequest)]
[ProducesResponseType(typeof(void), (int)HttpStatusCode.OK)]

attributes on BaseController class.

There are important files that Microsoft projects should all have that are not present in this repository. A pull request has been opened to add the missing file(s). When the pr is merged this issue will be closed automatically.

Microsoft teams can learn more about this effort and share feedback within the open source guidance available internally.

Merge this pull request

I have created aspnet core react based app, which works fine locally for login system.
In production, I am facing issue while login.

When I reload web page (ctrl+shift+R) and then enter credential and do login, then HTTP error prompt as shown in image.
However, when I do login for the second time without reload, then login works as expected.

Issue flow:
Go to webpage URL.
Reload (ctrl+Shift+R)
Enter username and password.
Click on login.

Output
Http error as shown in image

Working fine.
Go to webpage URL.
Enter the credentials and login.
Login successful as expected.

So, the issue is with reload action.

With reload also, the login is supposed to work

Tested
Chrome

Describe the bug
When docker container is running, navigating to http://localhost:8080/swagger/index.html works, but http://localhost:8080 returns a 404.

To Reproduce
Steps to reproduce the behavior:

1. run docker-compose build
2. run docker-compose up
3. navigate to http://localhost:8080
4. See 404 error

Expected behavior
Navigating to http://localhost:8080 should bring you to the home page of the React app.